All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	"Christoph Hellwig" <hch@lst.de>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	<linux-block@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
	<linux-scsi@vger.kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>, Daniel Wagner <dwagner@suse.de>,
	"Wen Xiong" <wenxiong@us.ibm.com>, Hannes Reinecke <hare@suse.de>,
	Keith Busch <kbusch@kernel.org>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	"Adaptec OEM Raid Solutions" <aacraid@microsemi.com>,
	Subbu Seetharaman <subbu.seetharaman@broadcom.com>,
	Don Brace <don.brace@microchip.com>,
	"James Smart" <james.smart@broadcom.com>,
	Kashyap Desai <kashyap.desai@broadcom.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Nilesh Javali <njavali@marvell.com>
Subject: Re: [PATCH V2 4/6] scsi: set shost->use_managed_irq if driver uses managed irq
Date: Mon, 5 Jul 2021 08:35:59 +0100	[thread overview]
Message-ID: <0dda0d19-8f6d-b231-08f3-6cf594b83352@huawei.com> (raw)
In-Reply-To: <20210702150555.2401722-5-ming.lei@redhat.com>

On 02/07/2021 16:05, Ming Lei wrote:
> Set shost->use_managed_irq if irq vectors are allocated via
> pci_alloc_irq_vectors_affinity(PCI_IRQ_AFFINITY) or
> pci_alloc_irq_vectors(PCI_IRQ_AFFINITY).
> 
> The rule is that driver has to tell scsi core if managed irq is used.
> 
> Cc: Adaptec OEM Raid Solutions<aacraid@microsemi.com>
> Cc: Subbu Seetharaman<subbu.seetharaman@broadcom.com>
> Cc: John Garry<john.garry@huawei.com>
> Cc: Don Brace<don.brace@microchip.com>
> Cc: James Smart<james.smart@broadcom.com>
> Cc: Kashyap Desai<kashyap.desai@broadcom.com>
> Cc: Sathya Prakash<sathya.prakash@broadcom.com>
> Cc: Nilesh Javali<njavali@marvell.com>
> Signed-off-by: Ming Lei<ming.lei@redhat.com>
> ---
>   drivers/scsi/aacraid/linit.c              | 3 +++
>   drivers/scsi/be2iscsi/be_main.c           | 3 +++
>   drivers/scsi/csiostor/csio_init.c         | 3 +++
>   drivers/scsi/hisi_sas/hisi_sas_v3_hw.c    | 1 +
>   drivers/scsi/hpsa.c                       | 3 +++
>   drivers/scsi/lpfc/lpfc.h                  | 1 +
>   drivers/scsi/lpfc/lpfc_init.c             | 4 ++++
>   drivers/scsi/megaraid/megaraid_sas_base.c | 3 +++
>   drivers/scsi/mpt3sas/mpt3sas_scsih.c      | 3 +++
>   drivers/scsi/qla2xxx/qla_isr.c            | 5 ++++-
>   drivers/scsi/smartpqi/smartpqi_init.c     | 3 +++
>   11 files changed, 31 insertions(+), 1 deletion(-)

Hi Ming,

hisi sas v2 hw is missed - it supports managed interrupt as a platform 
device. Setting that flag in hisi_sas_v2_interrupt_preinit() might be best.

Thanks,
John

WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	"Christoph Hellwig" <hch@lst.de>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	<linux-block@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
	<linux-scsi@vger.kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>, Daniel Wagner <dwagner@suse.de>,
	"Wen Xiong" <wenxiong@us.ibm.com>, Hannes Reinecke <hare@suse.de>,
	Keith Busch <kbusch@kernel.org>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	"Adaptec OEM Raid Solutions" <aacraid@microsemi.com>,
	Subbu Seetharaman <subbu.seetharaman@broadcom.com>,
	Don Brace <don.brace@microchip.com>,
	"James Smart" <james.smart@broadcom.com>,
	Kashyap Desai <kashyap.desai@broadcom.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Nilesh Javali <njavali@marvell.com>
Subject: Re: [PATCH V2 4/6] scsi: set shost->use_managed_irq if driver uses managed irq
Date: Mon, 5 Jul 2021 08:35:59 +0100	[thread overview]
Message-ID: <0dda0d19-8f6d-b231-08f3-6cf594b83352@huawei.com> (raw)
In-Reply-To: <20210702150555.2401722-5-ming.lei@redhat.com>

On 02/07/2021 16:05, Ming Lei wrote:
> Set shost->use_managed_irq if irq vectors are allocated via
> pci_alloc_irq_vectors_affinity(PCI_IRQ_AFFINITY) or
> pci_alloc_irq_vectors(PCI_IRQ_AFFINITY).
> 
> The rule is that driver has to tell scsi core if managed irq is used.
> 
> Cc: Adaptec OEM Raid Solutions<aacraid@microsemi.com>
> Cc: Subbu Seetharaman<subbu.seetharaman@broadcom.com>
> Cc: John Garry<john.garry@huawei.com>
> Cc: Don Brace<don.brace@microchip.com>
> Cc: James Smart<james.smart@broadcom.com>
> Cc: Kashyap Desai<kashyap.desai@broadcom.com>
> Cc: Sathya Prakash<sathya.prakash@broadcom.com>
> Cc: Nilesh Javali<njavali@marvell.com>
> Signed-off-by: Ming Lei<ming.lei@redhat.com>
> ---
>   drivers/scsi/aacraid/linit.c              | 3 +++
>   drivers/scsi/be2iscsi/be_main.c           | 3 +++
>   drivers/scsi/csiostor/csio_init.c         | 3 +++
>   drivers/scsi/hisi_sas/hisi_sas_v3_hw.c    | 1 +
>   drivers/scsi/hpsa.c                       | 3 +++
>   drivers/scsi/lpfc/lpfc.h                  | 1 +
>   drivers/scsi/lpfc/lpfc_init.c             | 4 ++++
>   drivers/scsi/megaraid/megaraid_sas_base.c | 3 +++
>   drivers/scsi/mpt3sas/mpt3sas_scsih.c      | 3 +++
>   drivers/scsi/qla2xxx/qla_isr.c            | 5 ++++-
>   drivers/scsi/smartpqi/smartpqi_init.c     | 3 +++
>   11 files changed, 31 insertions(+), 1 deletion(-)

Hi Ming,

hisi sas v2 hw is missed - it supports managed interrupt as a platform 
device. Setting that flag in hisi_sas_v2_interrupt_preinit() might be best.

Thanks,
John

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-07-05  7:43 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02 15:05 [PATCH V2 0/6] blk-mq: fix blk_mq_alloc_request_hctx Ming Lei
2021-07-02 15:05 ` Ming Lei
2021-07-02 15:05 ` [PATCH V2 1/6] blk-mq: prepare for not deactivating hctx if managed irq isn't used Ming Lei
2021-07-02 15:05   ` Ming Lei
2021-07-02 15:05 ` [PATCH V2 2/6] nvme: pci: pass BLK_MQ_F_MANAGED_IRQ to blk-mq Ming Lei
2021-07-02 15:05   ` Ming Lei
2021-07-02 15:05 ` [PATCH V2 3/6] scsi: add flag of .use_managed_irq to 'struct Scsi_Host' Ming Lei
2021-07-02 15:05   ` Ming Lei
2021-07-05  9:25   ` John Garry
2021-07-05  9:25     ` John Garry
2021-07-05  9:55     ` Ming Lei
2021-07-05  9:55       ` Ming Lei
2021-07-06  5:37       ` Christoph Hellwig
2021-07-06  5:37         ` Christoph Hellwig
2021-07-06  7:41         ` Ming Lei
2021-07-06  7:41           ` Ming Lei
2021-07-06 10:32           ` Hannes Reinecke
2021-07-06 10:32             ` Hannes Reinecke
2021-07-07 10:53             ` Ming Lei
2021-07-07 10:53               ` Ming Lei
2021-07-02 15:05 ` [PATCH V2 4/6] scsi: set shost->use_managed_irq if driver uses managed irq Ming Lei
2021-07-02 15:05   ` Ming Lei
2021-07-05  7:35   ` John Garry [this message]
2021-07-05  7:35     ` John Garry
2021-07-06  5:38   ` Christoph Hellwig
2021-07-06  5:38     ` Christoph Hellwig
2021-07-02 15:05 ` [PATCH V2 5/6] virtio: add one field into virtio_device for recording if device " Ming Lei
2021-07-02 15:05   ` Ming Lei
2021-07-02 15:05   ` Ming Lei
2021-07-02 15:55   ` Michael S. Tsirkin
2021-07-02 15:55     ` Michael S. Tsirkin
2021-07-02 15:55     ` Michael S. Tsirkin
2021-07-05  2:48     ` Ming Lei
2021-07-05  2:48       ` Ming Lei
2021-07-05  2:48       ` Ming Lei
2021-07-05  3:59   ` Jason Wang
2021-07-05  3:59     ` Jason Wang
2021-07-05  3:59     ` Jason Wang
2021-07-06  5:42   ` Christoph Hellwig
2021-07-06  5:42     ` Christoph Hellwig
2021-07-06  5:42     ` Christoph Hellwig
2021-07-06  7:53     ` Ming Lei
2021-07-06  7:53       ` Ming Lei
2021-07-06  7:53       ` Ming Lei
2021-07-07  9:06     ` Thomas Gleixner
2021-07-07  9:06       ` Thomas Gleixner
2021-07-07  9:06       ` Thomas Gleixner
2021-07-07  9:42       ` Ming Lei
2021-07-07  9:42         ` Ming Lei
2021-07-07  9:42         ` Ming Lei
2021-07-07 14:05         ` Christoph Hellwig
2021-07-07 14:05           ` Christoph Hellwig
2021-07-07 14:05           ` Christoph Hellwig
2021-07-08  6:34           ` Ming Lei
2021-07-08  6:34             ` Ming Lei
2021-07-08  6:34             ` Ming Lei
2021-07-02 15:05 ` [PATCH V2 6/6] blk-mq: don't deactivate hctx if managed irq isn't used Ming Lei
2021-07-02 15:05   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dda0d19-8f6d-b231-08f3-6cf594b83352@huawei.com \
    --to=john.garry@huawei.com \
    --cc=aacraid@microsemi.com \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@wdc.com \
    --cc=don.brace@microchip.com \
    --cc=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.smart@broadcom.com \
    --cc=kashyap.desai@broadcom.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    --cc=njavali@marvell.com \
    --cc=sagi@grimberg.me \
    --cc=sathya.prakash@broadcom.com \
    --cc=subbu.seetharaman@broadcom.com \
    --cc=wenxiong@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.