From: Ming Lei <ming.lei@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-scsi@vger.kernel.org, Sagi Grimberg <sagi@grimberg.me>,
Daniel Wagner <dwagner@suse.de>, Wen Xiong <wenxiong@us.ibm.com>,
Hannes Reinecke <hare@suse.de>, Keith Busch <kbusch@kernel.org>,
Damien Le Moal <damien.lemoal@wdc.com>
Subject: Re: [PATCH V2 3/6] scsi: add flag of .use_managed_irq to 'struct Scsi_Host'
Date: Mon, 5 Jul 2021 17:55:49 +0800 [thread overview]
Message-ID: <YOLXJZF7wo/IiFMU@T590> (raw)
In-Reply-To: <47fc5ed1-29e3-9226-a111-26c271cb6d90@huawei.com>
On Mon, Jul 05, 2021 at 10:25:38AM +0100, John Garry wrote:
> On 02/07/2021 16:05, Ming Lei wrote:
> > blk-mq needs this information of using managed irq for improving
> > deactivating hctx, so add such flag to 'struct Scsi_Host', then
> > drivers can pass such flag to blk-mq via scsi_mq_setup_tags().
> >
> > The rule is that driver has to tell blk-mq if managed irq is used.
> >
> > Signed-off-by: Ming Lei<ming.lei@redhat.com>
>
> As was said before, can we have something like this instead of relying on
> the LLDs to do the setting:
>
> --------->8------------
>
> diff --git a/block/blk-mq-pci.c b/block/blk-mq-pci.c
> index b595a94c4d16..2037a5b69fe1 100644
> --- a/block/blk-mq-pci.c
> +++ b/block/blk-mq-pci.c
> @@ -37,7 +37,7 @@ int blk_mq_pci_map_queues(struct blk_mq_queue_map *qmap,
> struct pci_dev *pdev,
> for_each_cpu(cpu, mask)
> qmap->mq_map[cpu] = qmap->queue_offset + queue;
> }
> -
> + qmap->drain_hwq = 1;
The thing is that blk_mq_pci_map_queues() is allowed to be called for
non-managed irqs. Also some managed irq consumers don't use blk_mq_pci_map_queues().
So this way just provides hint about managed irq uses, but we really
need to get this flag set if driver uses managed irq.
Thanks,
Ming
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-scsi@vger.kernel.org, Sagi Grimberg <sagi@grimberg.me>,
Daniel Wagner <dwagner@suse.de>, Wen Xiong <wenxiong@us.ibm.com>,
Hannes Reinecke <hare@suse.de>, Keith Busch <kbusch@kernel.org>,
Damien Le Moal <damien.lemoal@wdc.com>
Subject: Re: [PATCH V2 3/6] scsi: add flag of .use_managed_irq to 'struct Scsi_Host'
Date: Mon, 5 Jul 2021 17:55:49 +0800 [thread overview]
Message-ID: <YOLXJZF7wo/IiFMU@T590> (raw)
In-Reply-To: <47fc5ed1-29e3-9226-a111-26c271cb6d90@huawei.com>
On Mon, Jul 05, 2021 at 10:25:38AM +0100, John Garry wrote:
> On 02/07/2021 16:05, Ming Lei wrote:
> > blk-mq needs this information of using managed irq for improving
> > deactivating hctx, so add such flag to 'struct Scsi_Host', then
> > drivers can pass such flag to blk-mq via scsi_mq_setup_tags().
> >
> > The rule is that driver has to tell blk-mq if managed irq is used.
> >
> > Signed-off-by: Ming Lei<ming.lei@redhat.com>
>
> As was said before, can we have something like this instead of relying on
> the LLDs to do the setting:
>
> --------->8------------
>
> diff --git a/block/blk-mq-pci.c b/block/blk-mq-pci.c
> index b595a94c4d16..2037a5b69fe1 100644
> --- a/block/blk-mq-pci.c
> +++ b/block/blk-mq-pci.c
> @@ -37,7 +37,7 @@ int blk_mq_pci_map_queues(struct blk_mq_queue_map *qmap,
> struct pci_dev *pdev,
> for_each_cpu(cpu, mask)
> qmap->mq_map[cpu] = qmap->queue_offset + queue;
> }
> -
> + qmap->drain_hwq = 1;
The thing is that blk_mq_pci_map_queues() is allowed to be called for
non-managed irqs. Also some managed irq consumers don't use blk_mq_pci_map_queues().
So this way just provides hint about managed irq uses, but we really
need to get this flag set if driver uses managed irq.
Thanks,
Ming
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-07-05 9:56 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 15:05 [PATCH V2 0/6] blk-mq: fix blk_mq_alloc_request_hctx Ming Lei
2021-07-02 15:05 ` Ming Lei
2021-07-02 15:05 ` [PATCH V2 1/6] blk-mq: prepare for not deactivating hctx if managed irq isn't used Ming Lei
2021-07-02 15:05 ` Ming Lei
2021-07-02 15:05 ` [PATCH V2 2/6] nvme: pci: pass BLK_MQ_F_MANAGED_IRQ to blk-mq Ming Lei
2021-07-02 15:05 ` Ming Lei
2021-07-02 15:05 ` [PATCH V2 3/6] scsi: add flag of .use_managed_irq to 'struct Scsi_Host' Ming Lei
2021-07-02 15:05 ` Ming Lei
2021-07-05 9:25 ` John Garry
2021-07-05 9:25 ` John Garry
2021-07-05 9:55 ` Ming Lei [this message]
2021-07-05 9:55 ` Ming Lei
2021-07-06 5:37 ` Christoph Hellwig
2021-07-06 5:37 ` Christoph Hellwig
2021-07-06 7:41 ` Ming Lei
2021-07-06 7:41 ` Ming Lei
2021-07-06 10:32 ` Hannes Reinecke
2021-07-06 10:32 ` Hannes Reinecke
2021-07-07 10:53 ` Ming Lei
2021-07-07 10:53 ` Ming Lei
2021-07-02 15:05 ` [PATCH V2 4/6] scsi: set shost->use_managed_irq if driver uses managed irq Ming Lei
2021-07-02 15:05 ` Ming Lei
2021-07-05 7:35 ` John Garry
2021-07-05 7:35 ` John Garry
2021-07-06 5:38 ` Christoph Hellwig
2021-07-06 5:38 ` Christoph Hellwig
2021-07-02 15:05 ` [PATCH V2 5/6] virtio: add one field into virtio_device for recording if device " Ming Lei
2021-07-02 15:05 ` Ming Lei
2021-07-02 15:05 ` Ming Lei
2021-07-02 15:55 ` Michael S. Tsirkin
2021-07-02 15:55 ` Michael S. Tsirkin
2021-07-02 15:55 ` Michael S. Tsirkin
2021-07-05 2:48 ` Ming Lei
2021-07-05 2:48 ` Ming Lei
2021-07-05 2:48 ` Ming Lei
2021-07-05 3:59 ` Jason Wang
2021-07-05 3:59 ` Jason Wang
2021-07-05 3:59 ` Jason Wang
2021-07-06 5:42 ` Christoph Hellwig
2021-07-06 5:42 ` Christoph Hellwig
2021-07-06 5:42 ` Christoph Hellwig
2021-07-06 7:53 ` Ming Lei
2021-07-06 7:53 ` Ming Lei
2021-07-06 7:53 ` Ming Lei
2021-07-07 9:06 ` Thomas Gleixner
2021-07-07 9:06 ` Thomas Gleixner
2021-07-07 9:06 ` Thomas Gleixner
2021-07-07 9:42 ` Ming Lei
2021-07-07 9:42 ` Ming Lei
2021-07-07 9:42 ` Ming Lei
2021-07-07 14:05 ` Christoph Hellwig
2021-07-07 14:05 ` Christoph Hellwig
2021-07-07 14:05 ` Christoph Hellwig
2021-07-08 6:34 ` Ming Lei
2021-07-08 6:34 ` Ming Lei
2021-07-08 6:34 ` Ming Lei
2021-07-02 15:05 ` [PATCH V2 6/6] blk-mq: don't deactivate hctx if managed irq isn't used Ming Lei
2021-07-02 15:05 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOLXJZF7wo/IiFMU@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.