From: Andrey Ryabinin <aryabinin@virtuozzo.com> To: Greg Hackmann <ghackmann@google.com>, Alexander Potapenko <glider@google.com>, Dmitry Vyukov <dvyukov@google.com>, Masahiro Yamada <yamada.masahiro@socionext.com>, Michal Marek <mmarek@suse.com> Cc: linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kbuild@vger.kernel.org, Matthias Kaehlcke <mka@chromium.org>, Michael Davidson <md@google.com> Subject: Re: [PATCH 1/4] kasan: support alloca() poisoning Date: Fri, 14 Jul 2017 19:52:05 +0300 [thread overview] Message-ID: <0e51dc15-1c93-2326-444d-8257b61af54f@virtuozzo.com> (raw) In-Reply-To: <39dd8c5c-e606-486a-bcef-b8481c5203a1@google.com> On 07/14/2017 01:49 AM, Greg Hackmann wrote: > On 07/10/2017 03:30 AM, Andrey Ryabinin wrote: >> gcc now supports this too. So I think this patch should enable it. >> It's off by default so you'll have to add --param asan-instrument-allocas=1 into cflags >> to make it work > > Thanks, will fix. For now, it looks like I'll need to build gcc from git to test this? > Right, you'll need quite fresh revision >= 250032 >>> lib/test_kasan.c | 22 ++++++++++++++++++++++ >> >> Tests would be better as a separate patch. > > I was following the precedent in 828347f8f9a5 ("kasan: support use-after-scope detection") which added both at the same time. But I can split the test off into a separate patch if you feel really strongly about it. Please, do the split.
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Ryabinin <aryabinin@virtuozzo.com> To: Greg Hackmann <ghackmann@google.com>, Alexander Potapenko <glider@google.com>, Dmitry Vyukov <dvyukov@google.com>, Masahiro Yamada <yamada.masahiro@socionext.com>, Michal Marek <mmarek@suse.com> Cc: linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kbuild@vger.kernel.org, Matthias Kaehlcke <mka@chromium.org>, Michael Davidson <md@google.com> Subject: Re: [PATCH 1/4] kasan: support alloca() poisoning Date: Fri, 14 Jul 2017 19:52:05 +0300 [thread overview] Message-ID: <0e51dc15-1c93-2326-444d-8257b61af54f@virtuozzo.com> (raw) In-Reply-To: <39dd8c5c-e606-486a-bcef-b8481c5203a1@google.com> On 07/14/2017 01:49 AM, Greg Hackmann wrote: > On 07/10/2017 03:30 AM, Andrey Ryabinin wrote: >> gcc now supports this too. So I think this patch should enable it. >> It's off by default so you'll have to add --param asan-instrument-allocas=1 into cflags >> to make it work > > Thanks, will fix. For now, it looks like I'll need to build gcc from git to test this? > Right, you'll need quite fresh revision >= 250032 >>> lib/test_kasan.c | 22 ++++++++++++++++++++++ >> >> Tests would be better as a separate patch. > > I was following the precedent in 828347f8f9a5 ("kasan: support use-after-scope detection") which added both at the same time. But I can split the test off into a separate patch if you feel really strongly about it. Please, do the split. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-07-14 16:49 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-06 22:01 [PATCH 0/4] kasan: add clang support Greg Hackmann 2017-07-06 22:01 ` Greg Hackmann 2017-07-06 22:01 ` [PATCH 1/4] kasan: support alloca() poisoning Greg Hackmann 2017-07-06 22:01 ` Greg Hackmann 2017-07-07 0:09 ` Greg Hackmann 2017-07-07 0:09 ` Greg Hackmann 2017-07-10 8:44 ` Dmitry Vyukov 2017-07-10 8:44 ` Dmitry Vyukov 2017-07-13 22:40 ` Greg Hackmann 2017-07-13 22:40 ` Greg Hackmann 2017-07-14 6:13 ` Dmitry Vyukov 2017-07-14 6:13 ` Dmitry Vyukov 2017-07-10 10:30 ` Andrey Ryabinin 2017-07-10 10:30 ` Andrey Ryabinin 2017-07-13 22:49 ` Greg Hackmann 2017-07-13 22:49 ` Greg Hackmann 2017-07-14 16:52 ` Andrey Ryabinin [this message] 2017-07-14 16:52 ` Andrey Ryabinin 2017-07-06 22:01 ` [PATCH 2/4] kasan: added functions for unpoisoning stack variables Greg Hackmann 2017-07-06 22:01 ` Greg Hackmann 2017-07-10 8:46 ` Dmitry Vyukov 2017-07-10 8:46 ` Dmitry Vyukov 2017-07-10 10:31 ` Andrey Ryabinin 2017-07-10 10:31 ` Andrey Ryabinin 2017-07-06 22:01 ` [PATCH 3/4] kasan: support LLVM-style asan parameters Greg Hackmann 2017-07-06 22:01 ` Greg Hackmann 2017-07-10 8:47 ` Dmitry Vyukov 2017-07-10 8:47 ` Dmitry Vyukov 2017-07-06 22:01 ` [PATCH 4/4] kasan: add compiler support for clang Greg Hackmann 2017-07-06 22:01 ` Greg Hackmann 2017-07-10 8:48 ` Dmitry Vyukov 2017-07-10 8:48 ` Dmitry Vyukov 2017-07-10 10:34 ` Andrey Ryabinin 2017-07-10 10:34 ` Andrey Ryabinin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0e51dc15-1c93-2326-444d-8257b61af54f@virtuozzo.com \ --to=aryabinin@virtuozzo.com \ --cc=dvyukov@google.com \ --cc=ghackmann@google.com \ --cc=glider@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=md@google.com \ --cc=mka@chromium.org \ --cc=mmarek@suse.com \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.