All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Hackmann <ghackmann@google.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <mmarek@suse.com>
Cc: linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
	linux-mm@kvack.org, linux-kbuild@vger.kernel.org,
	Matthias Kaehlcke <mka@chromium.org>,
	Michael Davidson <md@google.com>
Subject: Re: [PATCH 1/4] kasan: support alloca() poisoning
Date: Thu, 6 Jul 2017 17:09:31 -0700	[thread overview]
Message-ID: <504eb5d1-d505-46fe-86aa-5b2d01497c15@google.com> (raw)
In-Reply-To: <20170706220114.142438-2-ghackmann@google.com>

On 07/06/2017 03:01 PM, Greg Hackmann wrote:
> @@ -101,6 +101,9 @@ static const char *get_shadow_bug_type(struct kasan_access_info *info)
>   		break;
>   	case KASAN_USE_AFTER_SCOPE:
>   		bug_type = "use-after-scope";
> +	case KASAN_ALLOCA_LEFT:
> +	case KASAN_ALLOCA_RIGHT:
> +		bug_type = "alloca-out-of-bounds";
>   		break;
>   	}

There needs to be a "break" above the new case statements.  I'll wait to 
see if there's any other feedback, then send out a V2 patch that fixes this.

WARNING: multiple messages have this Message-ID (diff)
From: Greg Hackmann <ghackmann@google.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <mmarek@suse.com>
Cc: linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
	linux-mm@kvack.org, linux-kbuild@vger.kernel.org,
	Matthias Kaehlcke <mka@chromium.org>,
	Michael Davidson <md@google.com>
Subject: Re: [PATCH 1/4] kasan: support alloca() poisoning
Date: Thu, 6 Jul 2017 17:09:31 -0700	[thread overview]
Message-ID: <504eb5d1-d505-46fe-86aa-5b2d01497c15@google.com> (raw)
In-Reply-To: <20170706220114.142438-2-ghackmann@google.com>

On 07/06/2017 03:01 PM, Greg Hackmann wrote:
> @@ -101,6 +101,9 @@ static const char *get_shadow_bug_type(struct kasan_access_info *info)
>   		break;
>   	case KASAN_USE_AFTER_SCOPE:
>   		bug_type = "use-after-scope";
> +	case KASAN_ALLOCA_LEFT:
> +	case KASAN_ALLOCA_RIGHT:
> +		bug_type = "alloca-out-of-bounds";
>   		break;
>   	}

There needs to be a "break" above the new case statements.  I'll wait to 
see if there's any other feedback, then send out a V2 patch that fixes this.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-07-07  0:09 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06 22:01 [PATCH 0/4] kasan: add clang support Greg Hackmann
2017-07-06 22:01 ` Greg Hackmann
2017-07-06 22:01 ` [PATCH 1/4] kasan: support alloca() poisoning Greg Hackmann
2017-07-06 22:01   ` Greg Hackmann
2017-07-07  0:09   ` Greg Hackmann [this message]
2017-07-07  0:09     ` Greg Hackmann
2017-07-10  8:44   ` Dmitry Vyukov
2017-07-10  8:44     ` Dmitry Vyukov
2017-07-13 22:40     ` Greg Hackmann
2017-07-13 22:40       ` Greg Hackmann
2017-07-14  6:13       ` Dmitry Vyukov
2017-07-14  6:13         ` Dmitry Vyukov
2017-07-10 10:30   ` Andrey Ryabinin
2017-07-10 10:30     ` Andrey Ryabinin
2017-07-13 22:49     ` Greg Hackmann
2017-07-13 22:49       ` Greg Hackmann
2017-07-14 16:52       ` Andrey Ryabinin
2017-07-14 16:52         ` Andrey Ryabinin
2017-07-06 22:01 ` [PATCH 2/4] kasan: added functions for unpoisoning stack variables Greg Hackmann
2017-07-06 22:01   ` Greg Hackmann
2017-07-10  8:46   ` Dmitry Vyukov
2017-07-10  8:46     ` Dmitry Vyukov
2017-07-10 10:31   ` Andrey Ryabinin
2017-07-10 10:31     ` Andrey Ryabinin
2017-07-06 22:01 ` [PATCH 3/4] kasan: support LLVM-style asan parameters Greg Hackmann
2017-07-06 22:01   ` Greg Hackmann
2017-07-10  8:47   ` Dmitry Vyukov
2017-07-10  8:47     ` Dmitry Vyukov
2017-07-06 22:01 ` [PATCH 4/4] kasan: add compiler support for clang Greg Hackmann
2017-07-06 22:01   ` Greg Hackmann
2017-07-10  8:48   ` Dmitry Vyukov
2017-07-10  8:48     ` Dmitry Vyukov
2017-07-10 10:34   ` Andrey Ryabinin
2017-07-10 10:34     ` Andrey Ryabinin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504eb5d1-d505-46fe-86aa-5b2d01497c15@google.com \
    --to=ghackmann@google.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=md@google.com \
    --cc=mka@chromium.org \
    --cc=mmarek@suse.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.