From: Arnd Bergmann <arnd@arndb.de>
To: Naveen Krishna Ch <naveenkrishna.ch@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
linux-serial@vger.kernel.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Pankaj Dubey <pankaj.dubey@samsung.com>
Subject: Re: [PATCH] tty/serial: fix config dependencies for samsung serial
Date: Wed, 03 Sep 2014 12:56:02 +0200 [thread overview]
Message-ID: <10202237.9vbtDF9MIQ@wuerfel> (raw)
In-Reply-To: <CAHfPSqAn5gHjDA75Zf1W5=GH9_W+X6+4oc9rDK7CqeSoF3DURw@mail.gmail.com>
On Wednesday 03 September 2014 13:51:56 Naveen Krishna Ch wrote:
> On 2 September 2014 21:16, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Tuesday 02 September 2014 20:52:00 Naveen Krishna Chatradhi wrote:
> >> Make the config symbols SERIAL_SAMSUNG_UARTS_4 and
> >> SERIAL_SAMSUNG_UARTS depend on SERIAL_SAMSUNG rather than
> >> PLAT_SAMSUNG.
> >
> > Please always describe why you are doing a change. This patch
> > seems really pointless.
>
> The SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS config options are
> meaningful only if SERIAL_SAMSUNG is enabled. Hence the dependency
> rules were changed. I will repost this patch with better description.
My point is that the options are used by both the uart driver and
the platform code, e.g. for the purpose of PM debugging which can
be enabled even when the serial-samsung driver is turned off.
> >> config SERIAL_SAMSUNG_UARTS_4
> >> bool
> >> - depends on PLAT_SAMSUNG
> >> + depends on SERIAL_SAMSUNG
> >> default y if !(CPU_S3C2410 || CPU_S3C2412 || CPU_S3C2440 || CPU_S3C2442)
> >> help
> >> Internal node for the common case of 4 Samsung compatible UARTs
> >>
> >> config SERIAL_SAMSUNG_UARTS
> >> int
> >> - depends on PLAT_SAMSUNG
> >> + depends on SERIAL_SAMSUNG
> >> default 4 if SERIAL_SAMSUNG_UARTS_4 || CPU_S3C2416
> >> default 3
> >> help
> >>
> >
> > Have you checked that it still builds on all samsung platforms when
> > SERIAL_SAMSUNG is disabled? We have had build errors in this area
> > in the past.
>
> Yes, it builds for other Samsung platforms.
Ok.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tty/serial: fix config dependencies for samsung serial
Date: Wed, 03 Sep 2014 12:56:02 +0200 [thread overview]
Message-ID: <10202237.9vbtDF9MIQ@wuerfel> (raw)
In-Reply-To: <CAHfPSqAn5gHjDA75Zf1W5=GH9_W+X6+4oc9rDK7CqeSoF3DURw@mail.gmail.com>
On Wednesday 03 September 2014 13:51:56 Naveen Krishna Ch wrote:
> On 2 September 2014 21:16, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Tuesday 02 September 2014 20:52:00 Naveen Krishna Chatradhi wrote:
> >> Make the config symbols SERIAL_SAMSUNG_UARTS_4 and
> >> SERIAL_SAMSUNG_UARTS depend on SERIAL_SAMSUNG rather than
> >> PLAT_SAMSUNG.
> >
> > Please always describe why you are doing a change. This patch
> > seems really pointless.
>
> The SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS config options are
> meaningful only if SERIAL_SAMSUNG is enabled. Hence the dependency
> rules were changed. I will repost this patch with better description.
My point is that the options are used by both the uart driver and
the platform code, e.g. for the purpose of PM debugging which can
be enabled even when the serial-samsung driver is turned off.
> >> config SERIAL_SAMSUNG_UARTS_4
> >> bool
> >> - depends on PLAT_SAMSUNG
> >> + depends on SERIAL_SAMSUNG
> >> default y if !(CPU_S3C2410 || CPU_S3C2412 || CPU_S3C2440 || CPU_S3C2442)
> >> help
> >> Internal node for the common case of 4 Samsung compatible UARTs
> >>
> >> config SERIAL_SAMSUNG_UARTS
> >> int
> >> - depends on PLAT_SAMSUNG
> >> + depends on SERIAL_SAMSUNG
> >> default 4 if SERIAL_SAMSUNG_UARTS_4 || CPU_S3C2416
> >> default 3
> >> help
> >>
> >
> > Have you checked that it still builds on all samsung platforms when
> > SERIAL_SAMSUNG is disabled? We have had build errors in this area
> > in the past.
>
> Yes, it builds for other Samsung platforms.
Ok.
Arnd
next prev parent reply other threads:[~2014-09-03 10:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 15:22 [PATCH] tty/serial: fix config dependencies for samsung serial Naveen Krishna Chatradhi
2014-09-02 15:22 ` Naveen Krishna Chatradhi
2014-09-02 15:46 ` Arnd Bergmann
2014-09-02 15:46 ` Arnd Bergmann
2014-09-03 8:21 ` Naveen Krishna Ch
2014-09-03 8:21 ` Naveen Krishna Ch
2014-09-03 8:21 ` Naveen Krishna Ch
2014-09-03 10:56 ` Arnd Bergmann [this message]
2014-09-03 10:56 ` Arnd Bergmann
2014-09-03 10:56 ` Arnd Bergmann
2014-09-23 7:04 ` Abhilash Kesavan
2014-09-23 7:04 ` Abhilash Kesavan
2014-09-23 7:04 ` Abhilash Kesavan
2014-09-23 8:07 ` Arnd Bergmann
2014-09-23 8:07 ` Arnd Bergmann
2014-09-23 8:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10202237.9vbtDF9MIQ@wuerfel \
--to=arnd@arndb.de \
--cc=ch.naveen@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=pankaj.dubey@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.