From: Abhilash Kesavan <kesavan.abhilash@gmail.com> To: Arnd Bergmann <arnd@arndb.de> Cc: Naveen Krishna Ch <naveenkrishna.ch@gmail.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Naveen Krishna Chatradhi <ch.naveen@samsung.com>, linux-serial@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Pankaj Dubey <pankaj.dubey@samsung.com> Subject: Re: [PATCH] tty/serial: fix config dependencies for samsung serial Date: Tue, 23 Sep 2014 12:34:26 +0530 [thread overview] Message-ID: <CAM4voaky-zin8ikdkLBwpTKy13hz3iON8tmNsd55-kr8po8Qaw@mail.gmail.com> (raw) In-Reply-To: <10202237.9vbtDF9MIQ@wuerfel> Hi Arnd, I will be taking this forward as Naveen is no longer with Samsung. On Wed, Sep 3, 2014 at 4:26 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Wednesday 03 September 2014 13:51:56 Naveen Krishna Ch wrote: >> On 2 September 2014 21:16, Arnd Bergmann <arnd@arndb.de> wrote: >> > On Tuesday 02 September 2014 20:52:00 Naveen Krishna Chatradhi wrote: >> >> Make the config symbols SERIAL_SAMSUNG_UARTS_4 and >> >> SERIAL_SAMSUNG_UARTS depend on SERIAL_SAMSUNG rather than >> >> PLAT_SAMSUNG. >> > >> > Please always describe why you are doing a change. This patch >> > seems really pointless. I will re-post the patch with a better commit message once we sort the below issue. >> >> The SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS config options are >> meaningful only if SERIAL_SAMSUNG is enabled. Hence the dependency >> rules were changed. I will repost this patch with better description. > > My point is that the options are used by both the uart driver and > the platform code, e.g. for the purpose of PM debugging which can > be enabled even when the serial-samsung driver is turned off. I looked through the code and could find two references to these symbols in the platform-specific code: arch/arm/plat-samsung/init.c and arch/arm/mach-s3c64xx/irq-pm.c. The first one is being used to initialize the uart platform device in non-dt way while the second one saves and restores the uart irq masks for all channels across a suspend/resume cycle. Also, the save/restore will get bypassed in case CONFIG_SERIAL_SAMSUNG_UARTS is not defined. It does not look like either of these cases would cause any issue with the current patch, can you please help me understand the problem ? Regards, Abhilash > >> >> config SERIAL_SAMSUNG_UARTS_4 >> >> bool >> >> - depends on PLAT_SAMSUNG >> >> + depends on SERIAL_SAMSUNG >> >> default y if !(CPU_S3C2410 || CPU_S3C2412 || CPU_S3C2440 || CPU_S3C2442) >> >> help >> >> Internal node for the common case of 4 Samsung compatible UARTs >> >> >> >> config SERIAL_SAMSUNG_UARTS >> >> int >> >> - depends on PLAT_SAMSUNG >> >> + depends on SERIAL_SAMSUNG >> >> default 4 if SERIAL_SAMSUNG_UARTS_4 || CPU_S3C2416 >> >> default 3 >> >> help >> >> >> > >> > Have you checked that it still builds on all samsung platforms when >> > SERIAL_SAMSUNG is disabled? We have had build errors in this area >> > in the past. >> >> Yes, it builds for other Samsung platforms. > > Ok. > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: kesavan.abhilash@gmail.com (Abhilash Kesavan) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] tty/serial: fix config dependencies for samsung serial Date: Tue, 23 Sep 2014 12:34:26 +0530 [thread overview] Message-ID: <CAM4voaky-zin8ikdkLBwpTKy13hz3iON8tmNsd55-kr8po8Qaw@mail.gmail.com> (raw) In-Reply-To: <10202237.9vbtDF9MIQ@wuerfel> Hi Arnd, I will be taking this forward as Naveen is no longer with Samsung. On Wed, Sep 3, 2014 at 4:26 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Wednesday 03 September 2014 13:51:56 Naveen Krishna Ch wrote: >> On 2 September 2014 21:16, Arnd Bergmann <arnd@arndb.de> wrote: >> > On Tuesday 02 September 2014 20:52:00 Naveen Krishna Chatradhi wrote: >> >> Make the config symbols SERIAL_SAMSUNG_UARTS_4 and >> >> SERIAL_SAMSUNG_UARTS depend on SERIAL_SAMSUNG rather than >> >> PLAT_SAMSUNG. >> > >> > Please always describe why you are doing a change. This patch >> > seems really pointless. I will re-post the patch with a better commit message once we sort the below issue. >> >> The SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS config options are >> meaningful only if SERIAL_SAMSUNG is enabled. Hence the dependency >> rules were changed. I will repost this patch with better description. > > My point is that the options are used by both the uart driver and > the platform code, e.g. for the purpose of PM debugging which can > be enabled even when the serial-samsung driver is turned off. I looked through the code and could find two references to these symbols in the platform-specific code: arch/arm/plat-samsung/init.c and arch/arm/mach-s3c64xx/irq-pm.c. The first one is being used to initialize the uart platform device in non-dt way while the second one saves and restores the uart irq masks for all channels across a suspend/resume cycle. Also, the save/restore will get bypassed in case CONFIG_SERIAL_SAMSUNG_UARTS is not defined. It does not look like either of these cases would cause any issue with the current patch, can you please help me understand the problem ? Regards, Abhilash > >> >> config SERIAL_SAMSUNG_UARTS_4 >> >> bool >> >> - depends on PLAT_SAMSUNG >> >> + depends on SERIAL_SAMSUNG >> >> default y if !(CPU_S3C2410 || CPU_S3C2412 || CPU_S3C2440 || CPU_S3C2442) >> >> help >> >> Internal node for the common case of 4 Samsung compatible UARTs >> >> >> >> config SERIAL_SAMSUNG_UARTS >> >> int >> >> - depends on PLAT_SAMSUNG >> >> + depends on SERIAL_SAMSUNG >> >> default 4 if SERIAL_SAMSUNG_UARTS_4 || CPU_S3C2416 >> >> default 3 >> >> help >> >> >> > >> > Have you checked that it still builds on all samsung platforms when >> > SERIAL_SAMSUNG is disabled? We have had build errors in this area >> > in the past. >> >> Yes, it builds for other Samsung platforms. > > Ok. > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2014-09-23 7:04 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-02 15:22 [PATCH] tty/serial: fix config dependencies for samsung serial Naveen Krishna Chatradhi 2014-09-02 15:22 ` Naveen Krishna Chatradhi 2014-09-02 15:46 ` Arnd Bergmann 2014-09-02 15:46 ` Arnd Bergmann 2014-09-03 8:21 ` Naveen Krishna Ch 2014-09-03 8:21 ` Naveen Krishna Ch 2014-09-03 8:21 ` Naveen Krishna Ch 2014-09-03 10:56 ` Arnd Bergmann 2014-09-03 10:56 ` Arnd Bergmann 2014-09-03 10:56 ` Arnd Bergmann 2014-09-23 7:04 ` Abhilash Kesavan [this message] 2014-09-23 7:04 ` Abhilash Kesavan 2014-09-23 7:04 ` Abhilash Kesavan 2014-09-23 8:07 ` Arnd Bergmann 2014-09-23 8:07 ` Arnd Bergmann 2014-09-23 8:07 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAM4voaky-zin8ikdkLBwpTKy13hz3iON8tmNsd55-kr8po8Qaw@mail.gmail.com \ --to=kesavan.abhilash@gmail.com \ --cc=arnd@arndb.de \ --cc=ch.naveen@samsung.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=naveenkrishna.ch@gmail.com \ --cc=pankaj.dubey@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.