lan78xx: WARNING: irq 79 handler enabled interrupts

From: Stefan Wahren <stefan.wahren@i2se.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
	Woojung Huh <woojung.huh@microchip.com>,
	Eric Anholt <eric@anholt.net>
Cc: Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: lan78xx: WARNING: irq 79 handler enabled interrupts
Date: Sat, 29 Dec 2018 01:02:57 +0100 (CET)	[thread overview]
Message-ID: <1082628525.187562.1546041777025@email.ionos.de> (raw)

Hi,
while booting my Raspberry Pi 3 B+ with Linux 4.20 (arm64/defconfig) i'm getting the following warning:

[   11.005738] irq 79 handler irq_default_primary_handler+0x0/0x8 enabled interrupts
[   11.024703] WARNING: CPU: 0 PID: 0 at kernel/irq/handle.c:153 __handle_irq_event_percpu+0x154/0x168
[   11.045293] Modules linked in: brcmfmac vc4 brcmutil cfg80211 cec drm_kms_helper hci_uart drm btbcm bluetooth microchip lan78xx ecdh_generic rfkill crct10dif_ce drm_panel_orientation_quirks bcm2835_rng bcm2835_thermal pwm_bcm2835 raspberrypi_hwmon i2c_bcm2835 vchiq(C) rng_core ip_tables x_tables ipv6
[   11.096874] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G         C        4.20.0 #11
[   11.116736] Hardware name: Raspberry Pi 3 Model B Plus Rev 1.3 (DT)
[   11.135405] pstate: 20000005 (nzCv daif -PAN -UAO)
[   11.152481] pc : __handle_irq_event_percpu+0x154/0x168
[   11.169840] lr : __handle_irq_event_percpu+0x154/0x168
[   11.187018] sp : ffff000008003ce0
[   11.202234] x29: ffff000008003ce0 x28: 0000000000000000 
[   11.219467] x27: 0000000000000001 x26: ffff000008ebed00 
[   11.236619] x25: ffff0000092fe40a x24: ffff800035d7e800 
[   11.253679] x23: ffff0000091b9000 x22: 000000000000004f 
[   11.270636] x21: ffff000008003d84 x20: 0000000000000002 
[   11.287449] x19: ffff800035572980 x18: ffffffffffffffff 
[   11.304177] x17: 0000000000000000 x16: 0000000000000000 
[   11.320827] x15: ffff0000091b96c8 x14: 0720072007200720 
[   11.337364] x13: 0720072007200720 x12: ffff000008bfe738 
[   11.353996] x11: ffff80002d593c70 x10: 0000000000000001 
[   11.370541] x9 : 00000000ffffffff x8 : 0000000000000001 
[   11.387035] x7 : 0000000000000008 x6 : ffff8000393800b8 
[   11.403471] x5 : ffff8000393800b8 x4 : 0000000000000001 
[   11.419849] x3 : 0000000000000000 x2 : ffff0000091c2600 
[   11.436199] x1 : 16ca74a025baa300 x0 : 0000000000000000 
[   11.452495] Call trace:
[   11.465764]  __handle_irq_event_percpu+0x154/0x168
[   11.481439]  handle_irq_event_percpu+0x34/0x88
[   11.496695]  handle_irq_event+0x48/0x78
[   11.511242]  handle_simple_irq+0x80/0xb8
[   11.525787]  generic_handle_irq+0x24/0x38
[   11.540339]  intr_complete+0xbc/0x100 [lan78xx]
[   11.555366]  __usb_hcd_giveback_urb+0x6c/0xd8
[   11.570137]  usb_giveback_urb_bh+0xa8/0x108
[   11.584699]  tasklet_action_common.isra.2+0x80/0x130
[   11.600056]  tasklet_hi_action+0x24/0x30
[   11.614255]  __do_softirq+0x108/0x234
[   11.628097]  irq_exit+0xcc/0xd8
[   11.641323]  __handle_domain_irq+0x60/0xb8
[   11.655516]  bcm2836_arm_irqchip_handle_irq+0x64/0xb8
[   11.670667]  el1_irq+0xb0/0x128
[   11.683770]  arch_cpu_idle+0x10/0x18
[   11.697275]  do_idle+0x1c4/0x280
[   11.710341]  cpu_startup_entry+0x20/0x28
[   11.724058]  rest_init+0xd4/0xe0
[   11.736962]  arch_call_rest_init+0xc/0x14
[   11.750625]  start_kernel+0x3ec/0x418

This seems to come from the lan78xx driver, because i don't get this warning on the RPI 3B (smsc95xx).

What's the approach to fix this issue? 
Is it just simply replace spin_lock_irq() with spin_lock_irqsave() at the right places?

Regards
Stefan