From: Javier Martinez Canillas <javierm@redhat.com> To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> Cc: Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, James Hilliard <james.hilliard1@gmail.com>, Randy Dunlap <rdunlap@infradead.org>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org> Subject: Re: [PATCH v3] drm/gma500: depend on framebuffer Date: Thu, 21 Apr 2022 15:22:55 +0200 [thread overview] Message-ID: <10c81e57-2f09-f4f8-dc2f-6bd05ef819d7@redhat.com> (raw) In-Reply-To: <CAMeQTsYYpw5+uLgmDrbB6PUBotRC4F+_rfK+sxT0CpPHoiOmmw@mail.gmail.com> On 4/21/22 14:54, Patrik Jakobsson wrote: > On Thu, Apr 21, 2022 at 2:47 PM Javier Martinez Canillas > <javierm@redhat.com> wrote: [snip] >>>>> diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig >>>>> index 0cff20265f97..a422fa84d53b 100644 >>>>> --- a/drivers/gpu/drm/gma500/Kconfig >>>>> +++ b/drivers/gpu/drm/gma500/Kconfig >>>>> @@ -2,11 +2,13 @@ >>>>> config DRM_GMA500 >>>>> tristate "Intel GMA500/600/3600/3650 KMS Framebuffer" >>>>> depends on DRM && PCI && X86 && MMU >>>>> + depends on FB >>>> >>>> Why do we need FB here? Framebuffer support should be hidden by DRM's >>>> fbdev helpers. >>> >>> It is not needed but gives him video output since it enables the drm >>> fbdev emulation. >>> >> >> I'm not sure to understand this. Shouldn't depend on DRM_FBDEV_EMULATION then? > > No, it shouldn't depend on any FBDEV stuff since it's not actually > required. It just happens to help in this case since weston + fbdev > backend works but not weston with drm backend (or whatever config > James have set). I see. Then the correct approach for them would be to just enable CONFIG_FB and DRM_FBDEV_EMULATION in their kernel config, rather than making this to depend on anything FB related as you said. > >> >>> I looked some more at the logs and it seems weston doesn't work on his >>> system without the fbdev backend. So the question is why weston isn't >>> working without fbdev? Perhaps this is just a Weston configuration >>> issue? >>> >> >> But is weston using the fbdev emulated by DRM or the one registered by >> efifb? I thought that the latter from what was mentioned in this thread. > > It's using drm fbdev emulation with gma500 so EFIFB has nothing to do > with this. I believe it was just simply incorrectly reported. If I'm > correct then "depends on FB" is what makes video output work for > James. > Got it. Thanks for the clarification. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javierm@redhat.com> To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> Cc: David Airlie <airlied@linux.ie>, Randy Dunlap <rdunlap@infradead.org>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, James Hilliard <james.hilliard1@gmail.com>, Thomas Zimmermann <tzimmermann@suse.de> Subject: Re: [PATCH v3] drm/gma500: depend on framebuffer Date: Thu, 21 Apr 2022 15:22:55 +0200 [thread overview] Message-ID: <10c81e57-2f09-f4f8-dc2f-6bd05ef819d7@redhat.com> (raw) In-Reply-To: <CAMeQTsYYpw5+uLgmDrbB6PUBotRC4F+_rfK+sxT0CpPHoiOmmw@mail.gmail.com> On 4/21/22 14:54, Patrik Jakobsson wrote: > On Thu, Apr 21, 2022 at 2:47 PM Javier Martinez Canillas > <javierm@redhat.com> wrote: [snip] >>>>> diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig >>>>> index 0cff20265f97..a422fa84d53b 100644 >>>>> --- a/drivers/gpu/drm/gma500/Kconfig >>>>> +++ b/drivers/gpu/drm/gma500/Kconfig >>>>> @@ -2,11 +2,13 @@ >>>>> config DRM_GMA500 >>>>> tristate "Intel GMA500/600/3600/3650 KMS Framebuffer" >>>>> depends on DRM && PCI && X86 && MMU >>>>> + depends on FB >>>> >>>> Why do we need FB here? Framebuffer support should be hidden by DRM's >>>> fbdev helpers. >>> >>> It is not needed but gives him video output since it enables the drm >>> fbdev emulation. >>> >> >> I'm not sure to understand this. Shouldn't depend on DRM_FBDEV_EMULATION then? > > No, it shouldn't depend on any FBDEV stuff since it's not actually > required. It just happens to help in this case since weston + fbdev > backend works but not weston with drm backend (or whatever config > James have set). I see. Then the correct approach for them would be to just enable CONFIG_FB and DRM_FBDEV_EMULATION in their kernel config, rather than making this to depend on anything FB related as you said. > >> >>> I looked some more at the logs and it seems weston doesn't work on his >>> system without the fbdev backend. So the question is why weston isn't >>> working without fbdev? Perhaps this is just a Weston configuration >>> issue? >>> >> >> But is weston using the fbdev emulated by DRM or the one registered by >> efifb? I thought that the latter from what was mentioned in this thread. > > It's using drm fbdev emulation with gma500 so EFIFB has nothing to do > with this. I believe it was just simply incorrectly reported. If I'm > correct then "depends on FB" is what makes video output work for > James. > Got it. Thanks for the clarification. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
next prev parent reply other threads:[~2022-04-21 13:23 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-09 4:23 [PATCH v3] drm/gma500: depend on framebuffer James Hilliard 2022-04-09 4:23 ` James Hilliard 2022-04-09 4:33 ` Randy Dunlap 2022-04-09 4:33 ` Randy Dunlap 2022-04-10 19:36 ` Patrik Jakobsson 2022-04-10 19:36 ` Patrik Jakobsson 2022-04-10 19:40 ` James Hilliard 2022-04-10 19:40 ` James Hilliard 2022-04-10 19:52 ` Patrik Jakobsson 2022-04-10 19:52 ` Patrik Jakobsson 2022-04-10 20:05 ` James Hilliard 2022-04-10 20:05 ` James Hilliard 2022-04-11 9:27 ` Patrik Jakobsson 2022-04-11 9:27 ` Patrik Jakobsson 2022-04-12 1:47 ` James Hilliard 2022-04-12 1:47 ` James Hilliard 2022-04-12 8:29 ` Patrik Jakobsson 2022-04-12 8:29 ` Patrik Jakobsson 2022-04-19 23:42 ` James Hilliard 2022-04-19 23:42 ` James Hilliard 2022-04-21 11:10 ` Patrik Jakobsson 2022-04-21 11:10 ` Patrik Jakobsson 2022-04-21 11:49 ` Thomas Zimmermann 2022-04-21 12:39 ` Patrik Jakobsson 2022-04-21 12:39 ` Patrik Jakobsson 2022-04-21 12:47 ` Javier Martinez Canillas 2022-04-21 12:54 ` Patrik Jakobsson 2022-04-21 12:54 ` Patrik Jakobsson 2022-04-21 13:20 ` Thomas Zimmermann 2022-04-21 13:20 ` Thomas Zimmermann 2022-04-21 17:48 ` James Hilliard 2022-04-21 17:48 ` James Hilliard 2022-04-21 19:10 ` Patrik Jakobsson 2022-04-21 19:10 ` Patrik Jakobsson 2022-04-21 13:22 ` Javier Martinez Canillas [this message] 2022-04-21 13:22 ` Javier Martinez Canillas 2022-04-21 17:39 ` James Hilliard 2022-04-21 17:39 ` James Hilliard 2022-04-21 18:22 ` Thomas Zimmermann 2022-04-21 18:23 ` Thomas Zimmermann 2022-04-21 18:24 ` James Hilliard 2022-04-21 18:24 ` James Hilliard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=10c81e57-2f09-f4f8-dc2f-6bd05ef819d7@redhat.com \ --to=javierm@redhat.com \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=james.hilliard1@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=patrik.r.jakobsson@gmail.com \ --cc=rdunlap@infradead.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.