From: James Hilliard <james.hilliard1@gmail.com> To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> Cc: dri-devel <dri-devel@lists.freedesktop.org>, Randy Dunlap <rdunlap@infradead.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3] drm/gma500: depend on framebuffer Date: Sun, 10 Apr 2022 13:40:40 -0600 [thread overview] Message-ID: <CADvTj4rBKzGFch8iVzHu1s+6=P0PcLEwoFi74xd_ormEX+2rMA@mail.gmail.com> (raw) In-Reply-To: <CAMeQTsanEow=zq=MuZLjMqpzybdS=5S0=JrkxuCdT7d5MxpEWQ@mail.gmail.com> On Sun, Apr 10, 2022 at 1:36 PM Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote: > > On Sat, Apr 9, 2022 at 6:23 AM James Hilliard <james.hilliard1@gmail.com> wrote: > > > > Select the efi framebuffer if efi is enabled. > > > > This appears to be needed for video output to function correctly. > > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > > Hi James, > EFI_FB is its own driver and not needed by gma500 to drive its > hardware. What makes you think it's required? I wasn't getting any HDMI video output without it enabled for some reason, I assume it is doing some sort of initialization needed by gma500 during startup. > > -Patrik > > > --- > > Changes v2 -> v3: > > - select EFI_FB instead of depending on it > > Changes v1 -> v2: > > - use depends instead of select > > --- > > drivers/gpu/drm/gma500/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig > > index 0cff20265f97..a422fa84d53b 100644 > > --- a/drivers/gpu/drm/gma500/Kconfig > > +++ b/drivers/gpu/drm/gma500/Kconfig > > @@ -2,11 +2,13 @@ > > config DRM_GMA500 > > tristate "Intel GMA500/600/3600/3650 KMS Framebuffer" > > depends on DRM && PCI && X86 && MMU > > + depends on FB > > select DRM_KMS_HELPER > > # GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915 > > select ACPI_VIDEO if ACPI > > select BACKLIGHT_CLASS_DEVICE if ACPI > > select INPUT if ACPI > > + select FB_EFI if EFI > > help > > Say yes for an experimental 2D KMS framebuffer driver for the > > Intel GMA500 (Poulsbo), Intel GMA600 (Moorestown/Oak Trail) and > > -- > > 2.25.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: James Hilliard <james.hilliard1@gmail.com> To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> Cc: David Airlie <airlied@linux.ie>, Randy Dunlap <rdunlap@infradead.org>, dri-devel <dri-devel@lists.freedesktop.org>, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3] drm/gma500: depend on framebuffer Date: Sun, 10 Apr 2022 13:40:40 -0600 [thread overview] Message-ID: <CADvTj4rBKzGFch8iVzHu1s+6=P0PcLEwoFi74xd_ormEX+2rMA@mail.gmail.com> (raw) In-Reply-To: <CAMeQTsanEow=zq=MuZLjMqpzybdS=5S0=JrkxuCdT7d5MxpEWQ@mail.gmail.com> On Sun, Apr 10, 2022 at 1:36 PM Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote: > > On Sat, Apr 9, 2022 at 6:23 AM James Hilliard <james.hilliard1@gmail.com> wrote: > > > > Select the efi framebuffer if efi is enabled. > > > > This appears to be needed for video output to function correctly. > > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > > Hi James, > EFI_FB is its own driver and not needed by gma500 to drive its > hardware. What makes you think it's required? I wasn't getting any HDMI video output without it enabled for some reason, I assume it is doing some sort of initialization needed by gma500 during startup. > > -Patrik > > > --- > > Changes v2 -> v3: > > - select EFI_FB instead of depending on it > > Changes v1 -> v2: > > - use depends instead of select > > --- > > drivers/gpu/drm/gma500/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig > > index 0cff20265f97..a422fa84d53b 100644 > > --- a/drivers/gpu/drm/gma500/Kconfig > > +++ b/drivers/gpu/drm/gma500/Kconfig > > @@ -2,11 +2,13 @@ > > config DRM_GMA500 > > tristate "Intel GMA500/600/3600/3650 KMS Framebuffer" > > depends on DRM && PCI && X86 && MMU > > + depends on FB > > select DRM_KMS_HELPER > > # GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915 > > select ACPI_VIDEO if ACPI > > select BACKLIGHT_CLASS_DEVICE if ACPI > > select INPUT if ACPI > > + select FB_EFI if EFI > > help > > Say yes for an experimental 2D KMS framebuffer driver for the > > Intel GMA500 (Poulsbo), Intel GMA600 (Moorestown/Oak Trail) and > > -- > > 2.25.1 > >
next prev parent reply other threads:[~2022-04-10 19:40 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-09 4:23 [PATCH v3] drm/gma500: depend on framebuffer James Hilliard 2022-04-09 4:23 ` James Hilliard 2022-04-09 4:33 ` Randy Dunlap 2022-04-09 4:33 ` Randy Dunlap 2022-04-10 19:36 ` Patrik Jakobsson 2022-04-10 19:36 ` Patrik Jakobsson 2022-04-10 19:40 ` James Hilliard [this message] 2022-04-10 19:40 ` James Hilliard 2022-04-10 19:52 ` Patrik Jakobsson 2022-04-10 19:52 ` Patrik Jakobsson 2022-04-10 20:05 ` James Hilliard 2022-04-10 20:05 ` James Hilliard 2022-04-11 9:27 ` Patrik Jakobsson 2022-04-11 9:27 ` Patrik Jakobsson 2022-04-12 1:47 ` James Hilliard 2022-04-12 1:47 ` James Hilliard 2022-04-12 8:29 ` Patrik Jakobsson 2022-04-12 8:29 ` Patrik Jakobsson 2022-04-19 23:42 ` James Hilliard 2022-04-19 23:42 ` James Hilliard 2022-04-21 11:10 ` Patrik Jakobsson 2022-04-21 11:10 ` Patrik Jakobsson 2022-04-21 11:49 ` Thomas Zimmermann 2022-04-21 12:39 ` Patrik Jakobsson 2022-04-21 12:39 ` Patrik Jakobsson 2022-04-21 12:47 ` Javier Martinez Canillas 2022-04-21 12:54 ` Patrik Jakobsson 2022-04-21 12:54 ` Patrik Jakobsson 2022-04-21 13:20 ` Thomas Zimmermann 2022-04-21 13:20 ` Thomas Zimmermann 2022-04-21 17:48 ` James Hilliard 2022-04-21 17:48 ` James Hilliard 2022-04-21 19:10 ` Patrik Jakobsson 2022-04-21 19:10 ` Patrik Jakobsson 2022-04-21 13:22 ` Javier Martinez Canillas 2022-04-21 13:22 ` Javier Martinez Canillas 2022-04-21 17:39 ` James Hilliard 2022-04-21 17:39 ` James Hilliard 2022-04-21 18:22 ` Thomas Zimmermann 2022-04-21 18:23 ` Thomas Zimmermann 2022-04-21 18:24 ` James Hilliard 2022-04-21 18:24 ` James Hilliard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CADvTj4rBKzGFch8iVzHu1s+6=P0PcLEwoFi74xd_ormEX+2rMA@mail.gmail.com' \ --to=james.hilliard1@gmail.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=patrik.r.jakobsson@gmail.com \ --cc=rdunlap@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.