* [PATCH] xen: remove setting of 'transp' parameter
@ 2022-05-21 19:59 ` Tom Rix
0 siblings, 0 replies; 8+ messages in thread
From: Tom Rix @ 2022-05-21 19:59 UTC (permalink / raw)
To: deller, tzimmermann, javierm, boris.ostrovsky, jgross
Cc: Tom Rix, linux-fbdev, linux-kernel, dri-devel
cppcheck reports
[drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.
The value parameter 'transp' is not used, so setting it can be removed.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/video/fbdev/xen-fbfront.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index 3bed357a9870..4d2694d904aa 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -223,7 +223,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green,
red = CNVT_TOHW(red, info->var.red.length);
green = CNVT_TOHW(green, info->var.green.length);
blue = CNVT_TOHW(blue, info->var.blue.length);
- transp = CNVT_TOHW(transp, info->var.transp.length);
#undef CNVT_TOHW
v = (red << info->var.red.offset) |
--
2.27.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] xen: remove setting of 'transp' parameter
2022-05-21 19:59 ` Tom Rix
@ 2022-05-22 10:30 ` Geert Uytterhoeven
-1 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2022-05-22 10:30 UTC (permalink / raw)
To: Tom Rix
Cc: Helge Deller, Thomas Zimmermann, Javier Martinez Canillas,
Boris Ostrovsky, Juergen Gross, Linux Fbdev development list,
DRI Development, Linux Kernel Mailing List
On Sun, May 22, 2022 at 3:22 AM Tom Rix <trix@redhat.com> wrote:
> cppcheck reports
> [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.
>
> The value parameter 'transp' is not used, so setting it can be removed.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xen: remove setting of 'transp' parameter
@ 2022-05-22 10:30 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2022-05-22 10:30 UTC (permalink / raw)
To: Tom Rix
Cc: Juergen Gross, Linux Fbdev development list, Helge Deller,
Javier Martinez Canillas, DRI Development,
Linux Kernel Mailing List, Thomas Zimmermann, Boris Ostrovsky
On Sun, May 22, 2022 at 3:22 AM Tom Rix <trix@redhat.com> wrote:
> cppcheck reports
> [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.
>
> The value parameter 'transp' is not used, so setting it can be removed.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen: remove setting of 'transp' parameter
2022-05-21 19:59 ` Tom Rix
@ 2022-05-23 7:02 ` Juergen Gross
-1 siblings, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2022-05-23 7:02 UTC (permalink / raw)
To: Tom Rix, deller, tzimmermann, javierm, boris.ostrovsky
Cc: linux-fbdev, linux-kernel, dri-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 364 bytes --]
On 21.05.22 21:59, Tom Rix wrote:
> cppcheck reports
> [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.
>
> The value parameter 'transp' is not used, so setting it can be removed.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen: remove setting of 'transp' parameter
@ 2022-05-23 7:02 ` Juergen Gross
0 siblings, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2022-05-23 7:02 UTC (permalink / raw)
To: Tom Rix, deller, tzimmermann, javierm, boris.ostrovsky
Cc: linux-fbdev, dri-devel, linux-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 364 bytes --]
On 21.05.22 21:59, Tom Rix wrote:
> cppcheck reports
> [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.
>
> The value parameter 'transp' is not used, so setting it can be removed.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen: remove setting of 'transp' parameter
2022-05-21 19:59 ` Tom Rix
@ 2022-05-25 12:17 ` Helge Deller
-1 siblings, 0 replies; 8+ messages in thread
From: Helge Deller @ 2022-05-25 12:17 UTC (permalink / raw)
To: Tom Rix, tzimmermann, javierm, boris.ostrovsky, jgross
Cc: linux-fbdev, dri-devel, linux-kernel
On 5/21/22 21:59, Tom Rix wrote:
> cppcheck reports
> [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.
>
> The value parameter 'transp' is not used, so setting it can be removed.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
applied to the fbdev tree.
Thanks!
Helge
> ---
> drivers/video/fbdev/xen-fbfront.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> index 3bed357a9870..4d2694d904aa 100644
> --- a/drivers/video/fbdev/xen-fbfront.c
> +++ b/drivers/video/fbdev/xen-fbfront.c
> @@ -223,7 +223,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green,
> red = CNVT_TOHW(red, info->var.red.length);
> green = CNVT_TOHW(green, info->var.green.length);
> blue = CNVT_TOHW(blue, info->var.blue.length);
> - transp = CNVT_TOHW(transp, info->var.transp.length);
> #undef CNVT_TOHW
>
> v = (red << info->var.red.offset) |
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen: remove setting of 'transp' parameter
@ 2022-05-25 12:17 ` Helge Deller
0 siblings, 0 replies; 8+ messages in thread
From: Helge Deller @ 2022-05-25 12:17 UTC (permalink / raw)
To: Tom Rix, tzimmermann, javierm, boris.ostrovsky, jgross
Cc: linux-fbdev, linux-kernel, dri-devel
On 5/21/22 21:59, Tom Rix wrote:
> cppcheck reports
> [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.
>
> The value parameter 'transp' is not used, so setting it can be removed.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
applied to the fbdev tree.
Thanks!
Helge
> ---
> drivers/video/fbdev/xen-fbfront.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> index 3bed357a9870..4d2694d904aa 100644
> --- a/drivers/video/fbdev/xen-fbfront.c
> +++ b/drivers/video/fbdev/xen-fbfront.c
> @@ -223,7 +223,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green,
> red = CNVT_TOHW(red, info->var.red.length);
> green = CNVT_TOHW(green, info->var.green.length);
> blue = CNVT_TOHW(blue, info->var.blue.length);
> - transp = CNVT_TOHW(transp, info->var.transp.length);
> #undef CNVT_TOHW
>
> v = (red << info->var.red.offset) |
^ permalink raw reply [flat|nested] 8+ messages in thread