All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: linux-acpi@vger.kernel.org
Cc: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>,
	Vladimir Lebedev <vladimir.p.lebedev@intel.com>,
	Len Brown <len.brown@intel.com>
Subject: [PATCH 29/41] ACPI: invoke acpi_sleep_init() earlier
Date: Tue, 13 Feb 2007 00:49:31 -0500	[thread overview]
Message-ID: <11713458191475-git-send-email-lenb@kernel.org> (raw)
Message-ID: <aafbcd165a2a02e6dff173f66772b3148229ace8.1171345631.git.len.brown@intel.com> (raw)
In-Reply-To: <11713458183917-git-send-email-lenb@kernel.org>
In-Reply-To: <268d175f131e33fe1aed4cd5080884ab5d0badb2.1171345630.git.len.brown@intel.com>

From: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>

late_initcall() is too late for acpi_sleep_init().
Call it directly from acpi_init code.

http://bugzilla.kernel.org/show_bug.cgi?id=7887

Signed-off-by: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
Signed-off-by: Vladimir Lebedev <vladimir.p.lebedev@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
 drivers/acpi/bus.c          |   13 ++++++++-----
 drivers/acpi/sleep/main.c   |    3 +--
 include/acpi/acpi_drivers.h |   10 ++++++++++
 3 files changed, 19 insertions(+), 7 deletions(-)

diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index c26468d..41cebe5 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -147,7 +147,7 @@ int acpi_bus_get_power(acpi_handle handle, int *state)
 			*state = ACPI_STATE_D0;
 	} else {
 		/*
-		 * Get the device's power state either directly (via _PSC) or 
+		 * Get the device's power state either directly (via _PSC) or
 		 * indirectly (via power resources).
 		 */
 		if (device->power.flags.explicit_get) {
@@ -462,7 +462,7 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data)
 				  "Received BUS CHECK notification for device [%s]\n",
 				  device->pnp.bus_id));
 		result = acpi_bus_check_scope(device);
-		/* 
+		/*
 		 * TBD: We'll need to outsource certain events to non-ACPI
 		 *      drivers via the device manager (device.c).
 		 */
@@ -473,7 +473,7 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data)
 				  "Received DEVICE CHECK notification for device [%s]\n",
 				  device->pnp.bus_id));
 		result = acpi_bus_check_device(device, NULL);
-		/* 
+		/*
 		 * TBD: We'll need to outsource certain events to non-ACPI
 		 *      drivers via the device manager (device.c).
 		 */
@@ -543,7 +543,7 @@ static int __init acpi_bus_init_irq(void)
 	char *message = NULL;
 
 
-	/* 
+	/*
 	 * Let the system know what interrupt model we are using by
 	 * evaluating the \_PIC object, if exists.
 	 */
@@ -684,7 +684,7 @@ static int __init acpi_bus_init(void)
 	 * the EC device is found in the namespace (i.e. before acpi_initialize_objects()
 	 * is called).
 	 *
-	 * This is accomplished by looking for the ECDT table, and getting 
+	 * This is accomplished by looking for the ECDT table, and getting
 	 * the EC parameters out of that.
 	 */
 	status = acpi_ec_ecdt_probe();
@@ -699,6 +699,9 @@ static int __init acpi_bus_init(void)
 
 	printk(KERN_INFO PREFIX "Interpreter enabled\n");
 
+	/* Initialize sleep structures */
+	acpi_sleep_init();
+
 	/*
 	 * Get the system interrupt model and evaluate \_PIC.
 	 */
diff --git a/drivers/acpi/sleep/main.c b/drivers/acpi/sleep/main.c
index 62ce87d..37a0930 100644
--- a/drivers/acpi/sleep/main.c
+++ b/drivers/acpi/sleep/main.c
@@ -200,7 +200,7 @@ static struct dmi_system_id __initdata acpisleep_dmi_table[] = {
 	{},
 };
 
-static int __init acpi_sleep_init(void)
+int __init acpi_sleep_init(void)
 {
 	int i = 0;
 
@@ -229,4 +229,3 @@ static int __init acpi_sleep_init(void)
 	return 0;
 }
 
-late_initcall(acpi_sleep_init);
diff --git a/include/acpi/acpi_drivers.h b/include/acpi/acpi_drivers.h
index 4dc8a50..ce0e62f 100644
--- a/include/acpi/acpi_drivers.h
+++ b/include/acpi/acpi_drivers.h
@@ -128,4 +128,14 @@ extern void unregister_hotplug_dock_device(acpi_handle handle);
 #define register_hotplug_dock_device(h1, h2, c)	(-ENODEV)
 #define unregister_hotplug_dock_device(h)       do { } while(0)
 #endif
+
+/*--------------------------------------------------------------------------
+                                  Suspend/Resume
+  -------------------------------------------------------------------------- */
+#ifdef CONFIG_ACPI_SLEEP
+extern int acpi_sleep_init(void);
+#else
+#define acpi_sleep_init() do {} while (0)
+#endif
+
 #endif /*__ACPI_DRIVERS_H__*/
-- 
1.5.0.rc4.345.gb4d2

  parent reply	other threads:[~2007-02-13  5:50 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-13  5:49 ACPI related patches for 2.6.21 -- part II Len Brown
2007-02-13  5:49 ` [PATCH 01/41] sony_acpi: SNC device support for Sony Vaios Len Brown
2007-02-13  5:49   ` Len Brown
2007-02-13  5:49   ` [PATCH 02/41] sony_acpi: Avoid dimness on resume Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 03/41] sony_acpi: Fix sony_acpi_resume call Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 04/41] sony_acpi: Add backlight support to the sony_acpi Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 05/41] sony_acpi: Add backlight support to the sony_acpi v2 Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 06/41] sony_acpi: Video sysfs support take 2 Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 07/41] sony_acpi: Add acpi_bus_generate event Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 08/41] sony_acpi: Allow easier debugging for the unknown SNC methods Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 09/41] sony_acpi: Add lanpower and audiopower controls Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 10/41] sony_acpi: Allow multiple sony_acpi_values for the same .name Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 11/41] sony_acpi: Fix sony_acpi backlight registration and unregistration Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 12/41] sony-laptop: create from sony_acpi Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 13/41] sony-laptop: Remove /proc/acpi/sony interface and implement platform_device Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 14/41] sony-laptop: Small update to the Kconfig help to make people believe this driver is useful Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 15/41] sony-laptop: Group functions and structures to better draw subsytems usage Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 16/41] sony-laptop: Lindent Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 17/41] ACPI: bay: remove ACPI driver struct Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 18/41] ACPI: asus_acpi: Add support for Asus Z81SP Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49       ` [PATCH 19/41] ACPI: updates rtc-cmos device platform_data Len Brown
2007-02-13  5:49         ` Len Brown
2007-02-13  5:49   ` [PATCH 20/41] ACPI: bay: fix build warning Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 22/41] sony-laptop: Update docs Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 23/41] sony-laptop: add to MAINTAINERS Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 24/41] ACPI: bay: fix wrong order of kzalloc arguments Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 25/41] ACPI: ibm-acpi: cleanup init and exit paths Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 26/41] ACPI: video: Fix null pointer in appledisplay driver Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  6:53       ` Len Brown
2007-02-13  5:49   ` [PATCH 27/41] ACPI: hotkey: remove driver, per feature-removal-schedule.txt Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 28/41] ACPI: Disable GPEs in preparation for sleep Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` Len Brown [this message]
2007-02-13  5:49     ` [PATCH 29/41] ACPI: invoke acpi_sleep_init() earlier Len Brown
2007-02-13  5:49   ` [PATCH 30/41] ACPI: battery: check for battery present on /proc/battery access Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 31/41] ACPI: sbs: fix present rate Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 32/41] ACPI: add video driver MAINTAINER Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 33/41] ACPI: acpi_table_parse() now returns success/fail, not count Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 34/41] ACPI: acpi_madt_entry_handler() is not MADT specific Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 35/41] ACPI: acpi_table_parse_madt_family() " Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 36/41] ACPI: IA64: fix calculation of apic_id Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 37/41] ACPI: clean up ACPI_MODULE_NAME() use Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49       ` [PATCH 38/41] ACPI: fix acpi_driver.name usage Len Brown
2007-02-13  5:49         ` Len Brown
2007-02-13  5:49   ` [PATCH 39/41] ACPI: delete extra #defines in /drivers/acpi/ drivers Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 40/41] sony-laptop: allow complex per-value input/output validation Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 41/41] ACPI: cleanup: make disable_acpi() valid w/o CONFIG_ACPI Len Brown
2007-02-13  5:49     ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11713458191475-git-send-email-lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=alexey.y.starikovskiy@linux.intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=vladimir.p.lebedev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.