All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: linux-acpi@vger.kernel.org
Cc: Len Brown <len.brown@intel.com>
Subject: [PATCH 35/41] ACPI: acpi_table_parse_madt_family() is not MADT specific
Date: Tue, 13 Feb 2007 00:49:37 -0500	[thread overview]
Message-ID: <11713458251648-git-send-email-lenb@kernel.org> (raw)
Message-ID: <efc1b941936bb4b211bdba45616196efbd186fa7.1171345631.git.len.brown@intel.com> (raw)
In-Reply-To: <11713458242872-git-send-email-lenb@kernel.org>
In-Reply-To: <268d175f131e33fe1aed4cd5080884ab5d0badb2.1171345630.git.len.brown@intel.com>

From: Len Brown <len.brown@intel.com>

acpi_table_parse_madt_family() is also used to parse SRAT entries.
So re-name it to acpi_table_parse_entries(), and re-name the
madt-specific variables within it accordingly.

cosmetic only.

Signed-off-by: Len Brown <len.brown@intel.com>
---
 drivers/acpi/numa.c   |    8 +-------
 drivers/acpi/tables.c |   24 ++++++++++++------------
 include/linux/acpi.h  |    2 ++
 3 files changed, 15 insertions(+), 19 deletions(-)

diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
index fd21e20..a651139 100644
--- a/drivers/acpi/numa.c
+++ b/drivers/acpi/numa.c
@@ -45,12 +45,6 @@ int __cpuinitdata pxm_to_node_map[MAX_PXM_DOMAINS]
 int __cpuinitdata node_to_pxm_map[MAX_NUMNODES]
 				= { [0 ... MAX_NUMNODES - 1] = PXM_INVAL };
 
-extern int __init acpi_table_parse_madt_family(char *id,
-					       unsigned long madt_size,
-					       int entry_id,
-					       acpi_table_entry_handler handler,
-					       unsigned int max_entries);
-
 int __cpuinit pxm_to_node(int pxm)
 {
 	if (pxm < 0)
@@ -210,7 +204,7 @@ int __init
 acpi_table_parse_srat(enum acpi_srat_type id,
 		      acpi_table_entry_handler handler, unsigned int max_entries)
 {
-	return acpi_table_parse_madt_family(ACPI_SIG_SRAT,
+	return acpi_table_parse_entries(ACPI_SIG_SRAT,
 					    sizeof(struct acpi_table_srat), id,
 					    handler, max_entries);
 }
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index f211fa3..4ed6400 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -170,40 +170,40 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header * header)
 
 
 int __init
-acpi_table_parse_madt_family(char *id,
-			     unsigned long madt_size,
+acpi_table_parse_entries(char *id,
+			     unsigned long table_size,
 			     int entry_id,
 			     acpi_table_entry_handler handler,
 			     unsigned int max_entries)
 {
-	struct acpi_table_header *madt = NULL;
+	struct acpi_table_header *table_header = NULL;
 	struct acpi_subtable_header *entry;
 	unsigned int count = 0;
-	unsigned long madt_end;
+	unsigned long table_end;
 
 	if (!handler)
 		return -EINVAL;
 
-	/* Locate the MADT (if exists). There should only be one. */
-	acpi_get_table(id, 0, &madt);
+	/* Locate the table (if exists). There should only be one. */
+	acpi_get_table(id, 0, &table_header);
 
-	if (!madt) {
+	if (!table_header) {
 		printk(KERN_WARNING PREFIX "%4.4s not present\n", id);
 		return -ENODEV;
 	}
 
-	madt_end = (unsigned long)madt + madt->length;
+	table_end = (unsigned long)table_header + table_header->length;
 
 	/* Parse all entries looking for a match. */
 
 	entry = (struct acpi_subtable_header *)
-	    ((unsigned long)madt + madt_size);
+	    ((unsigned long)table_header + table_size);
 
 	while (((unsigned long)entry) + sizeof(struct acpi_subtable_header) <
-	       madt_end) {
+	       table_end) {
 		if (entry->type == entry_id
 		    && (!max_entries || count++ < max_entries))
-			if (handler(entry, madt_end))
+			if (handler(entry, table_end))
 				return -EINVAL;
 
 		entry = (struct acpi_subtable_header *)
@@ -221,7 +221,7 @@ int __init
 acpi_table_parse_madt(enum acpi_madt_type id,
 		      acpi_table_entry_handler handler, unsigned int max_entries)
 {
-	return acpi_table_parse_madt_family(ACPI_SIG_MADT,
+	return acpi_table_parse_entries(ACPI_SIG_MADT,
 					    sizeof(struct acpi_table_madt), id,
 					    handler, max_entries);
 }
diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index 15a23b6..8bcfaa4 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h
@@ -85,6 +85,8 @@ int acpi_numa_init (void);
 
 int acpi_table_init (void);
 int acpi_table_parse (char *id, acpi_table_handler handler);
+int __init acpi_table_parse_entries(char *id, unsigned long table_size,
+	int entry_id, acpi_table_entry_handler handler, unsigned int max_entries);
 int acpi_table_parse_madt (enum acpi_madt_type id, acpi_table_entry_handler handler, unsigned int max_entries);
 int acpi_table_parse_srat (enum acpi_srat_type id, acpi_table_entry_handler handler, unsigned int max_entries);
 int acpi_parse_mcfg (struct acpi_table_header *header);
-- 
1.5.0.rc4.345.gb4d2

  parent reply	other threads:[~2007-02-13  5:50 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-13  5:49 ACPI related patches for 2.6.21 -- part II Len Brown
2007-02-13  5:49 ` [PATCH 01/41] sony_acpi: SNC device support for Sony Vaios Len Brown
2007-02-13  5:49   ` Len Brown
2007-02-13  5:49   ` [PATCH 02/41] sony_acpi: Avoid dimness on resume Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 03/41] sony_acpi: Fix sony_acpi_resume call Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 04/41] sony_acpi: Add backlight support to the sony_acpi Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 05/41] sony_acpi: Add backlight support to the sony_acpi v2 Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 06/41] sony_acpi: Video sysfs support take 2 Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 07/41] sony_acpi: Add acpi_bus_generate event Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 08/41] sony_acpi: Allow easier debugging for the unknown SNC methods Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 09/41] sony_acpi: Add lanpower and audiopower controls Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 10/41] sony_acpi: Allow multiple sony_acpi_values for the same .name Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 11/41] sony_acpi: Fix sony_acpi backlight registration and unregistration Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 12/41] sony-laptop: create from sony_acpi Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 13/41] sony-laptop: Remove /proc/acpi/sony interface and implement platform_device Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 14/41] sony-laptop: Small update to the Kconfig help to make people believe this driver is useful Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 15/41] sony-laptop: Group functions and structures to better draw subsytems usage Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 16/41] sony-laptop: Lindent Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 17/41] ACPI: bay: remove ACPI driver struct Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 18/41] ACPI: asus_acpi: Add support for Asus Z81SP Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49       ` [PATCH 19/41] ACPI: updates rtc-cmos device platform_data Len Brown
2007-02-13  5:49         ` Len Brown
2007-02-13  5:49   ` [PATCH 20/41] ACPI: bay: fix build warning Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 22/41] sony-laptop: Update docs Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 23/41] sony-laptop: add to MAINTAINERS Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 24/41] ACPI: bay: fix wrong order of kzalloc arguments Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 25/41] ACPI: ibm-acpi: cleanup init and exit paths Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 26/41] ACPI: video: Fix null pointer in appledisplay driver Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  6:53       ` Len Brown
2007-02-13  5:49   ` [PATCH 27/41] ACPI: hotkey: remove driver, per feature-removal-schedule.txt Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 28/41] ACPI: Disable GPEs in preparation for sleep Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 29/41] ACPI: invoke acpi_sleep_init() earlier Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 30/41] ACPI: battery: check for battery present on /proc/battery access Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 31/41] ACPI: sbs: fix present rate Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 32/41] ACPI: add video driver MAINTAINER Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 33/41] ACPI: acpi_table_parse() now returns success/fail, not count Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 34/41] ACPI: acpi_madt_entry_handler() is not MADT specific Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` Len Brown [this message]
2007-02-13  5:49     ` [PATCH 35/41] ACPI: acpi_table_parse_madt_family() " Len Brown
2007-02-13  5:49   ` [PATCH 36/41] ACPI: IA64: fix calculation of apic_id Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 37/41] ACPI: clean up ACPI_MODULE_NAME() use Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49       ` [PATCH 38/41] ACPI: fix acpi_driver.name usage Len Brown
2007-02-13  5:49         ` Len Brown
2007-02-13  5:49   ` [PATCH 39/41] ACPI: delete extra #defines in /drivers/acpi/ drivers Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 40/41] sony-laptop: allow complex per-value input/output validation Len Brown
2007-02-13  5:49     ` Len Brown
2007-02-13  5:49   ` [PATCH 41/41] ACPI: cleanup: make disable_acpi() valid w/o CONFIG_ACPI Len Brown
2007-02-13  5:49     ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11713458251648-git-send-email-lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.