All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Tafalla <atafalla@dnyon.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	ALSA Development Mailing List <alsa-devel@alsa-project.org>,
	devicetree <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] ASoC: max98927: Handle reset gpio when probing i2c
Date: Fri, 03 Sep 2021 17:52:29 +0200	[thread overview]
Message-ID: <11848098.O9o76ZdvQC@alexpc> (raw)
In-Reply-To: <CAHp75VeD8sbxcu==BF97yY4ZGtLbNAQSiTxq2cDvBSdCpXxsyw@mail.gmail.com>

On viernes, 3 de septiembre de 2021 10:18:14 (CEST) Andy Shevchenko wrote:
> On Fri, Sep 3, 2021 at 4:51 AM Alejandro <atafalla@dnyon.com> wrote:
> > From: Alejandro Tafalla <atafalla@dnyon.com>
> > 
> > Drive the reset gpio if defined in the DTS node.
> 
> ...
> 
> > +       reset_gpio
> > +               = devm_gpiod_get_optional(&i2c->dev, "reset",
> > GPIOD_OUT_LOW); +       if (IS_ERR(reset_gpio)) {
> > +               ret = PTR_ERR(reset_gpio);
> > +               return dev_err_probe(&i2c->dev, ret, "failed to request
> > GPIO reset pin");
> Not sure why my comments have been ignored here.
> 
> > +       }
> 
> --
> With Best Regards,
> Andy Shevchenko
Sorry, I misread your suggestion and didn't notice PTR_ERR was also in the 
same line.




WARNING: multiple messages have this Message-ID (diff)
From: Alejandro Tafalla <atafalla@dnyon.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	ALSA Development Mailing List <alsa-devel@alsa-project.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v3 1/2] ASoC: max98927: Handle reset gpio when probing i2c
Date: Fri, 03 Sep 2021 17:52:29 +0200	[thread overview]
Message-ID: <11848098.O9o76ZdvQC@alexpc> (raw)
In-Reply-To: <CAHp75VeD8sbxcu==BF97yY4ZGtLbNAQSiTxq2cDvBSdCpXxsyw@mail.gmail.com>

On viernes, 3 de septiembre de 2021 10:18:14 (CEST) Andy Shevchenko wrote:
> On Fri, Sep 3, 2021 at 4:51 AM Alejandro <atafalla@dnyon.com> wrote:
> > From: Alejandro Tafalla <atafalla@dnyon.com>
> > 
> > Drive the reset gpio if defined in the DTS node.
> 
> ...
> 
> > +       reset_gpio
> > +               = devm_gpiod_get_optional(&i2c->dev, "reset",
> > GPIOD_OUT_LOW); +       if (IS_ERR(reset_gpio)) {
> > +               ret = PTR_ERR(reset_gpio);
> > +               return dev_err_probe(&i2c->dev, ret, "failed to request
> > GPIO reset pin");
> Not sure why my comments have been ignored here.
> 
> > +       }
> 
> --
> With Best Regards,
> Andy Shevchenko
Sorry, I misread your suggestion and didn't notice PTR_ERR was also in the 
same line.




  reply	other threads:[~2021-09-03 15:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-03  1:49 [PATCH v3 0/2] Add reset-gpios handling for max98927 Alejandro
2021-09-03  1:49 ` Alejandro
2021-09-03  1:49 ` [PATCH v3 1/2] ASoC: max98927: Handle reset gpio when probing i2c Alejandro
2021-09-03  1:49   ` Alejandro
2021-09-03  8:18   ` Andy Shevchenko
2021-09-03  8:18     ` Andy Shevchenko
2021-09-03 15:52     ` Alejandro Tafalla [this message]
2021-09-03 15:52       ` Alejandro Tafalla
2021-09-03  9:20   ` Péter Ujfalusi
2021-09-03  9:20     ` Péter Ujfalusi
2021-09-03 23:22     ` Alejandro Tafalla
2021-09-03 23:22       ` Alejandro Tafalla
2021-09-03  1:49 ` [PATCH v3 2/2] dt-bindings: sound: max98927: Add reset-gpios optional property Alejandro
2021-09-03  1:49   ` Alejandro
2021-09-03 17:41   ` Rob Herring
2021-09-03 17:41     ` Rob Herring
2021-09-03 17:58     ` Alejandro Tafalla
2021-09-03 17:58       ` Alejandro Tafalla
2021-09-03  8:16 ` [PATCH v3 0/2] Add reset-gpios handling for max98927 Andy Shevchenko
2021-09-03  8:16   ` Andy Shevchenko
2021-09-03 16:02   ` Alejandro Tafalla
2021-09-03 16:02     ` Alejandro Tafalla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11848098.O9o76ZdvQC@alexpc \
    --to=atafalla@dnyon.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.