* Re: [Qemu-devel] qemu/target-ppc op_helper.c
@ 2007-10-29 21:12 Aurelien Jarno
2007-10-29 21:21 ` J. Mayer
0 siblings, 1 reply; 13+ messages in thread
From: Aurelien Jarno @ 2007-10-29 21:12 UTC (permalink / raw)
To: qemu-devel; +Cc: Jocelyn Mayer
> CVSROOT: /sources/qemu
> Module name: qemu
> Changes by: Jocelyn Mayer <j_mayer> 07/10/27 17:59:46
>
> Modified files:
> target-ppc : op_helper.c
>
> Log message:
> PowerPC float bugfix: 64 bits float mantissa is 52 bits long.
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.55&r2=1.56
I know that it looks strange, but this commit breaks perl. The function
mkdir(dir, mode) sometimes does not set the mode correctly. This can be
easily reproduce on Debian by using "dpkg-source -x file.dsc", which
fails due to wrong permission.
I am using qemu-system-ppc -M prep -cpu G3
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] qemu/target-ppc op_helper.c
2007-10-29 21:12 [Qemu-devel] qemu/target-ppc op_helper.c Aurelien Jarno
@ 2007-10-29 21:21 ` J. Mayer
2007-10-29 21:33 ` Aurelien Jarno
0 siblings, 1 reply; 13+ messages in thread
From: J. Mayer @ 2007-10-29 21:21 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: qemu-devel
On Mon, 2007-10-29 at 22:12 +0100, Aurelien Jarno wrote:
> > CVSROOT: /sources/qemu
> > Module name: qemu
> > Changes by: Jocelyn Mayer <j_mayer> 07/10/27 17:59:46
> >
> > Modified files:
> > target-ppc : op_helper.c
> >
> > Log message:
> > PowerPC float bugfix: 64 bits float mantissa is 52 bits long.
> >
> > CVSWeb URLs:
> > http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.55&r2=1.56
>
>
> I know that it looks strange, but this commit breaks perl. The function
> mkdir(dir, mode) sometimes does not set the mode correctly. This can be
> easily reproduce on Debian by using "dpkg-source -x file.dsc", which
> fails due to wrong permission.
>
> I am using qemu-system-ppc -M prep -cpu G3
Thanks for the report !
Could you please try replacing the 0x3FF mask with 0x7FF ? As the
exponent is supposed to be 11 bits, my patch is obviously still buggy...
I noticed there was a bug somewhere, but was not convinced it was in the
FPU emulation... Now ...
--
J. Mayer <l_indien@magic.fr>
Never organized
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] qemu/target-ppc op_helper.c
2007-10-29 21:21 ` J. Mayer
@ 2007-10-29 21:33 ` Aurelien Jarno
2007-10-29 21:52 ` J. Mayer
0 siblings, 1 reply; 13+ messages in thread
From: Aurelien Jarno @ 2007-10-29 21:33 UTC (permalink / raw)
To: J. Mayer; +Cc: qemu-devel
On Mon, Oct 29, 2007 at 10:21:26PM +0100, J. Mayer wrote:
>
> On Mon, 2007-10-29 at 22:12 +0100, Aurelien Jarno wrote:
> > > CVSROOT: /sources/qemu
> > > Module name: qemu
> > > Changes by: Jocelyn Mayer <j_mayer> 07/10/27 17:59:46
> > >
> > > Modified files:
> > > target-ppc : op_helper.c
> > >
> > > Log message:
> > > PowerPC float bugfix: 64 bits float mantissa is 52 bits long.
> > >
> > > CVSWeb URLs:
> > > http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.55&r2=1.56
> >
> >
> > I know that it looks strange, but this commit breaks perl. The function
> > mkdir(dir, mode) sometimes does not set the mode correctly. This can be
> > easily reproduce on Debian by using "dpkg-source -x file.dsc", which
> > fails due to wrong permission.
> >
> > I am using qemu-system-ppc -M prep -cpu G3
>
> Thanks for the report !
> Could you please try replacing the 0x3FF mask with 0x7FF ? As the
> exponent is supposed to be 11 bits, my patch is obviously still buggy...
> I noticed there was a bug somewhere, but was not convinced it was in the
> FPU emulation... Now ...
>
Yep that fixes the problem. Thanks a lot!
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] qemu/target-ppc op_helper.c
2007-10-29 21:33 ` Aurelien Jarno
@ 2007-10-29 21:52 ` J. Mayer
0 siblings, 0 replies; 13+ messages in thread
From: J. Mayer @ 2007-10-29 21:52 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: qemu-devel
On Mon, 2007-10-29 at 22:33 +0100, Aurelien Jarno wrote:
> On Mon, Oct 29, 2007 at 10:21:26PM +0100, J. Mayer wrote:
> >
> > On Mon, 2007-10-29 at 22:12 +0100, Aurelien Jarno wrote:
> > > > CVSROOT: /sources/qemu
> > > > Module name: qemu
> > > > Changes by: Jocelyn Mayer <j_mayer> 07/10/27 17:59:46
> > > >
> > > > Modified files:
> > > > target-ppc : op_helper.c
> > > >
> > > > Log message:
> > > > PowerPC float bugfix: 64 bits float mantissa is 52 bits long.
> > > >
> > > > CVSWeb URLs:
> > > > http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.55&r2=1.56
> > >
> > >
> > > I know that it looks strange, but this commit breaks perl. The function
> > > mkdir(dir, mode) sometimes does not set the mode correctly. This can be
> > > easily reproduce on Debian by using "dpkg-source -x file.dsc", which
> > > fails due to wrong permission.
> > >
> > > I am using qemu-system-ppc -M prep -cpu G3
> >
> > Thanks for the report !
> > Could you please try replacing the 0x3FF mask with 0x7FF ? As the
> > exponent is supposed to be 11 bits, my patch is obviously still buggy...
> > I noticed there was a bug somewhere, but was not convinced it was in the
> > FPU emulation... Now ...
> >
>
> Yep that fixes the problem. Thanks a lot!
Great ! Thanks for your help !
I'll commit it in a minute !
>
--
J. Mayer <l_indien@magic.fr>
Never organized
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] qemu/target-ppc op_helper.c
@ 2008-03-13 19:20 Aurelien Jarno
0 siblings, 0 replies; 13+ messages in thread
From: Aurelien Jarno @ 2008-03-13 19:20 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /sources/qemu
Module name: qemu
Changes by: Aurelien Jarno <aurel32> 08/03/13 19:20:00
Modified files:
target-ppc : op_helper.c
Log message:
Math functions helper for CONFIG_SOFTFLOAT=yes
The patch below adds isfinite() and isnormal() functions which can
work with float64 type, used when CONFIG_SOFTFLOAT=yes.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.75&r2=1.76
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] qemu/target-ppc op_helper.c
@ 2008-03-10 0:09 Aurelien Jarno
0 siblings, 0 replies; 13+ messages in thread
From: Aurelien Jarno @ 2008-03-10 0:09 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /sources/qemu
Module name: qemu
Changes by: Aurelien Jarno <aurel32> 08/03/10 00:09:28
Modified files:
target-ppc : op_helper.c
Log message:
mtfsf: fix FPSCR_VX and FPSCR_FEX computation
The patch below fixes the computation of FPSCR_VX and FPSCR_FEX when
using the mtfsf instruction. As stated in the PowerPC manual the mtfsf
instruction can't alter those bit, and thus it should always be
computed.
Acked by Jocelyn Mayer.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.73&r2=1.74
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] qemu/target-ppc op_helper.c
@ 2007-10-29 21:54 Jocelyn Mayer
0 siblings, 0 replies; 13+ messages in thread
From: Jocelyn Mayer @ 2007-10-29 21:54 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /sources/qemu
Module name: qemu
Changes by: Jocelyn Mayer <j_mayer> 07/10/29 21:54:35
Modified files:
target-ppc : op_helper.c
Log message:
Fix two PowerPC FPU emulation bugs (thanks to Aurelien Jarno)
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.60&r2=1.61
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] qemu/target-ppc op_helper.c
@ 2007-10-27 23:34 Jocelyn Mayer
0 siblings, 0 replies; 13+ messages in thread
From: Jocelyn Mayer @ 2007-10-27 23:34 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /sources/qemu
Module name: qemu
Changes by: Jocelyn Mayer <j_mayer> 07/10/27 23:34:30
Modified files:
target-ppc : op_helper.c
Log message:
PowerPC floating-point helper typo.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.56&r2=1.57
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] qemu/target-ppc op_helper.c
@ 2007-10-27 17:59 Jocelyn Mayer
0 siblings, 0 replies; 13+ messages in thread
From: Jocelyn Mayer @ 2007-10-27 17:59 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /sources/qemu
Module name: qemu
Changes by: Jocelyn Mayer <j_mayer> 07/10/27 17:59:46
Modified files:
target-ppc : op_helper.c
Log message:
PowerPC float bugfix: 64 bits float mantissa is 52 bits long.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.55&r2=1.56
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] qemu/target-ppc op_helper.c
@ 2007-10-25 23:36 Jocelyn Mayer
0 siblings, 0 replies; 13+ messages in thread
From: Jocelyn Mayer @ 2007-10-25 23:36 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /sources/qemu
Module name: qemu
Changes by: Jocelyn Mayer <j_mayer> 07/10/25 23:36:08
Modified files:
target-ppc : op_helper.c
Log message:
Fix PowerPC 64x64 bits multiplication overflow check.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.53&r2=1.54
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] qemu/target-ppc op_helper.c
@ 2007-04-24 7:36 Jocelyn Mayer
0 siblings, 0 replies; 13+ messages in thread
From: Jocelyn Mayer @ 2007-04-24 7:36 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /sources/qemu
Module name: qemu
Changes by: Jocelyn Mayer <j_mayer> 07/04/24 07:36:03
Modified files:
target-ppc : op_helper.c
Log message:
Debug traces fixes.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.31&r2=1.32
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] qemu/target-ppc op_helper.c
@ 2006-04-23 18:17 Fabrice Bellard
0 siblings, 0 replies; 13+ messages in thread
From: Fabrice Bellard @ 2006-04-23 18:17 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /sources/qemu
Module name: qemu
Branch:
Changes by: Fabrice Bellard <bellard@savannah.gnu.org> 06/04/23 18:17:56
Modified files:
target-ppc : op_helper.c
Log message:
removed unnecessary header
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/target-ppc/op_helper.c.diff?tr1=1.16&tr2=1.17&r1=text&r2=text
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] qemu/target-ppc op_helper.c
@ 2005-06-04 22:19 Fabrice Bellard
0 siblings, 0 replies; 13+ messages in thread
From: Fabrice Bellard @ 2005-06-04 22:19 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /cvsroot/qemu
Module name: qemu
Branch:
Changes by: Fabrice Bellard <bellard@savannah.gnu.org> 05/06/04 22:19:19
Modified files:
target-ppc : op_helper.c
Log message:
xec_bc mask fix
CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/target-ppc/op_helper.c.diff?tr1=1.12&tr2=1.13&r1=text&r2=text
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2008-03-13 19:20 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-29 21:12 [Qemu-devel] qemu/target-ppc op_helper.c Aurelien Jarno
2007-10-29 21:21 ` J. Mayer
2007-10-29 21:33 ` Aurelien Jarno
2007-10-29 21:52 ` J. Mayer
-- strict thread matches above, loose matches on Subject: below --
2008-03-13 19:20 Aurelien Jarno
2008-03-10 0:09 Aurelien Jarno
2007-10-29 21:54 Jocelyn Mayer
2007-10-27 23:34 Jocelyn Mayer
2007-10-27 17:59 Jocelyn Mayer
2007-10-25 23:36 Jocelyn Mayer
2007-04-24 7:36 Jocelyn Mayer
2006-04-23 18:17 Fabrice Bellard
2005-06-04 22:19 Fabrice Bellard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.