[Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller

[Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller

[Huy Cong Vu]

Hello Xenomai group, 
I recently run a test of rtnet on xenomai-3-next on my Intel NUC D54250WYK with the Intel I218V Ethernet Controller. 
It is patched on linux 3.14.17. Here I attached the patch to make rtnet work with i217/i218 Intel family. 
Also, I found out that in rtpacket module, the declaration of packet_proto_drv lack of .device_count attribute, which makes the rtpacket & rtcap modules unable to loaded ( -EINVAL is returned), so I merge it in my patch too. 
I test on my system and all the following command is now working: 
modprobe rtnet 
modprobe rt_e1000e 
modprobe rtpacket 
modprobe rtcap 
rtifconfig rteth0 up 
ifconfig rteth0 up 
ifconfig rteth0-mac up 
But if I used the rteth0 interface, I can't unload rt_e1000e. 
Could you take a look and see if anything is wrong, and if you find it useful, merge it in your git repository. 
Best regards, 


-- 

Huy Cong 
Wandercraft SAS 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xenomai-3-next-rtnet-i217.patch
Type: text/x-patch
Size: 26921 bytes
Desc: not available
URL: <http://www.xenomai.org/pipermail/xenomai/attachments/20150127/b0caea4a/attachment.bin>

Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller

[Gilles Chanteperdrix]

On Tue, Jan 27, 2015 at 04:12:48PM +0100, Huy Cong Vu wrote:
> Hello Xenomai group, 
> I recently run a test of rtnet on xenomai-3-next on my Intel NUC D54250WYK with the Intel I218V Ethernet Controller. 
> It is patched on linux 3.14.17. Here I attached the patch to make rtnet work with i217/i218 Intel family. 
> Also, I found out that in rtpacket module, the declaration of packet_proto_drv lack of .device_count attribute, which makes the rtpacket & rtcap modules unable to loaded ( -EINVAL is returned), so I merge it in my patch too. 
> I test on my system and all the following command is now working: 
> modprobe rtnet 
> modprobe rt_e1000e 
> modprobe rtpacket 
> modprobe rtcap 
> rtifconfig rteth0 up 
> ifconfig rteth0 up 
> ifconfig rteth0-mac up 
> But if I used the rteth0 interface, I can't unload rt_e1000e. 
> Could you take a look and see if anything is wrong, and if you find it useful, merge it in your git repository. 
> Best regards, 

In Xenomai 3, you need to deconfigure the interface before you try
to unload it.

-- 
					    Gilles.

Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller

[Huy Cong Vu]

----- Mail original -----
> De: "Gilles Chanteperdrix" <gilles.chanteperdrix@xenomai.org>
> À: "Huy Cong Vu" <huy-cong.vu@wandercraft.eu>
> Cc: xenomai@xenomai.org
> Envoyé: Mardi 27 Janvier 2015 16:39:03
> Objet: Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller

> On Tue, Jan 27, 2015 at 04:12:48PM +0100, Huy Cong Vu wrote:
>> Hello Xenomai group,
>> I recently run a test of rtnet on xenomai-3-next on my Intel NUC D54250WYK with
>> the Intel I218V Ethernet Controller.
>> It is patched on linux 3.14.17. Here I attached the patch to make rtnet work
>> with i217/i218 Intel family.
>> Also, I found out that in rtpacket module, the declaration of packet_proto_drv
>> lack of .device_count attribute, which makes the rtpacket & rtcap modules
>> unable to loaded ( -EINVAL is returned), so I merge it in my patch too.
>> I test on my system and all the following command is now working:
>> modprobe rtnet
>> modprobe rt_e1000e
>> modprobe rtpacket
>> modprobe rtcap
>> rtifconfig rteth0 up
>> ifconfig rteth0 up
>> ifconfig rteth0-mac up
>> But if I used the rteth0 interface, I can't unload rt_e1000e.
>> Could you take a look and see if anything is wrong, and if you find it useful,
>> merge it in your git repository.
>> Best regards,
> 
> In Xenomai 3, you need to deconfigure the interface before you try
> to unload it.

If I tried to turn off rteth0 interface after using it, I still can't unload rt_e1000e.
For now, this work: 
modprobe rt_e1000e
modprobe rtpacket
rtifconfig rteth0 up
rtifconfig rteth0 down
rmmod rt_e1000e
rmmod rtpacket

This doesn't work:
modprobe rt_e1000e
modprobe rtpacket
rtifconfig rteth0 up
//Send datagram through rteth0 interface 
rtifconfig rteth0 down
rmmod rt_e1000e

Do I have to do anything special from application level to deconfigure rteth0 too?
> 
> --
> 					    Gilles.

-- 
Huy Cong
Wandercraft SAS

Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller

[Gilles Chanteperdrix]

On Tue, Jan 27, 2015 at 04:54:39PM +0100, Huy Cong Vu wrote:
> 
> 
> ----- Mail original -----
> > De: "Gilles Chanteperdrix" <gilles.chanteperdrix@xenomai.org>
> > À: "Huy Cong Vu" <huy-cong.vu@wandercraft.eu>
> > Cc: xenomai@xenomai.org
> > Envoyé: Mardi 27 Janvier 2015 16:39:03
> > Objet: Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller
> 
> > On Tue, Jan 27, 2015 at 04:12:48PM +0100, Huy Cong Vu wrote:
> >> Hello Xenomai group,
> >> I recently run a test of rtnet on xenomai-3-next on my Intel NUC D54250WYK with
> >> the Intel I218V Ethernet Controller.
> >> It is patched on linux 3.14.17. Here I attached the patch to make rtnet work
> >> with i217/i218 Intel family.
> >> Also, I found out that in rtpacket module, the declaration of packet_proto_drv
> >> lack of .device_count attribute, which makes the rtpacket & rtcap modules
> >> unable to loaded ( -EINVAL is returned), so I merge it in my patch too.
> >> I test on my system and all the following command is now working:
> >> modprobe rtnet
> >> modprobe rt_e1000e
> >> modprobe rtpacket
> >> modprobe rtcap
> >> rtifconfig rteth0 up
> >> ifconfig rteth0 up
> >> ifconfig rteth0-mac up
> >> But if I used the rteth0 interface, I can't unload rt_e1000e.
> >> Could you take a look and see if anything is wrong, and if you find it useful,
> >> merge it in your git repository.
> >> Best regards,
> > 
> > In Xenomai 3, you need to deconfigure the interface before you try
> > to unload it.
> 
> If I tried to turn off rteth0 interface after using it, I still can't unload rt_e1000e.
> For now, this work: 
> modprobe rt_e1000e
> modprobe rtpacket
> rtifconfig rteth0 up
> rtifconfig rteth0 down
> rmmod rt_e1000e
> rmmod rtpacket
> 
> This doesn't work:
> modprobe rt_e1000e
> modprobe rtpacket
> rtifconfig rteth0 up
> //Send datagram through rteth0 interface 
> rtifconfig rteth0 down
> rmmod rt_e1000e
> 
> Do I have to do anything special from application level to deconfigure rteth0 too?

No, rtifconfig down should be enough. Note that the module count
handling requires some patches in the I-pipe kernel. Since it was
reworked, it is entirely possible that there are some glitches with
it, or that some necessary change in rt_e1000e.c is missing.

Also, since the multiple modules system will not fly for building
rtnet and its modules into the kernel, this will be reworked.

Other than that, does rtnet work for you ?

-- 
					    Gilles.

Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller

[Huy Cong Vu]

----- Mail original -----
> De: "Gilles Chanteperdrix" <gilles.chanteperdrix@xenomai.org>
> À: "Huy Cong Vu" <huy-cong.vu@wandercraft.eu>
> Cc: xenomai@xenomai.org
> Envoyé: Mardi 27 Janvier 2015 17:00:45
> Objet: Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller

> On Tue, Jan 27, 2015 at 04:54:39PM +0100, Huy Cong Vu wrote:
>> 
>> 
>> ----- Mail original -----
>> > De: "Gilles Chanteperdrix" <gilles.chanteperdrix@xenomai.org>
>> > À: "Huy Cong Vu" <huy-cong.vu@wandercraft.eu>
>> > Cc: xenomai@xenomai.org
>> > Envoyé: Mardi 27 Janvier 2015 16:39:03
>> > Objet: Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller
>> 
>> > On Tue, Jan 27, 2015 at 04:12:48PM +0100, Huy Cong Vu wrote:
>> >> Hello Xenomai group,
>> >> I recently run a test of rtnet on xenomai-3-next on my Intel NUC D54250WYK with
>> >> the Intel I218V Ethernet Controller.
>> >> It is patched on linux 3.14.17. Here I attached the patch to make rtnet work
>> >> with i217/i218 Intel family.
>> >> Also, I found out that in rtpacket module, the declaration of packet_proto_drv
>> >> lack of .device_count attribute, which makes the rtpacket & rtcap modules
>> >> unable to loaded ( -EINVAL is returned), so I merge it in my patch too.
>> >> I test on my system and all the following command is now working:
>> >> modprobe rtnet
>> >> modprobe rt_e1000e
>> >> modprobe rtpacket
>> >> modprobe rtcap
>> >> rtifconfig rteth0 up
>> >> ifconfig rteth0 up
>> >> ifconfig rteth0-mac up
>> >> But if I used the rteth0 interface, I can't unload rt_e1000e.
>> >> Could you take a look and see if anything is wrong, and if you find it useful,
>> >> merge it in your git repository.
>> >> Best regards,
>> > 
>> > In Xenomai 3, you need to deconfigure the interface before you try
>> > to unload it.
>> 
>> If I tried to turn off rteth0 interface after using it, I still can't unload
>> rt_e1000e.
>> For now, this work:
>> modprobe rt_e1000e
>> modprobe rtpacket
>> rtifconfig rteth0 up
>> rtifconfig rteth0 down
>> rmmod rt_e1000e
>> rmmod rtpacket
>> 
>> This doesn't work:
>> modprobe rt_e1000e
>> modprobe rtpacket
>> rtifconfig rteth0 up
>> //Send datagram through rteth0 interface
>> rtifconfig rteth0 down
>> rmmod rt_e1000e
>> 
>> Do I have to do anything special from application level to deconfigure rteth0
>> too?
> 
> No, rtifconfig down should be enough. Note that the module count
> handling requires some patches in the I-pipe kernel. Since it was
> reworked, it is entirely possible that there are some glitches with
> it, or that some necessary change in rt_e1000e.c is missing.
> 
> Also, since the multiple modules system will not fly for building
> rtnet and its modules into the kernel, this will be reworked.
> 
> Other than that, does rtnet work for you ?

Yes, except this problem, my test with rtnet runs fine.
 
> 
> --
> 					    Gilles.

-- 
Huy Cong
Wandercraft SAS

Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller

[Huy Cong Vu]

----- Mail original -----
> De: "Huy Cong Vu" <huy-cong.vu@wandercraft.eu>
> À: "Gilles Chanteperdrix" <gilles.chanteperdrix@xenomai.org>
> Cc: xenomai@xenomai.org
> Envoyé: Mardi 27 Janvier 2015 17:11:40
> Objet: Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller

> ----- Mail original -----
>> De: "Gilles Chanteperdrix" <gilles.chanteperdrix@xenomai.org>
>> À: "Huy Cong Vu" <huy-cong.vu@wandercraft.eu>
>> Cc: xenomai@xenomai.org
>> Envoyé: Mardi 27 Janvier 2015 17:00:45
>> Objet: Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller
> 
>> On Tue, Jan 27, 2015 at 04:54:39PM +0100, Huy Cong Vu wrote:
>>> 
>>> 
>>> ----- Mail original -----
>>> > De: "Gilles Chanteperdrix" <gilles.chanteperdrix@xenomai.org>
>>> > À: "Huy Cong Vu" <huy-cong.vu@wandercraft.eu>
>>> > Cc: xenomai@xenomai.org
>>> > Envoyé: Mardi 27 Janvier 2015 16:39:03
>>> > Objet: Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller
>>> 
>>> > On Tue, Jan 27, 2015 at 04:12:48PM +0100, Huy Cong Vu wrote:
>>> >> Hello Xenomai group,
>>> >> I recently run a test of rtnet on xenomai-3-next on my Intel NUC D54250WYK with
>>> >> the Intel I218V Ethernet Controller.
>>> >> It is patched on linux 3.14.17. Here I attached the patch to make rtnet work
>>> >> with i217/i218 Intel family.
>>> >> Also, I found out that in rtpacket module, the declaration of packet_proto_drv
>>> >> lack of .device_count attribute, which makes the rtpacket & rtcap modules
>>> >> unable to loaded ( -EINVAL is returned), so I merge it in my patch too.
>>> >> I test on my system and all the following command is now working:
>>> >> modprobe rtnet
>>> >> modprobe rt_e1000e
>>> >> modprobe rtpacket
>>> >> modprobe rtcap
>>> >> rtifconfig rteth0 up
>>> >> ifconfig rteth0 up
>>> >> ifconfig rteth0-mac up
>>> >> But if I used the rteth0 interface, I can't unload rt_e1000e.
>>> >> Could you take a look and see if anything is wrong, and if you find it useful,
>>> >> merge it in your git repository.
>>> >> Best regards,
>>> > 
>>> > In Xenomai 3, you need to deconfigure the interface before you try
>>> > to unload it.
>>> 
>>> If I tried to turn off rteth0 interface after using it, I still can't unload
>>> rt_e1000e.
>>> For now, this work:
>>> modprobe rt_e1000e
>>> modprobe rtpacket
>>> rtifconfig rteth0 up
>>> rtifconfig rteth0 down
>>> rmmod rt_e1000e
>>> rmmod rtpacket
>>> 
>>> This doesn't work:
>>> modprobe rt_e1000e
>>> modprobe rtpacket
>>> rtifconfig rteth0 up
>>> //Send datagram through rteth0 interface
>>> rtifconfig rteth0 down
>>> rmmod rt_e1000e
>>> 

This patch helps. 

diff --git a/kernel/drivers/net/stack/packet/af_packet.c b/kernel/drivers/net/stack/packet/af_packet.c
index dd862fe..6a9f183 100644
--- a/kernel/drivers/net/stack/packet/af_packet.c
+++ b/kernel/drivers/net/stack/packet/af_packet.c
@@ -456,6 +456,7 @@ rt_packet_sendmsg(struct rtdm_fd *fd, const struct msghdr *msg, int msg_flags)
     }
 
  out:
+    rtdev_dereference(rtdev);
     return ret;
 
  err:

Now it seems ok to unload all modules for me.

>>> Do I have to do anything special from application level to deconfigure rteth0
>>> too?
>> 
>> No, rtifconfig down should be enough. Note that the module count
>> handling requires some patches in the I-pipe kernel. Since it was
>> reworked, it is entirely possible that there are some glitches with
>> it, or that some necessary change in rt_e1000e.c is missing.
>> 
>> Also, since the multiple modules system will not fly for building
>> rtnet and its modules into the kernel, this will be reworked.
>> 
>> Other than that, does rtnet work for you ?
> 
> Yes, except this problem, my test with rtnet runs fine.
> 
>> 
>> --
>> 					    Gilles.
> 
> --
> Huy Cong
> Wandercraft SAS
> 
> _______________________________________________
> Xenomai mailing list
> Xenomai@xenomai.org
> http://www.xenomai.org/mailman/listinfo/xenomai

-- 
Huy Cong
Wandercraft SAS

Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller

[Gilles Chanteperdrix]

On Tue, Feb 10, 2015 at 11:46:01AM +0100, Huy Cong Vu wrote:
> 
> 
> ----- Mail original -----
> > De: "Huy Cong Vu" <huy-cong.vu@wandercraft.eu>
> > À: "Gilles Chanteperdrix" <gilles.chanteperdrix@xenomai.org>
> > Cc: xenomai@xenomai.org
> > Envoyé: Mardi 27 Janvier 2015 17:11:40
> > Objet: Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller
> 
> > ----- Mail original -----
> >> De: "Gilles Chanteperdrix" <gilles.chanteperdrix@xenomai.org>
> >> À: "Huy Cong Vu" <huy-cong.vu@wandercraft.eu>
> >> Cc: xenomai@xenomai.org
> >> Envoyé: Mardi 27 Janvier 2015 17:00:45
> >> Objet: Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller
> > 
> >> On Tue, Jan 27, 2015 at 04:54:39PM +0100, Huy Cong Vu wrote:
> >>> 
> >>> 
> >>> ----- Mail original -----
> >>> > De: "Gilles Chanteperdrix" <gilles.chanteperdrix@xenomai.org>
> >>> > À: "Huy Cong Vu" <huy-cong.vu@wandercraft.eu>
> >>> > Cc: xenomai@xenomai.org
> >>> > Envoyé: Mardi 27 Janvier 2015 16:39:03
> >>> > Objet: Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller
> >>> 
> >>> > On Tue, Jan 27, 2015 at 04:12:48PM +0100, Huy Cong Vu wrote:
> >>> >> Hello Xenomai group,
> >>> >> I recently run a test of rtnet on xenomai-3-next on my Intel NUC D54250WYK with
> >>> >> the Intel I218V Ethernet Controller.
> >>> >> It is patched on linux 3.14.17. Here I attached the patch to make rtnet work
> >>> >> with i217/i218 Intel family.
> >>> >> Also, I found out that in rtpacket module, the declaration of packet_proto_drv
> >>> >> lack of .device_count attribute, which makes the rtpacket & rtcap modules
> >>> >> unable to loaded ( -EINVAL is returned), so I merge it in my patch too.
> >>> >> I test on my system and all the following command is now working:
> >>> >> modprobe rtnet
> >>> >> modprobe rt_e1000e
> >>> >> modprobe rtpacket
> >>> >> modprobe rtcap
> >>> >> rtifconfig rteth0 up
> >>> >> ifconfig rteth0 up
> >>> >> ifconfig rteth0-mac up
> >>> >> But if I used the rteth0 interface, I can't unload rt_e1000e.
> >>> >> Could you take a look and see if anything is wrong, and if you find it useful,
> >>> >> merge it in your git repository.
> >>> >> Best regards,
> >>> > 
> >>> > In Xenomai 3, you need to deconfigure the interface before you try
> >>> > to unload it.
> >>> 
> >>> If I tried to turn off rteth0 interface after using it, I still can't unload
> >>> rt_e1000e.
> >>> For now, this work:
> >>> modprobe rt_e1000e
> >>> modprobe rtpacket
> >>> rtifconfig rteth0 up
> >>> rtifconfig rteth0 down
> >>> rmmod rt_e1000e
> >>> rmmod rtpacket
> >>> 
> >>> This doesn't work:
> >>> modprobe rt_e1000e
> >>> modprobe rtpacket
> >>> rtifconfig rteth0 up
> >>> //Send datagram through rteth0 interface
> >>> rtifconfig rteth0 down
> >>> rmmod rt_e1000e
> >>> 
> 
> This patch helps. 
> 
> diff --git a/kernel/drivers/net/stack/packet/af_packet.c b/kernel/drivers/net/stack/packet/af_packet.c
> index dd862fe..6a9f183 100644
> --- a/kernel/drivers/net/stack/packet/af_packet.c
> +++ b/kernel/drivers/net/stack/packet/af_packet.c
> @@ -456,6 +456,7 @@ rt_packet_sendmsg(struct rtdm_fd *fd, const struct msghdr *msg, int msg_flags)
>      }
>  
>   out:
> +    rtdev_dereference(rtdev);
>      return ret;
>  
>   err:
> 
> Now it seems ok to unload all modules for me.

Ok, will merge, thanks.

-- 
					    Gilles.

Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller

[Gilles Chanteperdrix]

On Tue, Feb 10, 2015 at 11:46:01AM +0100, Huy Cong Vu wrote:
> This patch helps. 
> 
> diff --git a/kernel/drivers/net/stack/packet/af_packet.c b/kernel/drivers/net/stack/packet/af_packet.c
> index dd862fe..6a9f183 100644
> --- a/kernel/drivers/net/stack/packet/af_packet.c
> +++ b/kernel/drivers/net/stack/packet/af_packet.c
> @@ -456,6 +456,7 @@ rt_packet_sendmsg(struct rtdm_fd *fd, const struct msghdr *msg, int msg_flags)
>      }
>  
>   out:
> +    rtdev_dereference(rtdev);
>      return ret;
>  
>   err:
> 
> Now it seems ok to unload all modules for me.

Merged, thanks.

-- 
					    Gilles.

Re: [Xenomai] Patch rtnet support Intel i217/i218 Ethernet Controller

[Gilles Chanteperdrix]

On Tue, Jan 27, 2015 at 04:12:48PM +0100, Huy Cong Vu wrote:
> Could you take a look and see if anything is wrong, and if you find it useful, merge it in your git repository. 

Merged, thanks.

-- 
					    Gilles.