All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Bob Copeland <me@bobcopeland.com>
Cc: "Stefanik Gábor" <netrolller.3d@gmail.com>,
	"Dan Williams" <dcbw@redhat.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [ath5k-devel] [PATCH] ath5k: set mac address in add_interface
Date: Tue, 16 Dec 2008 16:01:09 +0100	[thread overview]
Message-ID: <1229439670.4471.41.camel@johannes.berg> (raw)
In-Reply-To: <b6c5339f0812160658y5ed2ceb4qdbb4b2ddf1fe07a5@mail.gmail.com> (sfid-20081216_155826_911157_CE1A0E9E)

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

On Tue, 2008-12-16 at 09:58 -0500, Bob Copeland wrote:

> The code, for mac address setting at least, looks to be working as
> designed: the mac address is only set up at add_interface time to avoid
> automatically acking packets before an interface is brought up (see the
> kerneldoc comments in mac80211 on add/remove_interface).
> 
> The ath5k rx filter for unicast frames requires mac addresses to match in
> order to accept or ack frames.  However, in monitor mode, mac80211 will
> never call add_interface().  Instead, it should configure the filter to
> put the card in promiscuous mode which then should enable all packets
> to be passed back to the host.

FWIW, this is as designed, if you need to have ACKs then you need to
bring up a monitor as well as a regular interface. Stefanik, please do
that and report whether it works.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2008-12-16 15:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-18  4:40 [PATCH] ath5k: set mac address in add_interface Bob Copeland
2008-11-21 19:49 ` Maxim Levitsky
2008-11-21 20:01   ` [ath5k-devel] " Bob Copeland
2008-11-21 20:53     ` Maxim Levitsky
2008-11-21 21:45       ` Maxim Levitsky
2008-11-21 23:15         ` Bob Copeland
2008-11-22 13:25           ` Maxim Levitsky
2008-12-15 15:47 ` Stefanik Gábor
2008-12-15 16:04   ` Dan Williams
2008-12-15 16:12     ` Stefanik Gábor
2008-12-15 16:22       ` Dan Williams
2008-12-15 17:16       ` [ath5k-devel] " Bob Copeland
2008-12-16 14:58         ` Bob Copeland
2008-12-16 15:01           ` Johannes Berg [this message]
2008-12-19 15:15             ` Bob Copeland
2008-12-20  9:46               ` Johannes Berg
2008-12-16 15:42           ` Stefanik Gábor
     [not found]   ` <20081215161435.M87237@bobcopeland.com>
2008-12-15 16:30     ` Stefanik Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229439670.4471.41.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=dcbw@redhat.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=me@bobcopeland.com \
    --cc=netrolller.3d@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.