Re: [ath5k-devel] [PATCH] ath5k: set mac address in add_interface

From: "Bob Copeland" <me@bobcopeland.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Stefanik Gábor " <netrolller.3d@gmail.com>,
	"Dan Williams" <dcbw@redhat.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [ath5k-devel] [PATCH] ath5k: set mac address in add_interface
Date: Fri, 19 Dec 2008 10:15:16 -0500	[thread overview]
Message-ID: <20081219151036.M48373@bobcopeland.com> (raw)
In-Reply-To: <1229439670.4471.41.camel@johannes.berg>

On Tue, 16 Dec 2008 16:01:09 +0100, Johannes Berg wrote
> > The ath5k rx filter for unicast frames requires mac addresses to match in
> > order to accept or ack frames.  However, in monitor mode, mac80211 will
> > never call add_interface().  Instead, it should configure the filter to
> > put the card in promiscuous mode which then should enable all packets
> > to be passed back to the host.
> 
> FWIW, this is as designed, if you need to have ACKs then you need to
> bring up a monitor as well as a regular interface. Stefanik, please do
> that and report whether it works.

So in that case, ath5k definitely should not upload a mac until a normal
interface is brought up, i.e. we should keep the current functionality?

It's interesting that b43 works without a regular interface, by my reading of
its code the mac is also loaded and cleared at add/remove interface time.

-- 
Bob Copeland %% www.bobcopeland.com