All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stefanik Gábor" <netrolller.3d@gmail.com>
To: "Bob Copeland" <me@bobcopeland.com>
Cc: maximlevitsky@gmail.com, ath5k-devel@lists.ath5k.org,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath5k: set mac address in add_interface
Date: Mon, 15 Dec 2008 17:30:23 +0100	[thread overview]
Message-ID: <69e28c910812150830s5884ad61j87d16013142639cb@mail.gmail.com> (raw)
In-Reply-To: <20081215161435.M87237@bobcopeland.com>

On Mon, Dec 15, 2008 at 5:17 PM, Bob Copeland <me@bobcopeland.com> wrot=
e:
> On Mon, 15 Dec 2008 16:47:48 +0100, Stefanik G=E1bor wrote
>> This patch regressed support for aireplay-ng's "fragmentation attack=
" feature!
>
> Does reverting just the following hunk make it work again?
>
>> > --- a/drivers/net/wireless/ath5k/attach.c
>> > +++ b/drivers/net/wireless/ath5k/attach.c
> [...]
>> > @@ -317,15 +317,9 @@ struct ath5k_hw *ath5k_hw_attach(struct ath5k=
_softc
> *sc, u8 mac_version)
>> >                goto err_free;
>> >        }
>> >
>> > -       /* Set MAC address */
>> > -       ret =3D ath5k_eeprom_read_mac(ah, mac);
>> > -       if (ret) {
>> > -               ATH5K_ERR(sc, "unable to read address from EEPROM:=
 0x%04x\n",
>> > -                       sc->pdev->device);
>> > -               goto err_free;
>> > -       }
>> > -
>> > +       /* MAC address is cleared until add_interface */
>> >        ath5k_hw_set_lladdr(ah, mac);
>> > +
>> >        /* Set BSSID to bcast address: ff:ff:ff:ff:ff:ff for now */
>> >        memset(ah->ah_bssid, 0xff, ETH_ALEN);
>> >        ath5k_hw_set_associd(ah, ah->ah_bssid, 0);
>
> --
> Bob Copeland %% www.bobcopeland.com
>
>
>

Yes, this fixes it.

--=20
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2008-12-15 16:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-18  4:40 [PATCH] ath5k: set mac address in add_interface Bob Copeland
2008-11-21 19:49 ` Maxim Levitsky
2008-11-21 20:01   ` [ath5k-devel] " Bob Copeland
2008-11-21 20:53     ` Maxim Levitsky
2008-11-21 21:45       ` Maxim Levitsky
2008-11-21 23:15         ` Bob Copeland
2008-11-22 13:25           ` Maxim Levitsky
2008-12-15 15:47 ` Stefanik Gábor
2008-12-15 16:04   ` Dan Williams
2008-12-15 16:12     ` Stefanik Gábor
2008-12-15 16:22       ` Dan Williams
2008-12-15 17:16       ` [ath5k-devel] " Bob Copeland
2008-12-16 14:58         ` Bob Copeland
2008-12-16 15:01           ` Johannes Berg
2008-12-19 15:15             ` Bob Copeland
2008-12-20  9:46               ` Johannes Berg
2008-12-16 15:42           ` Stefanik Gábor
     [not found]   ` <20081215161435.M87237@bobcopeland.com>
2008-12-15 16:30     ` Stefanik Gábor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69e28c910812150830s5884ad61j87d16013142639cb@mail.gmail.com \
    --to=netrolller.3d@gmail.com \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    --cc=me@bobcopeland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.