* Re: linux-next acpi changes make vmware server unusable
2009-03-05 0:44 ` Lin Ming
@ 2009-03-05 1:51 ` Eric Paris
2009-03-16 3:55 ` Len Brown
1 sibling, 0 replies; 4+ messages in thread
From: Eric Paris @ 2009-03-05 1:51 UTC (permalink / raw)
To: Lin Ming; +Cc: linux-acpi, Moore, Robert, Brown, Len
On Thu, 2009-03-05 at 08:44 +0800, Lin Ming wrote:
> On Thu, 2009-03-05 at 05:55 +0800, Eric Paris wrote:
> > I built a linux-next kernel yesterday and discovered that the free
> > vmware server 2 would start to boot the kernel and very quickly just
> > power off. vmware gave some crap message about the MBR being wrong,
> > which obviously wasn't the case since grub started and the kernel
> > started booting. Looking at the last line on the serial console for the
> > new kernel and the next line in a working kernel I knew the next output
> > was supposed to be in the ACPI code. I bisected drivers/acpi and found
> > that d6c349993fc7c9dabf873796c4e82bb94544b3ce is first bad commit.
>
> Would you please try below patch?
linux-next + this patch boots just fine.
Thanks!!
-Eric
> ACPICA: Check for non-zero address before being converted to GAS
>
> Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> ---
> drivers/acpi/acpica/tbfadt.c | 16 +++++++++-------
> 1 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/acpi/acpica/tbfadt.c b/drivers/acpi/acpica/tbfadt.c
> index 042d239..af8fbe1 100644
> --- a/drivers/acpi/acpica/tbfadt.c
> +++ b/drivers/acpi/acpica/tbfadt.c
> @@ -625,12 +625,14 @@ static void acpi_tb_setup_fadt_registers(void)
> ACPI_ADD_PTR(struct acpi_generic_address, &acpi_gbl_FADT,
> fadt_pm_info_table[i].source);
>
> - acpi_tb_init_generic_address(fadt_pm_info_table[i].target,
> - source64->space_id,
> - pm1_register_byte_width,
> - source64->address +
> - (fadt_pm_info_table[i].
> - register_num *
> - pm1_register_byte_width));
> + if (source64->address) {
> + acpi_tb_init_generic_address(fadt_pm_info_table[i].
> + target, source64->space_id,
> + pm1_register_byte_width,
> + source64->address +
> + (fadt_pm_info_table[i].
> + register_num *
> + pm1_register_byte_width));
> + }
> }
> }
>
>
> >
> > I have no idea what vmware is doing, or what we are doing, but before
> > that patch I was able to boot and after it, vmware just shuts itself
> > off.
> >
> > -Eric
> >
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next acpi changes make vmware server unusable
2009-03-05 0:44 ` Lin Ming
2009-03-05 1:51 ` Eric Paris
@ 2009-03-16 3:55 ` Len Brown
1 sibling, 0 replies; 4+ messages in thread
From: Len Brown @ 2009-03-16 3:55 UTC (permalink / raw)
To: Lin Ming; +Cc: Eric Paris, linux-acpi, Moore, Robert
this one is inserted into the acpica branch to fix the -next regression.
thanks,
Len Brown, Intel Open Source Technology Center
On Thu, 5 Mar 2009, Lin Ming wrote:
> On Thu, 2009-03-05 at 05:55 +0800, Eric Paris wrote:
> > I built a linux-next kernel yesterday and discovered that the free
> > vmware server 2 would start to boot the kernel and very quickly just
> > power off. vmware gave some crap message about the MBR being wrong,
> > which obviously wasn't the case since grub started and the kernel
> > started booting. Looking at the last line on the serial console for the
> > new kernel and the next line in a working kernel I knew the next output
> > was supposed to be in the ACPI code. I bisected drivers/acpi and found
> > that d6c349993fc7c9dabf873796c4e82bb94544b3ce is first bad commit.
>
> Would you please try below patch?
>
>
> ACPICA: Check for non-zero address before being converted to GAS
>
> Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> ---
> drivers/acpi/acpica/tbfadt.c | 16 +++++++++-------
> 1 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/acpi/acpica/tbfadt.c b/drivers/acpi/acpica/tbfadt.c
> index 042d239..af8fbe1 100644
> --- a/drivers/acpi/acpica/tbfadt.c
> +++ b/drivers/acpi/acpica/tbfadt.c
> @@ -625,12 +625,14 @@ static void acpi_tb_setup_fadt_registers(void)
> ACPI_ADD_PTR(struct acpi_generic_address, &acpi_gbl_FADT,
> fadt_pm_info_table[i].source);
>
> - acpi_tb_init_generic_address(fadt_pm_info_table[i].target,
> - source64->space_id,
> - pm1_register_byte_width,
> - source64->address +
> - (fadt_pm_info_table[i].
> - register_num *
> - pm1_register_byte_width));
> + if (source64->address) {
> + acpi_tb_init_generic_address(fadt_pm_info_table[i].
> + target, source64->space_id,
> + pm1_register_byte_width,
> + source64->address +
> + (fadt_pm_info_table[i].
> + register_num *
> + pm1_register_byte_width));
> + }
> }
> }
>
>
> >
> > I have no idea what vmware is doing, or what we are doing, but before
> > that patch I was able to boot and after it, vmware just shuts itself
> > off.
> >
> > -Eric
> >
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread