All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	David Howells <dhowells@redhat.com>,
	Nick Piggin <npiggin@suse.de>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Rik van Riel <riel@redhat.com>,
	Peter Zijlstra <peterz@infradead.com>,
	MinChan Kim <minchan.kim@gmail.com>,
	Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Subject: [patch 3/3] mm: keep pages from unevictable mappings off the LRU lists
Date: Sun, 22 Mar 2009 21:13:04 +0100	[thread overview]
Message-ID: <1237752784-1989-3-git-send-email-hannes@cmpxchg.org> (raw)
In-Reply-To: <20090321102044.GA3427@cmpxchg.org>

Check if the mapping is evictable when initially adding page cache
pages to the LRU lists.  If that is not the case, add them to the
unevictable list immediately instead of leaving it up to the reclaim
code to move them there.

This is useful for ramfs and locked shmem which mark whole mappings as
unevictable and we know at fault time already that it is useless to
try reclaiming these pages.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Nick Piggin <npiggin@suse.de>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.com>
Cc: MinChan Kim <minchan.kim@gmail.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
---
 mm/filemap.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/mm/filemap.c b/mm/filemap.c
index 23acefe..8574530 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -506,7 +506,9 @@ int add_to_page_cache_lru(struct page *page, struct address_space *mapping,
 
 	ret = add_to_page_cache(page, mapping, offset, gfp_mask);
 	if (ret == 0) {
-		if (page_is_file_cache(page))
+		if (mapping_unevictable(mapping))
+			add_page_to_unevictable_list(page);
+		else if (page_is_file_cache(page))
 			lru_cache_add_file(page);
 		else
 			lru_cache_add_active_anon(page);
-- 
1.6.2.1.135.gde769


WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	David Howells <dhowells@redhat.com>,
	Nick Piggin <npiggin@suse.de>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Rik van Riel <riel@redhat.com>,
	Peter Zijlstra <peterz@infradead.com>,
	MinChan Kim <minchan.kim@gmail.com>,
	Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Subject: [patch 3/3] mm: keep pages from unevictable mappings off the LRU lists
Date: Sun, 22 Mar 2009 21:13:04 +0100	[thread overview]
Message-ID: <1237752784-1989-3-git-send-email-hannes@cmpxchg.org> (raw)
In-Reply-To: <20090321102044.GA3427@cmpxchg.org>

Check if the mapping is evictable when initially adding page cache
pages to the LRU lists.  If that is not the case, add them to the
unevictable list immediately instead of leaving it up to the reclaim
code to move them there.

This is useful for ramfs and locked shmem which mark whole mappings as
unevictable and we know at fault time already that it is useless to
try reclaiming these pages.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Nick Piggin <npiggin@suse.de>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.com>
Cc: MinChan Kim <minchan.kim@gmail.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
---
 mm/filemap.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/mm/filemap.c b/mm/filemap.c
index 23acefe..8574530 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -506,7 +506,9 @@ int add_to_page_cache_lru(struct page *page, struct address_space *mapping,
 
 	ret = add_to_page_cache(page, mapping, offset, gfp_mask);
 	if (ret == 0) {
-		if (page_is_file_cache(page))
+		if (mapping_unevictable(mapping))
+			add_page_to_unevictable_list(page);
+		else if (page_is_file_cache(page))
 			lru_cache_add_file(page);
 		else
 			lru_cache_add_active_anon(page);
-- 
1.6.2.1.135.gde769

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-03-22 20:15 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11 15:30 [PATCH] NOMMU: Pages allocated to a ramfs inode's pagecache may get wrongly discarded David Howells
2009-03-11 17:26 ` Johannes Weiner
2009-03-11 22:03 ` Andrew Morton
2009-03-11 22:03   ` Andrew Morton
2009-03-11 22:36   ` Johannes Weiner
2009-03-11 22:36     ` Johannes Weiner
2009-03-12  0:02   ` Andrew Morton
2009-03-12  0:02     ` Andrew Morton
2009-03-12  0:35     ` Minchan Kim
2009-03-12  0:35       ` Minchan Kim
2009-03-12  1:04       ` KOSAKI Motohiro
2009-03-12  1:04         ` KOSAKI Motohiro
2009-03-12  1:52         ` Minchan Kim
2009-03-12  1:52           ` Minchan Kim
2009-03-12  1:56           ` Minchan Kim
2009-03-12  1:56             ` Minchan Kim
2009-03-12  2:00           ` KOSAKI Motohiro
2009-03-12  2:00             ` KOSAKI Motohiro
2009-03-12  2:11             ` Minchan Kim
2009-03-12  2:11               ` Minchan Kim
2009-03-12 12:19         ` Robin Getz
2009-03-12 12:19           ` Robin Getz
2009-03-12 17:55           ` [uClinux-dev] " Jamie Lokier
2009-03-12 17:55             ` Jamie Lokier
2009-03-13 17:33         ` [PATCH 0/2] Make the Unevictable LRU available on NOMMU David Howells
2009-03-13 17:33           ` David Howells
2009-03-13 17:33           ` [PATCH 1/2] NOMMU: There is no mlock() for NOMMU, so don't provide the bits David Howells
2009-03-13 17:33             ` David Howells
2009-03-14 11:17             ` KOSAKI Motohiro
2009-03-14 11:17               ` KOSAKI Motohiro
2009-03-13 17:33           ` [PATCH 2/2] NOMMU: Make CONFIG_UNEVICTABLE_LRU available when CONFIG_MMU=n David Howells
2009-03-13 17:33             ` David Howells
2009-03-14 11:17             ` KOSAKI Motohiro
2009-03-14 11:17               ` KOSAKI Motohiro
2009-03-14  0:27           ` [PATCH 0/2] Make the Unevictable LRU available on NOMMU Minchan Kim
2009-03-14  0:27             ` Minchan Kim
2009-03-20 16:08             ` Lee Schermerhorn
2009-03-20 16:08               ` Lee Schermerhorn
2009-03-20 16:24             ` David Howells
2009-03-20 16:24               ` David Howells
2009-03-20 18:30               ` Lee Schermerhorn
2009-03-20 18:30                 ` Lee Schermerhorn
2009-03-21 10:20                 ` Johannes Weiner
2009-03-21 10:20                   ` Johannes Weiner
2009-03-22 20:13                   ` [patch 1/3] mm: decouple unevictable lru from mmu Johannes Weiner
2009-03-22 20:13                     ` Johannes Weiner
2009-03-22 23:46                     ` KOSAKI Motohiro
2009-03-22 23:46                       ` KOSAKI Motohiro
2009-03-23  0:14                       ` Johannes Weiner
2009-03-23  0:14                         ` Johannes Weiner
2009-03-23 10:48                       ` David Howells
2009-03-23 10:48                         ` David Howells
2009-03-22 20:13                   ` [patch 2/3] ramfs-nommu: use generic lru cache Johannes Weiner
2009-03-22 20:13                     ` Johannes Weiner
2009-03-23  2:22                     ` KOSAKI Motohiro
2009-03-23  2:22                       ` KOSAKI Motohiro
2009-03-22 20:13                   ` Johannes Weiner [this message]
2009-03-22 20:13                     ` [patch 3/3] mm: keep pages from unevictable mappings off the LRU lists Johannes Weiner
2009-03-23  0:44                     ` Minchan Kim
2009-03-23  0:44                       ` Minchan Kim
2009-03-23  2:21                       ` KOSAKI Motohiro
2009-03-23  2:21                         ` KOSAKI Motohiro
2009-03-23  8:42                         ` Johannes Weiner
2009-03-23  8:42                           ` Johannes Weiner
2009-03-23  9:01                           ` KOSAKI Motohiro
2009-03-23  9:01                             ` KOSAKI Motohiro
2009-03-23  9:23                             ` KOSAKI Motohiro
2009-03-23  9:23                               ` KOSAKI Motohiro
2009-03-26  0:48                               ` Johannes Weiner
2009-03-26  0:48                                 ` Johannes Weiner
2009-03-23 10:40                   ` [patch 2/3] ramfs-nommu: use generic lru cache David Howells
2009-03-23 10:40                     ` David Howells
2009-03-23 10:53                   ` [patch 3/3] mm: keep pages from unevictable mappings off the LRU lists David Howells
2009-03-23 10:53                     ` David Howells
2009-03-26  0:01                     ` Johannes Weiner
2009-03-26  0:01                       ` Johannes Weiner
2009-03-26  8:56                       ` KOSAKI Motohiro
2009-03-26  8:56                         ` KOSAKI Motohiro
2009-03-26 10:36                         ` Johannes Weiner
2009-03-26 10:36                           ` Johannes Weiner
2009-03-23 20:07                   ` [PATCH 0/2] Make the Unevictable LRU available on NOMMU Lee Schermerhorn
2009-03-23 20:07                     ` Lee Schermerhorn
2009-03-13 11:53       ` [PATCH] NOMMU: Pages allocated to a ramfs inode's pagecache may get wrongly discarded David Howells
2009-03-13 11:53         ` David Howells
2009-03-13 22:49         ` Johannes Weiner
2009-03-13 22:49           ` Johannes Weiner
2009-03-12  0:08 ` Andrew Morton
2009-03-12  7:12   ` Berkhan, Enrik (GE Infra, Oil & Gas)
2009-03-12 11:29     ` [uClinux-dev] " Jamie Lokier
2009-03-12 11:50       ` Peter Zijlstra
2009-03-12 23:20         ` Minchan Kim
2009-03-13  7:56           ` Peter Zijlstra
2009-03-13  9:17             ` Minchan Kim
2009-03-12 12:25 ` David Howells
2009-03-12 19:43   ` Andrew Morton
2009-03-13  2:03     ` KOSAKI Motohiro
2009-03-13  7:57       ` Peter Zijlstra
2009-03-13  8:15         ` KOSAKI Motohiro
2009-03-13  9:19           ` Minchan Kim
2009-03-13 10:44           ` Johannes Weiner
2009-03-14 14:29             ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1237752784-1989-3-git-send-email-hannes@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    --cc=npiggin@suse.de \
    --cc=peterz@infradead.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.