All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Getz <rgetz@blackfin.uclinux.org>
To: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>
Cc: "Minchan Kim" <minchan.kim@gmail.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	dhowells@redhat.com, torvalds@linux-foundation.org,
	peterz@infradead.org, Enrik.Berkhan@ge.com,
	uclinux-dev@uclinux.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, "Johannes Weiner" <hannes@cmpxchg.org>,
	"Rik van Riel" <riel@surriel.com>,
	"Lee Schermerhorn" <lee.schermerhorn@hp.com>
Subject: Re: [PATCH] NOMMU: Pages allocated to a ramfs inode's pagecache may  get wrongly discarded
Date: Thu, 12 Mar 2009 08:19:08 -0400	[thread overview]
Message-ID: <200903120819.08724.rgetz@blackfin.uclinux.org> (raw)
In-Reply-To: <20090312100049.43A3.A69D9226@jp.fujitsu.com>

On Wed 11 Mar 2009 21:04, KOSAKI Motohiro pondered:
> Hi
> 
> > >> Page reclaim shouldn't be even attempting to reclaim or write back
> > >> ramfs pagecache pages - reclaim can't possibly do anything with 
> > >> these pages!
> > >>
> > >> Arguably those pages shouldn't be on the LRU at all, but we haven't
> > >> done that yet.
> > >>
> > >> Now, my problem is that I can't 100% be sure that we _ever_
> > >> implemented this properly. ?I _think_ we did, in which case 
> > >> we later broke it. ?If we've always been (stupidly) trying 
> > >> to pageout these pages then OK, I guess your patch is a 
> > >> suitable 2.6.29 stopgap. 
> > >
> > > OK, I can't find any code anywhere in which we excluded ramfs pages
> > > from consideration by page reclaim. ?How dumb.
> > 
> > The ramfs  considers it in just CONFIG_UNEVICTABLE_LRU case
> > It that case, ramfs_get_inode calls mapping_set_unevictable.
> > So,  page reclaim can exclude ramfs pages by page_evictable.
> > It's problem .
> 
> Currently, CONFIG_UNEVICTABLE_LRU can't use on nommu machine
> because nobody of vmscan folk havbe nommu machine.
> 
> Yes, it is very stupid reason. _very_ welcome to tester! :)

As always - if you (or any kernel developer) would like a noMMU machine to 
test on - please send me a private email.

WARNING: multiple messages have this Message-ID (diff)
From: Robin Getz <rgetz@blackfin.uclinux.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	dhowells@redhat.com, torvalds@linux-foundation.org,
	peterz@infradead.org, Enrik.Berkhan@ge.com,
	uclinux-dev@uclinux.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
	Rik van Riel <riel@surriel.com>,
	Lee Schermerhorn <lee.schermerhorn@hp.com>
Subject: Re: [PATCH] NOMMU: Pages allocated to a ramfs inode's pagecache may  get wrongly discarded
Date: Thu, 12 Mar 2009 08:19:08 -0400	[thread overview]
Message-ID: <200903120819.08724.rgetz@blackfin.uclinux.org> (raw)
In-Reply-To: <20090312100049.43A3.A69D9226@jp.fujitsu.com>

On Wed 11 Mar 2009 21:04, KOSAKI Motohiro pondered:
> Hi
> 
> > >> Page reclaim shouldn't be even attempting to reclaim or write back
> > >> ramfs pagecache pages - reclaim can't possibly do anything with 
> > >> these pages!
> > >>
> > >> Arguably those pages shouldn't be on the LRU at all, but we haven't
> > >> done that yet.
> > >>
> > >> Now, my problem is that I can't 100% be sure that we _ever_
> > >> implemented this properly. ?I _think_ we did, in which case 
> > >> we later broke it. ?If we've always been (stupidly) trying 
> > >> to pageout these pages then OK, I guess your patch is a 
> > >> suitable 2.6.29 stopgap. 
> > >
> > > OK, I can't find any code anywhere in which we excluded ramfs pages
> > > from consideration by page reclaim. ?How dumb.
> > 
> > The ramfs  considers it in just CONFIG_UNEVICTABLE_LRU case
> > It that case, ramfs_get_inode calls mapping_set_unevictable.
> > So,  page reclaim can exclude ramfs pages by page_evictable.
> > It's problem .
> 
> Currently, CONFIG_UNEVICTABLE_LRU can't use on nommu machine
> because nobody of vmscan folk havbe nommu machine.
> 
> Yes, it is very stupid reason. _very_ welcome to tester! :)

As always - if you (or any kernel developer) would like a noMMU machine to 
test on - please send me a private email.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-03-12 12:19 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11 15:30 [PATCH] NOMMU: Pages allocated to a ramfs inode's pagecache may get wrongly discarded David Howells
2009-03-11 17:26 ` Johannes Weiner
2009-03-11 22:03 ` Andrew Morton
2009-03-11 22:03   ` Andrew Morton
2009-03-11 22:36   ` Johannes Weiner
2009-03-11 22:36     ` Johannes Weiner
2009-03-12  0:02   ` Andrew Morton
2009-03-12  0:02     ` Andrew Morton
2009-03-12  0:35     ` Minchan Kim
2009-03-12  0:35       ` Minchan Kim
2009-03-12  1:04       ` KOSAKI Motohiro
2009-03-12  1:04         ` KOSAKI Motohiro
2009-03-12  1:52         ` Minchan Kim
2009-03-12  1:52           ` Minchan Kim
2009-03-12  1:56           ` Minchan Kim
2009-03-12  1:56             ` Minchan Kim
2009-03-12  2:00           ` KOSAKI Motohiro
2009-03-12  2:00             ` KOSAKI Motohiro
2009-03-12  2:11             ` Minchan Kim
2009-03-12  2:11               ` Minchan Kim
2009-03-12 12:19         ` Robin Getz [this message]
2009-03-12 12:19           ` Robin Getz
2009-03-12 17:55           ` [uClinux-dev] " Jamie Lokier
2009-03-12 17:55             ` Jamie Lokier
2009-03-13 17:33         ` [PATCH 0/2] Make the Unevictable LRU available on NOMMU David Howells
2009-03-13 17:33           ` David Howells
2009-03-13 17:33           ` [PATCH 1/2] NOMMU: There is no mlock() for NOMMU, so don't provide the bits David Howells
2009-03-13 17:33             ` David Howells
2009-03-14 11:17             ` KOSAKI Motohiro
2009-03-14 11:17               ` KOSAKI Motohiro
2009-03-13 17:33           ` [PATCH 2/2] NOMMU: Make CONFIG_UNEVICTABLE_LRU available when CONFIG_MMU=n David Howells
2009-03-13 17:33             ` David Howells
2009-03-14 11:17             ` KOSAKI Motohiro
2009-03-14 11:17               ` KOSAKI Motohiro
2009-03-14  0:27           ` [PATCH 0/2] Make the Unevictable LRU available on NOMMU Minchan Kim
2009-03-14  0:27             ` Minchan Kim
2009-03-20 16:08             ` Lee Schermerhorn
2009-03-20 16:08               ` Lee Schermerhorn
2009-03-20 16:24             ` David Howells
2009-03-20 16:24               ` David Howells
2009-03-20 18:30               ` Lee Schermerhorn
2009-03-20 18:30                 ` Lee Schermerhorn
2009-03-21 10:20                 ` Johannes Weiner
2009-03-21 10:20                   ` Johannes Weiner
2009-03-22 20:13                   ` [patch 1/3] mm: decouple unevictable lru from mmu Johannes Weiner
2009-03-22 20:13                     ` Johannes Weiner
2009-03-22 23:46                     ` KOSAKI Motohiro
2009-03-22 23:46                       ` KOSAKI Motohiro
2009-03-23  0:14                       ` Johannes Weiner
2009-03-23  0:14                         ` Johannes Weiner
2009-03-23 10:48                       ` David Howells
2009-03-23 10:48                         ` David Howells
2009-03-22 20:13                   ` [patch 2/3] ramfs-nommu: use generic lru cache Johannes Weiner
2009-03-22 20:13                     ` Johannes Weiner
2009-03-23  2:22                     ` KOSAKI Motohiro
2009-03-23  2:22                       ` KOSAKI Motohiro
2009-03-22 20:13                   ` [patch 3/3] mm: keep pages from unevictable mappings off the LRU lists Johannes Weiner
2009-03-22 20:13                     ` Johannes Weiner
2009-03-23  0:44                     ` Minchan Kim
2009-03-23  0:44                       ` Minchan Kim
2009-03-23  2:21                       ` KOSAKI Motohiro
2009-03-23  2:21                         ` KOSAKI Motohiro
2009-03-23  8:42                         ` Johannes Weiner
2009-03-23  8:42                           ` Johannes Weiner
2009-03-23  9:01                           ` KOSAKI Motohiro
2009-03-23  9:01                             ` KOSAKI Motohiro
2009-03-23  9:23                             ` KOSAKI Motohiro
2009-03-23  9:23                               ` KOSAKI Motohiro
2009-03-26  0:48                               ` Johannes Weiner
2009-03-26  0:48                                 ` Johannes Weiner
2009-03-23 10:40                   ` [patch 2/3] ramfs-nommu: use generic lru cache David Howells
2009-03-23 10:40                     ` David Howells
2009-03-23 10:53                   ` [patch 3/3] mm: keep pages from unevictable mappings off the LRU lists David Howells
2009-03-23 10:53                     ` David Howells
2009-03-26  0:01                     ` Johannes Weiner
2009-03-26  0:01                       ` Johannes Weiner
2009-03-26  8:56                       ` KOSAKI Motohiro
2009-03-26  8:56                         ` KOSAKI Motohiro
2009-03-26 10:36                         ` Johannes Weiner
2009-03-26 10:36                           ` Johannes Weiner
2009-03-23 20:07                   ` [PATCH 0/2] Make the Unevictable LRU available on NOMMU Lee Schermerhorn
2009-03-23 20:07                     ` Lee Schermerhorn
2009-03-13 11:53       ` [PATCH] NOMMU: Pages allocated to a ramfs inode's pagecache may get wrongly discarded David Howells
2009-03-13 11:53         ` David Howells
2009-03-13 22:49         ` Johannes Weiner
2009-03-13 22:49           ` Johannes Weiner
2009-03-12  0:08 ` Andrew Morton
2009-03-12  7:12   ` Berkhan, Enrik (GE Infra, Oil & Gas)
2009-03-12 11:29     ` [uClinux-dev] " Jamie Lokier
2009-03-12 11:50       ` Peter Zijlstra
2009-03-12 23:20         ` Minchan Kim
2009-03-13  7:56           ` Peter Zijlstra
2009-03-13  9:17             ` Minchan Kim
2009-03-12 12:25 ` David Howells
2009-03-12 19:43   ` Andrew Morton
2009-03-13  2:03     ` KOSAKI Motohiro
2009-03-13  7:57       ` Peter Zijlstra
2009-03-13  8:15         ` KOSAKI Motohiro
2009-03-13  9:19           ` Minchan Kim
2009-03-13 10:44           ` Johannes Weiner
2009-03-14 14:29             ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903120819.08724.rgetz@blackfin.uclinux.org \
    --to=rgetz@blackfin.uclinux.org \
    --cc=Enrik.Berkhan@ge.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=lee.schermerhorn@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    --cc=peterz@infradead.org \
    --cc=riel@surriel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=uclinux-dev@uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.