* [PATCH] powerpc: adjust oprofile_cpu_type
@ 2009-04-17 19:48 Mike Wolf
0 siblings, 0 replies; 6+ messages in thread
From: Mike Wolf @ 2009-04-17 19:48 UTC (permalink / raw)
To: linuxppc-dev
Oprofile is changing the naming it is using for the compatibility modes.
Instead of having compat-power<x>, oprofile will go to family naming
convention and use compat-v<x>. Currently only compat-v1 will be
defined.
Signed off by: Mike Wolf <mjw@linux.vnet.ibm.com>
---
--- mainline.orig/arch/powerpc/kernel/cputable.c 2009-04-16
09:47:49.000000000 -0500
+++ mainline/arch/powerpc/kernel/cputable.c 2009-04-16
14:28:28.000000000 -0500
@@ -382,7 +382,8 @@
.icache_bsize = 128,
.dcache_bsize = 128,
.machine_check = machine_check_generic,
- .oprofile_cpu_type = "ppc64/compat-power5+",
+ .oprofile_cpu_type = "ppc64/compat-v1",
+ .oprofile_type = PPC_OPROFILE_POWER4,
.platform = "power5+",
},
{ /* Power6 */
@@ -416,7 +417,8 @@
.icache_bsize = 128,
.dcache_bsize = 128,
.machine_check = machine_check_generic,
- .oprofile_cpu_type = "ppc64/compat-power6",
+ .oprofile_cpu_type = "ppc64/compat-v1",
+ .oprofile_type = PPC_OPROFILE_POWER4,
.platform = "power6",
},
{ /* 2.06-compliant processor, i.e. Power7 "architected" mode */
@@ -429,7 +431,8 @@
.icache_bsize = 128,
.dcache_bsize = 128,
.machine_check = machine_check_generic,
- .oprofile_cpu_type = "ppc64/compat-power7",
+ .oprofile_type = PPC_OPROFILE_POWER4,
+ .oprofile_cpu_type = "ppc64/compat-v1",
.platform = "power7",
},
{ /* Power7 */
@@ -1833,8 +1836,10 @@
* and, in that case, keep the current value for
* oprofile_cpu_type.
*/
- if (old.oprofile_cpu_type == NULL)
+ if (old.oprofile_cpu_type == NULL) {
t->oprofile_cpu_type = s->oprofile_cpu_type;
+ t->oprofile_type = s->oprofile_type;
+ }
}
*PTRRELOC(&cur_cpu_spec) = &the_cpu_spec;
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] powerpc: adjust oprofile_cpu_type
@ 2009-04-22 23:40 Mike Wolf
2009-04-23 3:47 ` Kumar Gala
2009-04-23 17:52 ` Olof Johansson
0 siblings, 2 replies; 6+ messages in thread
From: Mike Wolf @ 2009-04-22 23:40 UTC (permalink / raw)
To: linuxppc-dev
Resending. the patch was munged last time.
Oprofile is changing the naming it is using for the compatibility modes.
Instead of having compat-power<x>, oprofile will go to family naming
convention and use compat-v<x>. Currently only compat-v1 will be
defined.
Signed-off-by: Mike Wolf <mjw@linux.vnet.ibm.com>
----
--- mainline.orig/arch/powerpc/kernel/cputable.c 2009-04-16 09:47:49.000000000 -0500
+++ mainline/arch/powerpc/kernel/cputable.c 2009-04-16 14:28:28.000000000 -0500
@@ -382,7 +382,8 @@
.icache_bsize = 128,
.dcache_bsize = 128,
.machine_check = machine_check_generic,
- .oprofile_cpu_type = "ppc64/compat-power5+",
+ .oprofile_cpu_type = "ppc64/compat-v1",
+ .oprofile_type = PPC_OPROFILE_POWER4,
.platform = "power5+",
},
{ /* Power6 */
@@ -416,7 +417,8 @@
.icache_bsize = 128,
.dcache_bsize = 128,
.machine_check = machine_check_generic,
- .oprofile_cpu_type = "ppc64/compat-power6",
+ .oprofile_cpu_type = "ppc64/compat-v1",
+ .oprofile_type = PPC_OPROFILE_POWER4,
.platform = "power6",
},
{ /* 2.06-compliant processor, i.e. Power7 "architected" mode */
@@ -429,7 +431,8 @@
.icache_bsize = 128,
.dcache_bsize = 128,
.machine_check = machine_check_generic,
- .oprofile_cpu_type = "ppc64/compat-power7",
+ .oprofile_type = PPC_OPROFILE_POWER4,
+ .oprofile_cpu_type = "ppc64/compat-v1",
.platform = "power7",
},
{ /* Power7 */
@@ -1833,8 +1836,10 @@
* and, in that case, keep the current value for
* oprofile_cpu_type.
*/
- if (old.oprofile_cpu_type == NULL)
+ if (old.oprofile_cpu_type == NULL) {
t->oprofile_cpu_type = s->oprofile_cpu_type;
+ t->oprofile_type = s->oprofile_type;
+ }
}
*PTRRELOC(&cur_cpu_spec) = &the_cpu_spec;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] powerpc: adjust oprofile_cpu_type
2009-04-22 23:40 Mike Wolf
@ 2009-04-23 3:47 ` Kumar Gala
2009-04-23 17:52 ` Olof Johansson
1 sibling, 0 replies; 6+ messages in thread
From: Kumar Gala @ 2009-04-23 3:47 UTC (permalink / raw)
To: mjw; +Cc: linuxppc-dev
On Apr 22, 2009, at 6:40 PM, Mike Wolf wrote:
> Resending. the patch was munged last time.
>
>
> Oprofile is changing the naming it is using for the compatibility
> modes.
> Instead of having compat-power<x>, oprofile will go to family naming
> convention and use compat-v<x>. Currently only compat-v1 will be
> defined.
>
> Signed-off-by: Mike Wolf <mjw@linux.vnet.ibm.com>
>
> ----
Any ideas what's going on w/ppc32 and these names?
- k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: adjust oprofile_cpu_type
2009-04-22 23:40 Mike Wolf
2009-04-23 3:47 ` Kumar Gala
@ 2009-04-23 17:52 ` Olof Johansson
2009-04-23 21:56 ` Mike Wolf
1 sibling, 1 reply; 6+ messages in thread
From: Olof Johansson @ 2009-04-23 17:52 UTC (permalink / raw)
To: Mike Wolf; +Cc: linuxppc-dev
On Wed, Apr 22, 2009 at 06:40:12PM -0500, Mike Wolf wrote:
> Resending. the patch was munged last time.
>
>
> Oprofile is changing the naming it is using for the compatibility modes.
> Instead of having compat-power<x>, oprofile will go to family naming
> convention and use compat-v<x>. Currently only compat-v1 will be
> defined.
Compat V1 of what? powerpc64? IBM powerpc64 PMC? The performance
monitors are not architected, to give them a version number without
vendor information seems weird.
Also, doesn't this break compatibility with existing userspace tools?
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: adjust oprofile_cpu_type
2009-04-23 17:52 ` Olof Johansson
@ 2009-04-23 21:56 ` Mike Wolf
2009-04-23 22:09 ` Olof Johansson
0 siblings, 1 reply; 6+ messages in thread
From: Mike Wolf @ 2009-04-23 21:56 UTC (permalink / raw)
To: Olof Johansson; +Cc: linuxppc-dev
On Thu, 2009-04-23 at 12:52 -0500, Olof Johansson wrote:
> On Wed, Apr 22, 2009 at 06:40:12PM -0500, Mike Wolf wrote:
> > Resending. the patch was munged last time.
> >
> >
> > Oprofile is changing the naming it is using for the compatibility modes.
> > Instead of having compat-power<x>, oprofile will go to family naming
> > convention and use compat-v<x>. Currently only compat-v1 will be
> > defined.
>
> Compat V1 of what? powerpc64? IBM powerpc64 PMC?
IBM powerpc PMC
> The performance
> monitors are not architected, to give them a version number without
> vendor information seems weird.
The current ones all fall into one family and they may be architected in
the future.
>
> Also, doesn't this break compatibility with existing userspace tools?
AFAIK there is nothing else that uses these. Oprofile patch was
rejected and this new naming was suggested from that community.
Mike
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: adjust oprofile_cpu_type
2009-04-23 21:56 ` Mike Wolf
@ 2009-04-23 22:09 ` Olof Johansson
0 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2009-04-23 22:09 UTC (permalink / raw)
To: Mike Wolf; +Cc: linuxppc-dev
On Thu, Apr 23, 2009 at 04:56:56PM -0500, Mike Wolf wrote:
> On Thu, 2009-04-23 at 12:52 -0500, Olof Johansson wrote:
> > On Wed, Apr 22, 2009 at 06:40:12PM -0500, Mike Wolf wrote:
> > > Resending. the patch was munged last time.
> > >
> > >
> > > Oprofile is changing the naming it is using for the compatibility modes.
> > > Instead of having compat-power<x>, oprofile will go to family naming
> > > convention and use compat-v<x>. Currently only compat-v1 will be
> > > defined.
> >
> > Compat V1 of what? powerpc64? IBM powerpc64 PMC?
>
> IBM powerpc PMC
Sounds like it'd be appropriate to have an ibm somewhere in the version
string then.
> > The performance
> > monitors are not architected, to give them a version number without
> > vendor information seems weird.
> The current ones all fall into one family and they may be architected in
> the future.
Not all powerpc PMC implementations do, not even all ppc64 ones --
PA6T implements a completely different performance monitor.
The current IBM PMC is included in the appendix of the architecture as
a suggestion on how to implement it, but it is explicitly specified
as being implementation dependent in the architecture.
> > Also, doesn't this break compatibility with existing userspace tools?
> AFAIK there is nothing else that uses these. Oprofile patch was
> rejected and this new naming was suggested from that community.
Ok, as long as you are 100% sure there are no proprietary users either.
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-04-23 22:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-17 19:48 [PATCH] powerpc: adjust oprofile_cpu_type Mike Wolf
2009-04-22 23:40 Mike Wolf
2009-04-23 3:47 ` Kumar Gala
2009-04-23 17:52 ` Olof Johansson
2009-04-23 21:56 ` Mike Wolf
2009-04-23 22:09 ` Olof Johansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.