From: Tejun Heo <tj@kernel.org> To: axboe@kernel.dk, linux-kernel@vger.kernel.org, jeff@garzik.org, linux-ide@vger.kernel.org, James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org, bzolnier@gmail.com, petko Cc: Tejun Heo <tj@kernel.org> Subject: [PATCH 01/11] nbd: don't clear rq->sector and nr_sectors unnecessarily Date: Mon, 4 May 2009 16:58:37 +0900 [thread overview] Message-ID: <1241423927-11871-2-git-send-email-tj@kernel.org> (raw) In-Reply-To: <1241423927-11871-1-git-send-email-tj@kernel.org> There's no reason to clear rq->sector and nr_sectors after calling blk_rq_init(). They're guaranteed to be clear. Drop unnecessary clearing. [ Impact: cleanup ] Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Paul Clements <paul.clements@steeleye.com> --- drivers/block/nbd.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 4d6de4f..a9ab8be 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -580,13 +580,6 @@ static int __nbd_ioctl(struct block_device *bdev, struct nbd_device *lo, blk_rq_init(NULL, &sreq); sreq.cmd_type = REQ_TYPE_SPECIAL; nbd_cmd(&sreq) = NBD_CMD_DISC; - /* - * Set these to sane values in case server implementation - * fails to check the request type first and also to keep - * debugging output cleaner. - */ - sreq.sector = 0; - sreq.nr_sectors = 0; if (!lo->sock) return -EINVAL; nbd_send_req(lo, &sreq); -- 1.6.0.2
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org> To: axboe@kernel.dk, linux-kernel@vger.kernel.org, jeff@garzik.org, linux-ide@vger.kernel.org, James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org, bzolnier@gmail.com, petkovbb@googlemail.com, sshtylyov@ru.mvista.com, mike.miller@hp.com, Eric.Moore@lsi.com, stern@rowland.harvard.edu, fujita.tomonori@lab.ntt.co.jp, zaitcev@redhat.com, Geert.Uytterhoeven@sonycom.com, sfr@canb.auug.org.au, grant.likely@secretlab.ca, paul.clements@steeleye.com, tim@cyberelk.net, jeremy@xensource.com, adrian@mcmen.demon.co.uk, oakad@yahoo.com, dwmw2@infradead.org, schwidefsky@de.ibm.com, ballabio_dario@emc.com, davem@davemloft.net, rusty@rustcorp.com.au, Markus.Lidel@shadowconnect.com, bharrosh@panasas.com Cc: Tejun Heo <tj@kernel.org> Subject: [PATCH 01/11] nbd: don't clear rq->sector and nr_sectors unnecessarily Date: Mon, 4 May 2009 16:58:37 +0900 [thread overview] Message-ID: <1241423927-11871-2-git-send-email-tj@kernel.org> (raw) In-Reply-To: <1241423927-11871-1-git-send-email-tj@kernel.org> There's no reason to clear rq->sector and nr_sectors after calling blk_rq_init(). They're guaranteed to be clear. Drop unnecessary clearing. [ Impact: cleanup ] Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Paul Clements <paul.clements@steeleye.com> --- drivers/block/nbd.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 4d6de4f..a9ab8be 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -580,13 +580,6 @@ static int __nbd_ioctl(struct block_device *bdev, struct nbd_device *lo, blk_rq_init(NULL, &sreq); sreq.cmd_type = REQ_TYPE_SPECIAL; nbd_cmd(&sreq) = NBD_CMD_DISC; - /* - * Set these to sane values in case server implementation - * fails to check the request type first and also to keep - * debugging output cleaner. - */ - sreq.sector = 0; - sreq.nr_sectors = 0; if (!lo->sock) return -EINVAL; nbd_send_req(lo, &sreq); -- 1.6.0.2
next prev parent reply other threads:[~2009-05-04 7:58 UTC|newest] Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-05-04 7:58 [GIT PATCH] block,scsi,ide: unify sector and data_len, take#2 Tejun Heo 2009-05-04 7:58 ` Tejun Heo 2009-05-04 7:58 ` Tejun Heo [this message] 2009-05-04 7:58 ` [PATCH 01/11] nbd: don't clear rq->sector and nr_sectors unnecessarily Tejun Heo 2009-05-04 7:58 ` [PATCH 02/11] ide-tape: don't initialize rq->sector for rw requests Tejun Heo 2009-05-04 7:58 ` Tejun Heo 2009-05-04 7:58 ` [PATCH 03/11] block: add rq->resid_len Tejun Heo 2009-05-04 7:58 ` Tejun Heo 2009-05-04 12:08 ` Sergei Shtylyov 2009-05-05 3:41 ` Tejun Heo 2009-05-07 10:23 ` FUJITA Tomonori 2009-05-10 14:07 ` Boaz Harrosh 2009-05-10 23:48 ` Tejun Heo 2009-05-11 5:49 ` FUJITA Tomonori 2009-05-11 14:18 ` James Bottomley 2009-05-11 15:03 ` FUJITA Tomonori 2009-05-11 15:13 ` James Bottomley 2009-05-11 23:47 ` FUJITA Tomonori 2009-05-12 0:19 ` Tejun Heo 2009-05-12 3:43 ` James Bottomley 2009-05-12 6:04 ` Tejun Heo 2009-05-12 14:08 ` James Bottomley 2009-05-12 14:34 ` Alan Stern 2009-05-12 14:34 ` Alan Stern 2009-05-12 15:17 ` Tejun Heo 2009-05-12 15:45 ` James Bottomley 2009-05-13 6:30 ` Tejun Heo 2009-05-11 11:31 ` Boaz Harrosh 2009-05-11 14:59 ` FUJITA Tomonori 2009-05-12 8:58 ` Boaz Harrosh 2009-05-12 15:00 ` FUJITA Tomonori 2009-05-12 15:08 ` Boaz Harrosh 2009-05-12 15:16 ` FUJITA Tomonori 2009-05-12 0:27 ` Tejun Heo 2009-05-12 8:46 ` Boaz Harrosh 2009-05-12 9:07 ` Tejun Heo 2009-05-12 9:10 ` Tejun Heo 2009-05-12 9:52 ` Boaz Harrosh 2009-05-12 10:06 ` Tejun Heo 2009-05-12 11:08 ` Boaz Harrosh 2009-05-12 15:20 ` Tejun Heo 2009-05-12 15:53 ` Boaz Harrosh 2009-05-04 7:58 ` [PATCH 04/11] block: implement blk_rq_pos/[cur_]sectors() and convert obvious ones Tejun Heo 2009-05-04 7:58 ` Tejun Heo 2009-05-04 13:45 ` Sergei Shtylyov 2009-05-05 3:42 ` Tejun Heo 2009-05-04 7:58 ` [PATCH 05/11] block: convert to pos and nr_sectors accessors Tejun Heo 2009-05-04 7:58 ` Tejun Heo 2009-05-04 19:48 ` Adrian McMenamin 2009-05-05 3:42 ` Tejun Heo 2009-05-04 7:58 ` [PATCH 06/11] ide: convert to rq " Tejun Heo 2009-05-04 7:58 ` Tejun Heo 2009-05-04 7:58 ` [PATCH 07/11] block: drop request->hard_* and *nr_sectors Tejun Heo 2009-05-04 7:58 ` Tejun Heo 2009-05-04 7:58 ` [PATCH 08/11] block: cleanup rq->data_len usages Tejun Heo 2009-05-04 7:58 ` Tejun Heo 2009-05-04 14:41 ` Sergei Shtylyov 2009-05-11 12:02 ` Boaz Harrosh 2009-05-04 7:58 ` [PATCH 09/11] ide: " Tejun Heo 2009-05-04 7:58 ` Tejun Heo 2009-05-04 7:58 ` [PATCH 10/11] block: hide request sector and data_len Tejun Heo 2009-05-04 7:58 ` Tejun Heo 2009-05-04 7:58 ` [PATCH 11/11] block: blk_rq_[cur_]_{sectors|bytes}() usage cleanup Tejun Heo 2009-05-04 7:58 ` Tejun Heo 2009-05-05 3:59 ` [GIT PATCH] block,scsi,ide: unify sector and data_len, take#2 Tejun Heo 2009-05-05 3:59 ` Tejun Heo 2009-05-07 2:48 ` Tejun Heo 2009-05-07 2:48 ` Tejun Heo 2009-05-07 10:23 ` FUJITA Tomonori 2009-05-08 2:06 ` FUJITA Tomonori 2009-05-08 9:11 ` Tejun Heo 2009-05-11 12:06 ` Boaz Harrosh 2009-05-12 0:49 ` Tejun Heo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1241423927-11871-2-git-send-email-tj@kernel.org \ --to=tj@kernel.org \ --cc=James.Bottomley@HansenPartnership.com \ --cc=axboe@kernel.dk \ --cc=bzolnier@gmail.com \ --cc=jeff@garzik.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.