From: Bob Copeland <me@bobcopeland.com> To: linville@tuxdriver.com, jirislaby@gmail.com, mickflemm@gmail.com, lrodriguez@atheros.com Cc: linux-wireless@vger.kernel.org, ath5k-devel@lists.ath5k.org, ath9k-devel@lists.ath9k.org, Bob Copeland <me@bobcopeland.com> Subject: [PATCH 1/3] ath5k: don't reset mcast filter when configuring the mode Date: Sun, 8 Nov 2009 21:59:00 -0500 [thread overview] Message-ID: <1257735542-29658-1-git-send-email-me@bobcopeland.com> (raw) We should not zero out the multicast hash when configuring the operating mode, since a zero value means all multicast frames will get dropped. Also, ath5k_mode_setup() gets called after any reset, so the hash already set up in configure_filter() is lost. Signed-off-by: Bob Copeland <me@bobcopeland.com> --- drivers/net/wireless/ath/ath5k/base.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c index 07c1e52..cb3dc89 100644 --- a/drivers/net/wireless/ath/ath5k/base.c +++ b/drivers/net/wireless/ath/ath5k/base.c @@ -1146,7 +1146,6 @@ ath5k_mode_setup(struct ath5k_softc *sc) /* configure operational mode */ ath5k_hw_set_opmode(ah); - ath5k_hw_set_mcast_filter(ah, 0, 0); ATH5K_DBG(sc, ATH5K_DEBUG_MODE, "RX filter 0x%x\n", rfilt); } -- 1.6.2.5
WARNING: multiple messages have this Message-ID (diff)
From: Bob Copeland <me@bobcopeland.com> To: ath9k-devel@lists.ath9k.org Subject: [ath9k-devel] [PATCH 1/3] ath5k: don't reset mcast filter when configuring the mode Date: Sun, 8 Nov 2009 21:59:00 -0500 [thread overview] Message-ID: <1257735542-29658-1-git-send-email-me@bobcopeland.com> (raw) We should not zero out the multicast hash when configuring the operating mode, since a zero value means all multicast frames will get dropped. Also, ath5k_mode_setup() gets called after any reset, so the hash already set up in configure_filter() is lost. Signed-off-by: Bob Copeland <me@bobcopeland.com> --- drivers/net/wireless/ath/ath5k/base.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c index 07c1e52..cb3dc89 100644 --- a/drivers/net/wireless/ath/ath5k/base.c +++ b/drivers/net/wireless/ath/ath5k/base.c @@ -1146,7 +1146,6 @@ ath5k_mode_setup(struct ath5k_softc *sc) /* configure operational mode */ ath5k_hw_set_opmode(ah); - ath5k_hw_set_mcast_filter(ah, 0, 0); ATH5K_DBG(sc, ATH5K_DEBUG_MODE, "RX filter 0x%x\n", rfilt); } -- 1.6.2.5
next reply other threads:[~2009-11-09 3:00 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-11-09 2:59 Bob Copeland [this message] 2009-11-09 2:59 ` [ath9k-devel] [PATCH 1/3] ath5k: don't reset mcast filter when configuring the mode Bob Copeland 2009-11-09 2:59 ` [PATCH 2/3] ath5k: add LED support for HP Compaq CQ60 Bob Copeland 2009-11-09 2:59 ` [ath9k-devel] " Bob Copeland 2009-11-09 2:59 ` [PATCH 3/3] ath5k: add LED definition for BenQ Joybook R55v Bob Copeland 2009-11-09 2:59 ` [ath9k-devel] " Bob Copeland 2009-11-09 3:05 ` [PATCH 1/3] ath5k: don't reset mcast filter when configuring the mode Nick Kossifidis 2009-11-09 3:05 ` [ath9k-devel] " Nick Kossifidis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1257735542-29658-1-git-send-email-me@bobcopeland.com \ --to=me@bobcopeland.com \ --cc=ath5k-devel@lists.ath5k.org \ --cc=ath9k-devel@lists.ath9k.org \ --cc=jirislaby@gmail.com \ --cc=linux-wireless@vger.kernel.org \ --cc=linville@tuxdriver.com \ --cc=lrodriguez@atheros.com \ --cc=mickflemm@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.