All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Kossifidis <mickflemm@gmail.com>
To: Bob Copeland <me@bobcopeland.com>
Cc: linville@tuxdriver.com, jirislaby@gmail.com,
	lrodriguez@atheros.com, linux-wireless@vger.kernel.org,
	ath5k-devel@lists.ath5k.org, ath9k-devel@lists.ath9k.org
Subject: Re: [PATCH 1/3] ath5k: don't reset mcast filter when configuring the mode
Date: Mon, 9 Nov 2009 05:05:42 +0200	[thread overview]
Message-ID: <40f31dec0911081905o6425795fxb5a6a1ba25bdc7f5@mail.gmail.com> (raw)
In-Reply-To: <1257735542-29658-1-git-send-email-me@bobcopeland.com>

2009/11/9 Bob Copeland <me@bobcopeland.com>:
> We should not zero out the multicast hash when configuring
> the operating mode, since a zero value means all multicast
> frames will get dropped.  Also, ath5k_mode_setup() gets
> called after any reset, so the hash already set up in
> configure_filter() is lost.
>
> Signed-off-by: Bob Copeland <me@bobcopeland.com>
> ---
>  drivers/net/wireless/ath/ath5k/base.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
> index 07c1e52..cb3dc89 100644
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -1146,7 +1146,6 @@ ath5k_mode_setup(struct ath5k_softc *sc)
>        /* configure operational mode */
>        ath5k_hw_set_opmode(ah);
>
> -       ath5k_hw_set_mcast_filter(ah, 0, 0);
>        ATH5K_DBG(sc, ATH5K_DEBUG_MODE, "RX filter 0x%x\n", rfilt);
>  }
>

Acked-by: Nick Kossifidis <mickflemm@gmail.com>


-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick

WARNING: multiple messages have this Message-ID (diff)
From: Nick Kossifidis <mickflemm@gmail.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 1/3] ath5k: don't reset mcast filter when configuring the mode
Date: Mon, 9 Nov 2009 05:05:42 +0200	[thread overview]
Message-ID: <40f31dec0911081905o6425795fxb5a6a1ba25bdc7f5@mail.gmail.com> (raw)
In-Reply-To: <1257735542-29658-1-git-send-email-me@bobcopeland.com>

2009/11/9 Bob Copeland <me@bobcopeland.com>:
> We should not zero out the multicast hash when configuring
> the operating mode, since a zero value means all multicast
> frames will get dropped. ?Also, ath5k_mode_setup() gets
> called after any reset, so the hash already set up in
> configure_filter() is lost.
>
> Signed-off-by: Bob Copeland <me@bobcopeland.com>
> ---
> ?drivers/net/wireless/ath/ath5k/base.c | ? ?1 -
> ?1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
> index 07c1e52..cb3dc89 100644
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -1146,7 +1146,6 @@ ath5k_mode_setup(struct ath5k_softc *sc)
> ? ? ? ?/* configure operational mode */
> ? ? ? ?ath5k_hw_set_opmode(ah);
>
> - ? ? ? ath5k_hw_set_mcast_filter(ah, 0, 0);
> ? ? ? ?ATH5K_DBG(sc, ATH5K_DEBUG_MODE, "RX filter 0x%x\n", rfilt);
> ?}
>

Acked-by: Nick Kossifidis <mickflemm@gmail.com>


-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick

  parent reply	other threads:[~2009-11-09  3:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09  2:59 [PATCH 1/3] ath5k: don't reset mcast filter when configuring the mode Bob Copeland
2009-11-09  2:59 ` [ath9k-devel] " Bob Copeland
2009-11-09  2:59 ` [PATCH 2/3] ath5k: add LED support for HP Compaq CQ60 Bob Copeland
2009-11-09  2:59   ` [ath9k-devel] " Bob Copeland
2009-11-09  2:59 ` [PATCH 3/3] ath5k: add LED definition for BenQ Joybook R55v Bob Copeland
2009-11-09  2:59   ` [ath9k-devel] " Bob Copeland
2009-11-09  3:05 ` Nick Kossifidis [this message]
2009-11-09  3:05   ` [ath9k-devel] [PATCH 1/3] ath5k: don't reset mcast filter when configuring the mode Nick Kossifidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40f31dec0911081905o6425795fxb5a6a1ba25bdc7f5@mail.gmail.com \
    --to=mickflemm@gmail.com \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    --cc=me@bobcopeland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.