Re: [PATCH] perf: Fix bad software/trace event recursion counting

From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Paul Mackerras <paulus@samba.org>,
	Arjan van de Ven <arjan@infradead.org>,
	Li Zefan <lizf@cn.fujitsu.com>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] perf: Fix bad software/trace event recursion counting
Date: Tue, 24 Nov 2009 21:48:50 +0100	[thread overview]
Message-ID: <1259095730.4531.1791.camel@laptop> (raw)
In-Reply-To: <1259091502-5171-1-git-send-email-fweisbec@gmail.com>

On Tue, 2009-11-24 at 20:38 +0100, Frederic Weisbecker wrote:

> diff --git a/kernel/perf_event.c b/kernel/perf_event.c
> index accfd7b..35df94e 100644
> --- a/kernel/perf_event.c
> +++ b/kernel/perf_event.c
> @@ -3914,7 +3914,7 @@ void perf_swevent_put_recursion_context(int rctx)
>  {
>  	struct perf_cpu_context *cpuctx = &__get_cpu_var(perf_cpu_context);
>  	barrier();
> -	cpuctx->recursion[rctx]++;
> +	cpuctx->recursion[rctx]--;
>  	put_cpu_var(perf_cpu_context);
>  }

D'0h!