From: Johan Hovold <jhovold@gmail.com>
To: Dave Airlie <airlied@redhat.com>
Cc: James Simmons <jsimmons@infradead.org>,
dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [bisected] drm/ksm: fbdev blanking regression in 2.6.33
Date: Wed, 6 Jan 2010 18:00:25 +0100 [thread overview]
Message-ID: <1262797226-9593-1-git-send-email-jhovold@gmail.com> (raw)
Hi,
Console blanking broke on my laptop with GM45 chipset with 2.6.33. Instead of
blanking, the screen was dimmed and the backlight started glowing in the lower
edges of the screen. The glowing then slowly spread upwards. Did not look
healthy at all.
Easily reproduced by issuing "setterm -blank force".
I bisected it down to 731b5a15a3b1474a41c2ca29b4c32b0f21bc852e (drm/kms:
properly handle fbdev blanking). Which instead of going directly to
DPMS_STANDBY now calls the encoder dpms helper with DRM_MODE_DPMS_ON and the
crtc dpms helper with DRM_MODE_DPMS_OFF. I've verified that is this combination
that triggers the bug.
If I don't call crtc_funcs->dpms(crtc, DRM_MODE_DPMS_OFF) on FB_BLANK_NORMAL
but still encoder_funcs->dpms(encoder, DRM_MODE_DPMS_ON), the bug is not
triggered, but the screen is not cleared either.
For now, I simply reverted to the old behaviour of going directly to
DPMS_STANDBY (see follow-up patch).
Thanks,
Johan
Johan Hovold (1):
drm/kms: fix fbdev blanking regression
drivers/gpu/drm/drm_fb_helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
next reply other threads:[~2010-01-06 17:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 17:00 Johan Hovold [this message]
2010-01-06 17:00 ` [PATCH] drm/kms: fix fbdev blanking regression Johan Hovold
2010-01-06 17:33 ` James Simmons
2010-01-06 18:09 ` Johan Hovold
2010-01-06 18:18 ` James Simmons
2010-01-06 19:12 ` Johan Hovold
2010-01-07 6:41 ` David John
2010-01-12 17:28 ` James Simmons
2010-01-12 17:34 ` Jesse Barnes
2010-01-13 19:48 ` James Simmons
2010-01-13 20:01 ` Alex Deucher
2010-01-15 12:40 ` James Simmons
2010-01-15 13:10 ` Alan Cox
2010-01-16 16:02 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262797226-9593-1-git-send-email-jhovold@gmail.com \
--to=jhovold@gmail.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.