All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Simmons <jsimmons@infradead.org>
To: David John <davidjon@xenontk.org>
Cc: Johan Hovold <jhovold@gmail.com>,
	Dave Airlie <airlied@redhat.com>,
	dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	Eric Anholt <eric@anholt.net>,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/kms: fix fbdev blanking regression
Date: Tue, 12 Jan 2010 17:28:33 +0000 (GMT)	[thread overview]
Message-ID: <alpine.LFD.2.00.1001121645570.9778@casper.infradead.org> (raw)
In-Reply-To: <4B458209.2030600@xenontk.org>


> On 01/07/2010 12:42 AM, Johan Hovold wrote:
> >> Yeap. The fix uncovered a bug in your driver. I haven't heard of problems 
> >> with the other drm drivers.
> >>  
> >>> The backlight is handled via the DRI driver I assume. At least
> >>> i9xx_crtc_dpms is called on powerdown.
> >>
> >> Can you post your dmesg and kernel config.
> 
> [snip]
> 
> Adding the Intel DRM people in CC as well. I have the same issue with my
> GM45.

Okay I looked at the code to figure out what is happening and why only 
this driver has problems. The problem is that the framebuffer layer 
expects the backlight to be a seperate device. The reason being is that
some embedded systems will use a gpio backlight. That way power management 
for a graphics card/backlight has 3 seperate states. Currently the intel 
DRM driver treats the backlight as being apart of the encoder. Jesse do 
you have objections to having the intel driver expose a backlight device.
The bonus of that is the user can also set the backlight levels.

 

  reply	other threads:[~2010-01-12 17:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06 17:00 [bisected] drm/ksm: fbdev blanking regression in 2.6.33 Johan Hovold
2010-01-06 17:00 ` [PATCH] drm/kms: fix fbdev blanking regression Johan Hovold
2010-01-06 17:33   ` James Simmons
2010-01-06 18:09     ` Johan Hovold
2010-01-06 18:18       ` James Simmons
2010-01-06 19:12         ` Johan Hovold
2010-01-07  6:41           ` David John
2010-01-12 17:28             ` James Simmons [this message]
2010-01-12 17:34               ` Jesse Barnes
2010-01-13 19:48                 ` James Simmons
2010-01-13 20:01                   ` Alex Deucher
2010-01-15 12:40                     ` James Simmons
2010-01-15 13:10                       ` Alan Cox
2010-01-16 16:02                 ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1001121645570.9778@casper.infradead.org \
    --to=jsimmons@infradead.org \
    --cc=airlied@redhat.com \
    --cc=davidjon@xenontk.org \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=eric@anholt.net \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jhovold@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.