[PATCH] drm/kms: fix fbdev blanking regression

From: Johan Hovold <jhovold@gmail.com>
To: Dave Airlie <airlied@redhat.com>
Cc: James Simmons <jsimmons@infradead.org>,
	dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	Johan Hovold <jhovold@gmail.com>
Subject: [PATCH] drm/kms: fix fbdev blanking regression
Date: Wed,  6 Jan 2010 18:00:26 +0100	[thread overview]
Message-ID: <1262797226-9593-2-git-send-email-jhovold@gmail.com> (raw)
In-Reply-To: <1262797226-9593-1-git-send-email-jhovold@gmail.com>

Commit 731b5a15a3b1474a41c2ca29b4c32b0f21bc852e (drm/kms: properly
handle fbdev blanking) breaks console blanking on my laptop (GM45
chipset). Instead of blanking the screen, it is dimmed and then the
backlight starts "glowing" in the lower edges of the screen. The glowing
then slowly spreads upwards. Does not look healthy at all...

This patch reverts to the old behaviour of going directly to
DPMS_STANDBY.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
 drivers/gpu/drm/drm_fb_helper.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 1b49fa0..9008583 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -389,7 +389,7 @@ int drm_fb_helper_blank(int blank, struct fb_info *info)
 		break;
 	/* Display: Off; HSync: On, VSync: On */
 	case FB_BLANK_NORMAL:
-		drm_fb_helper_off(info, DRM_MODE_DPMS_ON);
+		drm_fb_helper_off(info, DRM_MODE_DPMS_STANDBY);
 		break;
 	/* Display: Off; HSync: Off, VSync: On */
 	case FB_BLANK_HSYNC_SUSPEND:
-- 
1.6.6

