[PATCH 8/9] KVM: PPC: Fix HID5 setting code

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
To: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: kvm-ppc <kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Benjamin Herrenschmidt
	<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Subject: [PATCH 8/9] KVM: PPC: Fix HID5 setting code
Date: Fri,  8 Jan 2010 02:58:08 +0100	[thread overview]
Message-ID: <1262915889-11526-9-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1262915889-11526-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>

The code to unset HID5.dcbz32 is broken.
This patch makes it do the right rotate magic.

Signed-off-by: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Reported-by: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
---
 arch/powerpc/kvm/book3s_64_interrupts.S |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_64_interrupts.S b/arch/powerpc/kvm/book3s_64_interrupts.S
index 33aef53..2ff0b21 100644
--- a/arch/powerpc/kvm/book3s_64_interrupts.S
+++ b/arch/powerpc/kvm/book3s_64_interrupts.S
@@ -177,8 +177,9 @@ kvmppc_handler_highmem:
 	rldicl.	r5, r5, 0, 63		/* CR = ((r5 & 1) == 0) */
 	beq	no_dcbz32_off
 
+	li	r4, 0
 	mfspr   r5,SPRN_HID5
-	rldimi  r5,r5,6,56
+	rldimi  r5,r4,6,56
 	mtspr   SPRN_HID5,r5
 
 no_dcbz32_off:
-- 
1.6.0.2

WARNING: multiple messages have this Message-ID (diff)

From: Alexander Graf <agraf@suse.de>
To: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: kvm-ppc <kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Benjamin Herrenschmidt
	<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Subject: [PATCH 8/9] KVM: PPC: Fix HID5 setting code
Date: Fri, 08 Jan 2010 01:58:08 +0000	[thread overview]
Message-ID: <1262915889-11526-9-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1262915889-11526-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>

The code to unset HID5.dcbz32 is broken.
This patch makes it do the right rotate magic.

Signed-off-by: Alexander Graf <agraf@suse.de>
Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 arch/powerpc/kvm/book3s_64_interrupts.S |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_64_interrupts.S b/arch/powerpc/kvm/book3s_64_interrupts.S
index 33aef53..2ff0b21 100644
--- a/arch/powerpc/kvm/book3s_64_interrupts.S
+++ b/arch/powerpc/kvm/book3s_64_interrupts.S
@@ -177,8 +177,9 @@ kvmppc_handler_highmem:
 	rldicl.	r5, r5, 0, 63		/* CR = ((r5 & 1) = 0) */
 	beq	no_dcbz32_off
 
+	li	r4, 0
 	mfspr   r5,SPRN_HID5
-	rldimi  r5,r5,6,56
+	rldimi  r5,r4,6,56
 	mtspr   SPRN_HID5,r5
 
 no_dcbz32_off:
-- 
1.6.0.2

next prev parent reply	other threads:[~2010-01-08  1:58 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-08  1:58 [PATCH 0/9] KVM: PPC: Reduce races, fix code Alexander Graf
2010-01-08  1:58 ` Alexander Graf
2010-01-08  1:58 ` [PATCH 2/9] KVM: PPC: Add helpers for CR, XER Alexander Graf
2010-01-08  1:58   ` Alexander Graf
2010-01-08  1:58 ` [PATCH 6/9] KVM: PPC: Call SLB patching code in interrupt safe manner Alexander Graf
2010-01-08  1:58   ` Alexander Graf
2010-01-08  1:58 ` [PATCH 7/9] KVM: PPC: Emulate trap SRR1 flags properly Alexander Graf
2010-01-08  1:58   ` Alexander Graf
2010-01-08 19:29   ` Hollis Blanchard
2010-01-08 19:29     ` Hollis Blanchard
2010-01-11  6:58     ` Liu Yu-B13201
2010-01-11  6:58       ` Liu Yu-B13201
     [not found]       ` <0A1FE637C2C7E148B9573BB60CC630E56C3F11-bKEhWGtIRUJ4Lp7cDGe+DVjVikpgYyvb5NbjCUgZEJk@public.gmane.org>
2010-01-12  0:08         ` Alexander Graf
2010-01-12  0:08           ` Alexander Graf
     [not found]           ` <375F3E96-79CD-4451-B984-7CC896C2FA5A-l3A5Bk7waGM@public.gmane.org>
2010-01-12  9:08             ` Liu Yu-B13201
2010-01-12  9:08               ` Liu Yu-B13201
     [not found]     ` <fb412d761001081129q26d7fdcj9d1a26184127d002-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-08 19:32       ` Alexander Graf
2010-01-08 19:32         ` Alexander Graf
     [not found]         ` <1FB2DDB0-F72E-437C-BEC5-8E1AEE5FBCC7-l3A5Bk7waGM@public.gmane.org>
2010-01-08 19:35           ` Hollis Blanchard
2010-01-08 19:35             ` Hollis Blanchard
2010-01-08 19:37             ` Alexander Graf
2010-01-08 19:37               ` Alexander Graf
2010-01-10 12:34               ` Avi Kivity
2010-01-10 12:34                 ` Avi Kivity
     [not found]                 ` <4B49C959.8040900-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-01-10 12:48                   ` Alexander Graf
2010-01-10 12:48                     ` Alexander Graf
2010-01-10 12:58                     ` Avi Kivity
2010-01-10 12:58                       ` Avi Kivity
2010-01-21  8:09       ` Liu Yu-B13201
2010-01-21  8:09         ` Liu Yu-B13201
2010-01-21 12:12         ` Alexander Graf
2010-01-21 12:12           ` Alexander Graf
     [not found] ` <1262915889-11526-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-01-08  1:58   ` [PATCH 1/9] KVM: PPC: Use accessor functions for GPR access Alexander Graf
2010-01-08  1:58     ` Alexander Graf
2010-01-08  1:58   ` [PATCH 3/9] KVM: PPC: Use PACA backed shadow vcpu Alexander Graf
2010-01-08  1:58     ` Alexander Graf
2010-01-08  1:58   ` [PATCH 4/9] KVM: PPC: Implement 'skip instruction' mode Alexander Graf
2010-01-08  1:58     ` Alexander Graf
2010-01-08  1:58   ` [PATCH 5/9] KVM: PPC: Get rid of unnecessary RFI Alexander Graf
2010-01-08  1:58     ` Alexander Graf
2010-01-08  1:58   ` Alexander Graf [this message]
2010-01-08  1:58     ` [PATCH 8/9] KVM: PPC: Fix HID5 setting code Alexander Graf
2010-01-08  1:58   ` [PATCH 9/9] KVM: PPC: Pass program interrupt flags to the guest Alexander Graf
2010-01-08  1:58     ` Alexander Graf

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:33aef53 dfblob:33aef53 dfblob:2ff0b21 dfblob:2ff0b21
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1262915889-11526-9-git-send-email-agraf@suse.de \
    --to=agraf-l3a5bk7wagm@public.gmane.org \
    --cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
    --cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.