All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexanders83@web.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: Re: [PATCH 2/2] pinctrl: at91: Add missing include
Date: Thu, 02 Apr 2015 11:39:48 +0200	[thread overview]
Message-ID: <12638259.j5S92pLO40@kongar> (raw)
In-Reply-To: <20150402081941.GB26864@ns203013.ovh.net>

On Thursday 02 April 2015, 10:19:41 wrote Jean-Christophe PLAGNIOL-VILLARD:
> On 20:12 Fri 20 Mar     , Alexander Stein wrote:
> > This fixes the sparse warning:
> > drivers/pinctrl/pinctrl-at91.c:1556:6: warning: symbol
> >  'at91_pinctrl_gpio_suspend' was not declared. Should it be static?
> > drivers/pinctrl/pinctrl-at91.c:1580:6: warning: symbol
> >  'at91_pinctrl_gpio_resume' was not declared. Should it be static?
> > 
> > Signed-off-by: Alexander Stein <alexanders83@web.de>
> > ---
> >  drivers/pinctrl/pinctrl-at91.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> > index a882523..02f6477 100644
> > --- a/drivers/pinctrl/pinctrl-at91.c
> > +++ b/drivers/pinctrl/pinctrl-at91.c
> > @@ -25,6 +25,8 @@
> >  /* Since we request GPIOs from ourself */
> >  #include <linux/pinctrl/consumer.h>
> >  
> > +#include <mach/hardware.h>
> NACK this will break multi arch support

Mh, i see. So I guess this sparse warning will stay there then.

Best regards,
Alexander


WARNING: multiple messages have this Message-ID (diff)
From: alexanders83@web.de (Alexander Stein)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] pinctrl: at91: Add missing include
Date: Thu, 02 Apr 2015 11:39:48 +0200	[thread overview]
Message-ID: <12638259.j5S92pLO40@kongar> (raw)
In-Reply-To: <20150402081941.GB26864@ns203013.ovh.net>

On Thursday 02 April 2015, 10:19:41 wrote Jean-Christophe PLAGNIOL-VILLARD:
> On 20:12 Fri 20 Mar     , Alexander Stein wrote:
> > This fixes the sparse warning:
> > drivers/pinctrl/pinctrl-at91.c:1556:6: warning: symbol
> >  'at91_pinctrl_gpio_suspend' was not declared. Should it be static?
> > drivers/pinctrl/pinctrl-at91.c:1580:6: warning: symbol
> >  'at91_pinctrl_gpio_resume' was not declared. Should it be static?
> > 
> > Signed-off-by: Alexander Stein <alexanders83@web.de>
> > ---
> >  drivers/pinctrl/pinctrl-at91.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> > index a882523..02f6477 100644
> > --- a/drivers/pinctrl/pinctrl-at91.c
> > +++ b/drivers/pinctrl/pinctrl-at91.c
> > @@ -25,6 +25,8 @@
> >  /* Since we request GPIOs from ourself */
> >  #include <linux/pinctrl/consumer.h>
> >  
> > +#include <mach/hardware.h>
> NACK this will break multi arch support

Mh, i see. So I guess this sparse warning will stay there then.

Best regards,
Alexander

  reply	other threads:[~2015-04-02  9:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 19:12 [PATCH 1/2] pinctrl: at91: Add set_multiple GPIO chip feature Alexander Stein
2015-03-20 19:12 ` Alexander Stein
2015-03-20 19:12 ` [PATCH 2/2] pinctrl: at91: Add missing include Alexander Stein
2015-03-20 19:12   ` Alexander Stein
2015-04-02  8:19   ` Jean-Christophe PLAGNIOL-VILLARD
2015-04-02  8:19     ` Jean-Christophe PLAGNIOL-VILLARD
2015-04-02  9:39     ` Alexander Stein [this message]
2015-04-02  9:39       ` Alexander Stein
2015-03-27  9:07 ` [PATCH 1/2] pinctrl: at91: Add set_multiple GPIO chip feature Linus Walleij
2015-03-27  9:07   ` Linus Walleij
2015-04-01  7:45   ` Jean-Christophe PLAGNIOL-VILLARD
2015-04-01  7:45     ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-27 10:11 ` Ludovic Desroches
2015-03-27 10:11   ` Ludovic Desroches
2015-03-27 11:54   ` Alexander Stein
2015-03-27 11:54     ` Alexander Stein
2015-04-02  8:30 ` Jean-Christophe PLAGNIOL-VILLARD
2015-04-02  8:30   ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12638259.j5S92pLO40@kongar \
    --to=alexanders83@web.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.