All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Alexander Stein <alexanders83@web.de>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 1/2] pinctrl: at91: Add set_multiple GPIO chip feature
Date: Fri, 27 Mar 2015 10:07:29 +0100	[thread overview]
Message-ID: <CACRpkdapp8vGFHJA+WrZzRk503zoAzrz3HaVGYXH+CHRDaLaDg@mail.gmail.com> (raw)
In-Reply-To: <1426878721-2618-1-git-send-email-alexanders83@web.de>

On Fri, Mar 20, 2015 at 8:12 PM, Alexander Stein <alexanders83@web.de> wrote:

> This adds the callback for set_multiple.
> As this controller has a separate set and clear register, we can't write
> directly to PIO_ODSR as this would required a cached variable and would
> race with at91_gpio_set.
> So build masks for the PIO_SODR and PIO_CODR registers and write them
> together.
>
> Signed-off-by: Alexander Stein <alexanders83@web.de>
> ---
> This was tested by using an own test driver which uses
> gpiod_set_array_cansleep to set multiple GPIOs at once.

I remember J-C brought this up ages ago, so I hope he will be delighted
to see we can now, FINALLY, do this!

J-C can I have your review on this?

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] pinctrl: at91: Add set_multiple GPIO chip feature
Date: Fri, 27 Mar 2015 10:07:29 +0100	[thread overview]
Message-ID: <CACRpkdapp8vGFHJA+WrZzRk503zoAzrz3HaVGYXH+CHRDaLaDg@mail.gmail.com> (raw)
In-Reply-To: <1426878721-2618-1-git-send-email-alexanders83@web.de>

On Fri, Mar 20, 2015 at 8:12 PM, Alexander Stein <alexanders83@web.de> wrote:

> This adds the callback for set_multiple.
> As this controller has a separate set and clear register, we can't write
> directly to PIO_ODSR as this would required a cached variable and would
> race with at91_gpio_set.
> So build masks for the PIO_SODR and PIO_CODR registers and write them
> together.
>
> Signed-off-by: Alexander Stein <alexanders83@web.de>
> ---
> This was tested by using an own test driver which uses
> gpiod_set_array_cansleep to set multiple GPIOs at once.

I remember J-C brought this up ages ago, so I hope he will be delighted
to see we can now, FINALLY, do this!

J-C can I have your review on this?

Yours,
Linus Walleij

  parent reply	other threads:[~2015-03-27  9:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 19:12 [PATCH 1/2] pinctrl: at91: Add set_multiple GPIO chip feature Alexander Stein
2015-03-20 19:12 ` Alexander Stein
2015-03-20 19:12 ` [PATCH 2/2] pinctrl: at91: Add missing include Alexander Stein
2015-03-20 19:12   ` Alexander Stein
2015-04-02  8:19   ` Jean-Christophe PLAGNIOL-VILLARD
2015-04-02  8:19     ` Jean-Christophe PLAGNIOL-VILLARD
2015-04-02  9:39     ` Alexander Stein
2015-04-02  9:39       ` Alexander Stein
2015-03-27  9:07 ` Linus Walleij [this message]
2015-03-27  9:07   ` [PATCH 1/2] pinctrl: at91: Add set_multiple GPIO chip feature Linus Walleij
2015-04-01  7:45   ` Jean-Christophe PLAGNIOL-VILLARD
2015-04-01  7:45     ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-27 10:11 ` Ludovic Desroches
2015-03-27 10:11   ` Ludovic Desroches
2015-03-27 11:54   ` Alexander Stein
2015-03-27 11:54     ` Alexander Stein
2015-04-02  8:30 ` Jean-Christophe PLAGNIOL-VILLARD
2015-04-02  8:30   ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdapp8vGFHJA+WrZzRk503zoAzrz3HaVGYXH+CHRDaLaDg@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=alexanders83@web.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.