From: "Fenghua Yu" <fenghua.yu@intel.com> To: "Rudolf Marek" <r.marek@assembler.cz>, "Huaxu Wan" <huaxu.wan@intel.com>, "H Peter Anvin" <hpa@zytor.com>, "Chen Gong" <gong.chen@linux.intel.com>, "Jean Delvare" <khali@linux-fr.org> Cc: "linux-kernel" <linux-kernel@vger.kernel.org>, "lm-sensors" <lm-sensors@lm-sensors.org>, Fenghua Yu <fenghua.yu@intel.com> Subject: [PATCH] drivers/hwmon/coretemp: Fix incorrect hot-removed CPU's core sensor issue Date: Wed, 18 Aug 2010 15:53:45 -0700 [thread overview] Message-ID: <1282172027-640-1-git-send-email-fenghua.yu@intel.com> (raw) From: Fenghua Yu <fenghua.yu@intel.com> In current coretemp driver, when a CPU in dev_list is hot-removed, although its HT sibling is still running, its core sensor is gone and not available to user level application any more. When a CPU is hot-removed, its core sensor should be still available to upper level application as long as the hot-removed CPU's HT sibling is still running. A core sensor is invisible to user level only when all of siblings in a core are hot-removed. This patch fixes this issue. Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> --- drivers/hwmon/coretemp.c | 25 ++++++++++++++++++++++--- 1 files changed, 22 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c index c070c97..2257cc4 100644 --- a/drivers/hwmon/coretemp.c +++ b/drivers/hwmon/coretemp.c @@ -418,7 +418,7 @@ struct pdev_entry { static LIST_HEAD(pdev_list); static DEFINE_MUTEX(pdev_list_mutex); -static int __cpuinit coretemp_device_add(unsigned int cpu) +static int coretemp_device_add(unsigned int cpu) { int err; struct platform_device *pdev; @@ -483,15 +483,34 @@ exit: static void coretemp_device_remove(unsigned int cpu) { struct pdev_entry *p, *n; - mutex_lock(&pdev_list_mutex); +#ifdef CONFIG_SMP + int s; +#endif + list_for_each_entry_safe(p, n, &pdev_list, list) { if (p->cpu == cpu) { + mutex_lock(&pdev_list_mutex); platform_device_unregister(p->pdev); list_del(&p->list); kfree(p); + mutex_unlock(&pdev_list_mutex); + +#ifdef CONFIG_SMP + /* + * Add removed CPU's HT sibling to dev_list. + * If there is no sibling available, the core sensor + * is invisiable to user space any more. + */ + for_each_cpu(s, cpu_sibling_mask(cpu)) { + if (s != cpu) { + coretemp_device_add(s); + break; + } + } +#endif + return; } } - mutex_unlock(&pdev_list_mutex); } static int __cpuinit coretemp_cpu_callback(struct notifier_block *nfb, -- 1.6.0.3
WARNING: multiple messages have this Message-ID (diff)
From: "Fenghua Yu" <fenghua.yu@intel.com> To: Rudolf Marek <r.marek@assembler.cz>, Huaxu Wan <huaxu.wan@intel.com>, H Peter Anvin <hpa@zytor.com>, Chen Gong <gong.chen@linux.intel.com>, Jean Delvare <khali@linux-fr.org> Cc: linux-kernel <linux-kernel@vger.kernel.org>, lm-sensors <lm-sensors@lm-sensors.org>, Fenghua Yu <fenghua.yu@intel.com> Subject: [lm-sensors] [PATCH] drivers/hwmon/coretemp: Fix incorrect Date: Wed, 18 Aug 2010 22:53:45 +0000 [thread overview] Message-ID: <1282172027-640-1-git-send-email-fenghua.yu@intel.com> (raw) From: Fenghua Yu <fenghua.yu@intel.com> In current coretemp driver, when a CPU in dev_list is hot-removed, although its HT sibling is still running, its core sensor is gone and not available to user level application any more. When a CPU is hot-removed, its core sensor should be still available to upper level application as long as the hot-removed CPU's HT sibling is still running. A core sensor is invisible to user level only when all of siblings in a core are hot-removed. This patch fixes this issue. Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> --- drivers/hwmon/coretemp.c | 25 ++++++++++++++++++++++--- 1 files changed, 22 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c index c070c97..2257cc4 100644 --- a/drivers/hwmon/coretemp.c +++ b/drivers/hwmon/coretemp.c @@ -418,7 +418,7 @@ struct pdev_entry { static LIST_HEAD(pdev_list); static DEFINE_MUTEX(pdev_list_mutex); -static int __cpuinit coretemp_device_add(unsigned int cpu) +static int coretemp_device_add(unsigned int cpu) { int err; struct platform_device *pdev; @@ -483,15 +483,34 @@ exit: static void coretemp_device_remove(unsigned int cpu) { struct pdev_entry *p, *n; - mutex_lock(&pdev_list_mutex); +#ifdef CONFIG_SMP + int s; +#endif + list_for_each_entry_safe(p, n, &pdev_list, list) { if (p->cpu = cpu) { + mutex_lock(&pdev_list_mutex); platform_device_unregister(p->pdev); list_del(&p->list); kfree(p); + mutex_unlock(&pdev_list_mutex); + +#ifdef CONFIG_SMP + /* + * Add removed CPU's HT sibling to dev_list. + * If there is no sibling available, the core sensor + * is invisiable to user space any more. + */ + for_each_cpu(s, cpu_sibling_mask(cpu)) { + if (s != cpu) { + coretemp_device_add(s); + break; + } + } +#endif + return; } } - mutex_unlock(&pdev_list_mutex); } static int __cpuinit coretemp_cpu_callback(struct notifier_block *nfb, -- 1.6.0.3 _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next reply other threads:[~2010-08-18 23:02 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-08-18 22:53 Fenghua Yu [this message] 2010-08-18 22:53 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Fix incorrect Fenghua Yu 2010-08-18 22:53 ` [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Fenghua Yu 2010-08-18 22:53 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Fenghua Yu 2010-08-19 7:24 ` [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Jean Delvare 2010-08-19 7:24 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Jean Delvare 2010-08-19 19:04 ` [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables H. Peter Anvin 2010-08-19 19:04 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of H. Peter Anvin 2010-08-19 21:26 ` [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Jean Delvare 2010-08-19 21:26 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Jean Delvare 2010-08-19 21:28 ` [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables H. Peter Anvin 2010-08-19 21:28 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of H. Peter Anvin 2010-08-19 21:32 ` [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Jean Delvare 2010-08-19 21:32 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Jean Delvare 2010-08-19 21:51 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Guenter Roeck 2010-08-19 21:51 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Guenter Roeck 2010-09-04 12:39 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Jean Delvare 2010-09-04 12:39 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Jean Delvare 2010-09-04 14:30 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Guenter Roeck 2010-09-04 14:30 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Guenter Roeck 2010-09-04 16:17 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Jean Delvare 2010-09-04 16:17 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Jean Delvare 2010-08-18 22:53 ` [PATCH] drivers/hwmon/pkgtemp: Fix improper locking in CPU hot remove Fenghua Yu 2010-08-18 22:53 ` [lm-sensors] [PATCH] drivers/hwmon/pkgtemp: Fix improper locking in Fenghua Yu 2010-08-19 17:07 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Fix incorrect hot-removed CPU's core sensor issue Guenter Roeck 2010-08-19 17:07 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Fix incorrect Guenter Roeck 2010-08-20 8:26 ` [PATCH] drivers/hwmon/coretemp: Fix incorrect hot-removed CPU's core sensor issue Jean Delvare 2010-08-20 8:26 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Fix incorrect Jean Delvare 2010-08-20 21:53 ` [PATCH] drivers/hwmon/coretemp: Fix incorrect hot-removed CPU's core sensor issue Fenghua Yu 2010-08-20 21:53 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Fix incorrect Fenghua Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1282172027-640-1-git-send-email-fenghua.yu@intel.com \ --to=fenghua.yu@intel.com \ --cc=gong.chen@linux.intel.com \ --cc=hpa@zytor.com \ --cc=huaxu.wan@intel.com \ --cc=khali@linux-fr.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lm-sensors@lm-sensors.org \ --cc=r.marek@assembler.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.