All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Rudolf Marek <r.marek@assembler.cz>,
	Huaxu Wan <huaxu.wan@intel.com>, H Peter Anvin <hpa@zytor.com>,
	Chen Gong <gong.chen@linux.intel.com>,
	Jean Delvare <khali@linux-fr.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	lm-sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH] drivers/hwmon/coretemp: Fix incorrect hot-removed CPU's core sensor issue
Date: Thu, 19 Aug 2010 10:07:17 -0700	[thread overview]
Message-ID: <20100819170717.GA4312@ericsson.com> (raw)
In-Reply-To: <1282172027-640-1-git-send-email-fenghua.yu@intel.com>

On Wed, Aug 18, 2010 at 06:53:45PM -0400, Fenghua Yu wrote:
> From: Fenghua Yu <fenghua.yu@intel.com>
> 
> In current coretemp driver, when a CPU in dev_list is hot-removed, although its
> HT sibling is still running, its core sensor is gone and not available to user
> level application any more.
> 
> When a CPU is hot-removed, its core sensor should be still available to upper
> level application as long as the hot-removed CPU's HT sibling is still running.
> A core sensor is invisible to user level only when all of siblings in a core are
> hot-removed.
>
Isn't that just a short term (ie a couple of ms or even us) race condition
until the sibling is removed as well ? If so, why bother ?

Thanks,
Guenter


WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Rudolf Marek <r.marek@assembler.cz>,
	Huaxu Wan <huaxu.wan@intel.com>, H Peter Anvin <hpa@zytor.com>,
	Chen Gong <gong.chen@linux.intel.com>,
	Jean Delvare <khali@linux-fr.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	lm-sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH] drivers/hwmon/coretemp: Fix incorrect
Date: Thu, 19 Aug 2010 17:07:17 +0000	[thread overview]
Message-ID: <20100819170717.GA4312@ericsson.com> (raw)
In-Reply-To: <1282172027-640-1-git-send-email-fenghua.yu@intel.com>

On Wed, Aug 18, 2010 at 06:53:45PM -0400, Fenghua Yu wrote:
> From: Fenghua Yu <fenghua.yu@intel.com>
> 
> In current coretemp driver, when a CPU in dev_list is hot-removed, although its
> HT sibling is still running, its core sensor is gone and not available to user
> level application any more.
> 
> When a CPU is hot-removed, its core sensor should be still available to upper
> level application as long as the hot-removed CPU's HT sibling is still running.
> A core sensor is invisible to user level only when all of siblings in a core are
> hot-removed.
>
Isn't that just a short term (ie a couple of ms or even us) race condition
until the sibling is removed as well ? If so, why bother ?

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2010-08-19 17:08 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18 22:53 [PATCH] drivers/hwmon/coretemp: Fix incorrect hot-removed CPU's core sensor issue Fenghua Yu
2010-08-18 22:53 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Fix incorrect Fenghua Yu
2010-08-18 22:53 ` [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Fenghua Yu
2010-08-18 22:53   ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Fenghua Yu
2010-08-19  7:24   ` [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Jean Delvare
2010-08-19  7:24     ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Jean Delvare
2010-08-19 19:04     ` [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables H. Peter Anvin
2010-08-19 19:04       ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of H. Peter Anvin
2010-08-19 21:26       ` [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Jean Delvare
2010-08-19 21:26         ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Jean Delvare
2010-08-19 21:28         ` [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables H. Peter Anvin
2010-08-19 21:28           ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of H. Peter Anvin
2010-08-19 21:32           ` [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Jean Delvare
2010-08-19 21:32             ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Jean Delvare
2010-08-19 21:51         ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Guenter Roeck
2010-08-19 21:51           ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Guenter Roeck
2010-09-04 12:39           ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Jean Delvare
2010-09-04 12:39             ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Jean Delvare
2010-09-04 14:30             ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Guenter Roeck
2010-09-04 14:30               ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Guenter Roeck
2010-09-04 16:17               ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Jean Delvare
2010-09-04 16:17                 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Remove warnings of Jean Delvare
2010-08-18 22:53 ` [PATCH] drivers/hwmon/pkgtemp: Fix improper locking in CPU hot remove Fenghua Yu
2010-08-18 22:53   ` [lm-sensors] [PATCH] drivers/hwmon/pkgtemp: Fix improper locking in Fenghua Yu
2010-08-19 17:07 ` Guenter Roeck [this message]
2010-08-19 17:07   ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Fix incorrect Guenter Roeck
2010-08-20  8:26 ` [PATCH] drivers/hwmon/coretemp: Fix incorrect hot-removed CPU's core sensor issue Jean Delvare
2010-08-20  8:26   ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Fix incorrect Jean Delvare
2010-08-20 21:53   ` [PATCH] drivers/hwmon/coretemp: Fix incorrect hot-removed CPU's core sensor issue Fenghua Yu
2010-08-20 21:53     ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Fix incorrect Fenghua Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100819170717.GA4312@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=fenghua.yu@intel.com \
    --cc=gong.chen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=huaxu.wan@intel.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=r.marek@assembler.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.