* [PATCH 1/1] OMAP: DSS2: Add NEC NL8048HL11-01B display panel
@ 2010-10-14 11:25 Samreen
2010-10-20 12:27 ` Hiremath, Vaibhav
0 siblings, 1 reply; 3+ messages in thread
From: Samreen @ 2010-10-14 11:25 UTC (permalink / raw)
To: linux-omap
Cc: Erik Gilling, Subbu Venkatesh, Mukund Mittal, Rajkumar N, Samreen
From: Erik Gilling <konkers@android.com>
NEC WVGA LCD NL8048HL11-01B panel support has been added.
This panel is being used in zoom2/zoom3/3630 sdp boards.
Signed-off-by: Mukund Mittal <mmittal@ti.com>
Signed-off-by: Rajkumar N <rajkumar.nagarajan@ti.com>
Signed-off-by: Samreen <samreen@ti.com>
CC: Subbu Venkatesh <subramani.venkatesh@windriver.com>
CC: Erik Gilling <konkers@android.com>
---
This panel driver has orginated from panel-zoom2 from the L25.x
releases.Refer Commit:
http://git.omapzoom.org/?p=kernel/omap.git;a=commit;h=75fc121865125d9e3ca3b36f1f19f86b394e1f6b
drivers/video/omap2/displays/Kconfig | 7 +
drivers/video/omap2/displays/Makefile | 1 +
.../omap2/displays/panel-nec-nl8048hl11-01b.c | 381 ++++++++++++++++++++
3 files changed, 389 insertions(+), 0 deletions(-)
create mode 100644 drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
diff --git a/drivers/video/omap2/displays/Kconfig b/drivers/video/omap2/displays/Kconfig
index 12327bb..f8152cf 100644
--- a/drivers/video/omap2/displays/Kconfig
+++ b/drivers/video/omap2/displays/Kconfig
@@ -20,6 +20,13 @@ config PANEL_SHARP_LQ043T1DG01
help
LCD Panel used in TI's OMAP3517 EVM boards
+config PANEL_NEC_NL8048HL11_01B
+ tristate "NEC NL8048HL11-01B Panel"
+ depends on OMAP2_DSS
+ help
+ This NEC NL8048HL11-01B panel is TFT LCD
+ used in the Zoom2/3/3630 sdp boards.
+
config PANEL_TAAL
tristate "Taal DSI Panel"
depends on OMAP2_DSS_DSI
diff --git a/drivers/video/omap2/displays/Makefile b/drivers/video/omap2/displays/Makefile
index aa38609..8ece91c 100644
--- a/drivers/video/omap2/displays/Makefile
+++ b/drivers/video/omap2/displays/Makefile
@@ -1,6 +1,7 @@
obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
+obj-$(CONFIG_PANEL_NEC_NL8048HL11_01B) += panel-nec-nl8048hl11-01b.o
obj-$(CONFIG_PANEL_TAAL) += panel-taal.o
obj-$(CONFIG_PANEL_TOPPOLY_TDO35S) += panel-toppoly-tdo35s.o
diff --git a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
new file mode 100644
index 0000000..cdc0d8f
--- /dev/null
+++ b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
@@ -0,0 +1,381 @@
+/*
+ * Support for NEC-nl8048hl11-01b panel driver
+ *
+ * Copyright (C) 2010 Texas Instruments Inc.
+ * Author: Erik Gilling <konkers@android.com>
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <linux/module.h>
+#include <linux/delay.h>
+#include <linux/spi/spi.h>
+#include <plat/display.h>
+#include <linux/backlight.h>
+#include <linux/fb.h>
+
+#define LCD_XRES 800
+#define LCD_YRES 480
+/*
+ * NEC PIX Clock Ratings
+ * MIN:21.8MHz TYP:23.8MHz MAX:25.7MHz
+ */
+#define LCD_PIXEL_CLOCK 23800
+
+struct nec_8048_data {
+ struct backlight_device *bl;
+};
+
+/*
+ * NEC NL8048HL11-01B Manual
+ * defines HFB, HSW, HBP, VFP, VSW, VBP as shown below
+ */
+
+static struct omap_video_timings nec_8048_panel_timings = {
+ /* 800 x 480 @ 60 Hz Reduced blanking VESA CVT 0.31M3-R */
+ .x_res = LCD_XRES,
+ .y_res = LCD_YRES,
+ .pixel_clock = LCD_PIXEL_CLOCK,
+ .hfp = 6,
+ .hsw = 1,
+ .hbp = 4,
+ .vfp = 3,
+ .vsw = 1,
+ .vbp = 4,
+};
+
+static int nec_8048_bl_update_status(struct backlight_device *bl)
+{
+ struct omap_dss_device *dssdev = dev_get_drvdata(&bl->dev);
+ int level;
+
+ if (!dssdev->set_backlight)
+ return -EINVAL;
+
+ if (bl->props.fb_blank == FB_BLANK_UNBLANK &&
+ bl->props.power == FB_BLANK_UNBLANK)
+ level = bl->props.brightness;
+ else
+ level = 0;
+
+ return dssdev->set_backlight(dssdev, level);
+}
+
+static int nec_8048_bl_get_brightness(struct backlight_device *bl)
+{
+ if (bl->props.fb_blank == FB_BLANK_UNBLANK &&
+ bl->props.power == FB_BLANK_UNBLANK)
+ return bl->props.brightness;
+
+ return 0;
+}
+
+static const struct backlight_ops nec_8048_bl_ops = {
+ .get_brightness = nec_8048_bl_get_brightness,
+ .update_status = nec_8048_bl_update_status,
+};
+
+static int nec_8048_panel_probe(struct omap_dss_device *dssdev)
+{
+ struct backlight_device *bl;
+ struct nec_8048_data *necd;
+ struct backlight_properties props;
+ int r;
+
+ dssdev->panel.config = OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
+ OMAP_DSS_LCD_IHS | OMAP_DSS_LCD_RF |
+ OMAP_DSS_LCD_ONOFF;
+ dssdev->panel.timings = nec_8048_panel_timings;
+
+ necd = kzalloc(sizeof(*necd), GFP_KERNEL);
+ if (!necd)
+ return -ENOMEM;
+
+ dev_set_drvdata(&dssdev->dev, necd);
+
+ memset(&props, 0, sizeof(struct backlight_properties));
+ props.max_brightness = 255;
+
+ bl = backlight_device_register("nec-8048", &dssdev->dev, dssdev,
+ &nec_8048_bl_ops, &props);
+ if (IS_ERR(bl)) {
+ r = PTR_ERR(bl);
+ kfree(necd);
+ return r;
+ }
+ necd->bl = bl;
+
+ bl->props.fb_blank = FB_BLANK_UNBLANK;
+ bl->props.power = FB_BLANK_UNBLANK;
+ bl->props.max_brightness = dssdev->max_backlight_level;
+ bl->props.brightness = 0;
+
+ r = nec_8048_bl_update_status(bl);
+ if (r < 0)
+ dev_err(&dssdev->dev, "failed to set lcd brightness\n");
+
+ return 0;
+}
+
+static void nec_8048_panel_remove(struct omap_dss_device *dssdev)
+{
+ struct nec_8048_data *necd = dev_get_drvdata(&dssdev->dev);
+ struct backlight_device *bl = necd->bl;
+
+ bl->props.power = FB_BLANK_POWERDOWN;
+ nec_8048_bl_update_status(bl);
+ backlight_device_unregister(bl);
+
+ kfree(necd);
+}
+
+static int nec_8048_panel_enable(struct omap_dss_device *dssdev)
+{
+ int r = 0;
+ struct nec_8048_data *necd = dev_get_drvdata(&dssdev->dev);
+ struct backlight_device *bl = necd->bl;
+
+ if (dssdev->platform_enable) {
+ r = dssdev->platform_enable(dssdev);
+ if (r)
+ return r;
+ }
+
+ bl->props.brightness = dssdev->max_backlight_level;
+ r = nec_8048_bl_update_status(bl);
+ if (r < 0)
+ dev_err(&dssdev->dev, "failed to set lcd brightness\n");
+
+ omapdss_dpi_display_enable(dssdev);
+
+ return 0;
+}
+
+static void nec_8048_panel_disable(struct omap_dss_device *dssdev)
+{
+ struct nec_8048_data *necd = dev_get_drvdata(&dssdev->dev);
+ struct backlight_device *bl = necd->bl;
+
+ omapdss_dpi_display_disable(dssdev);
+
+ bl->props.brightness = 0;
+ nec_8048_bl_update_status(bl);
+
+ if (dssdev->platform_disable)
+ dssdev->platform_disable(dssdev);
+}
+
+static int nec_8048_panel_suspend(struct omap_dss_device *dssdev)
+{
+ nec_8048_panel_disable(dssdev);
+ return 0;
+}
+
+static int nec_8048_panel_resume(struct omap_dss_device *dssdev)
+{
+ return nec_8048_panel_enable(dssdev);
+}
+
+static int nec_8048_recommended_bpp(struct omap_dss_device *dssdev)
+{
+ return 16;
+}
+
+static struct omap_dss_driver nec_8048_driver = {
+ .probe = nec_8048_panel_probe,
+ .remove = nec_8048_panel_remove,
+ .enable = nec_8048_panel_enable,
+ .disable = nec_8048_panel_disable,
+ .suspend = nec_8048_panel_suspend,
+ .resume = nec_8048_panel_resume,
+ .get_recommended_bpp = nec_8048_recommended_bpp,
+
+ .driver = {
+ .name = "NEC_8048_panel",
+ .owner = THIS_MODULE,
+ },
+};
+
+static int spi_send(struct spi_device *spi, unsigned char reg_addr,
+ unsigned char reg_data)
+{
+ int ret = 0;
+ unsigned int cmd = 0, data = 0;
+
+ cmd = 0x0000 | reg_addr; /* register address write */
+ data = 0x0100 | reg_data ; /* register data write */
+ data = (cmd << 16) | data;
+
+ ret = spi_write(spi, (unsigned char *)&data, 4);
+ if (ret) {
+ pr_err("error in spi_write %x\n", data);
+ return ret;
+ }
+
+ return 0;
+}
+
+
+static int init_nec_8048_wvga_lcd(struct spi_device *spi)
+{
+ /* Initialization Sequence */
+ /* spi_send(spi, REG, VAL) */
+ spi_send(spi, 3, 0x01);
+ spi_send(spi, 0, 0x00);
+ spi_send(spi, 1, 0x01); /* R1 = 0x01 (normal), 0x03 (reversed) */
+ spi_send(spi, 4, 0x00);
+ spi_send(spi, 5, 0x14);
+ spi_send(spi, 6, 0x24);
+ spi_send(spi, 16, 0xD7);
+ spi_send(spi, 17, 0x00);
+ spi_send(spi, 18, 0x00);
+ spi_send(spi, 19, 0x55);
+ spi_send(spi, 20, 0x01);
+ spi_send(spi, 21, 0x70);
+ spi_send(spi, 22, 0x1E);
+ spi_send(spi, 23, 0x25);
+ spi_send(spi, 24, 0x25);
+ spi_send(spi, 25, 0x02);
+ spi_send(spi, 26, 0x02);
+ spi_send(spi, 27, 0xA0);
+ spi_send(spi, 32, 0x2F);
+ spi_send(spi, 33, 0x0F);
+ spi_send(spi, 34, 0x0F);
+ spi_send(spi, 35, 0x0F);
+ spi_send(spi, 36, 0x0F);
+ spi_send(spi, 37, 0x0F);
+ spi_send(spi, 38, 0x0F);
+ spi_send(spi, 39, 0x00);
+ spi_send(spi, 40, 0x02);
+ spi_send(spi, 41, 0x02);
+ spi_send(spi, 42, 0x02);
+ spi_send(spi, 43, 0x0F);
+ spi_send(spi, 44, 0x0F);
+ spi_send(spi, 45, 0x0F);
+ spi_send(spi, 46, 0x0F);
+ spi_send(spi, 47, 0x0F);
+ spi_send(spi, 48, 0x0F);
+ spi_send(spi, 49, 0x0F);
+ spi_send(spi, 50, 0x00);
+ spi_send(spi, 51, 0x02);
+ spi_send(spi, 52, 0x02);
+ spi_send(spi, 53, 0x02);
+ spi_send(spi, 80, 0x0C);
+ spi_send(spi, 83, 0x42);
+ spi_send(spi, 84, 0x42);
+ spi_send(spi, 85, 0x41);
+ spi_send(spi, 86, 0x14);
+ spi_send(spi, 89, 0x88);
+ spi_send(spi, 90, 0x01);
+ spi_send(spi, 91, 0x00);
+ spi_send(spi, 92, 0x02);
+ spi_send(spi, 93, 0x0C);
+ spi_send(spi, 94, 0x1C);
+ spi_send(spi, 95, 0x27);
+ spi_send(spi, 98, 0x49);
+ spi_send(spi, 99, 0x27);
+ spi_send(spi, 102, 0x76);
+ spi_send(spi, 103, 0x27);
+ spi_send(spi, 112, 0x01);
+ spi_send(spi, 113, 0x0E);
+ spi_send(spi, 114, 0x02);
+ spi_send(spi, 115, 0x0C);
+ spi_send(spi, 118, 0x0C);
+ spi_send(spi, 121, 0x30); /* R121 = 0x30 (normal), 0x10 (reversed) */
+ spi_send(spi, 130, 0x00);
+ spi_send(spi, 131, 0x00);
+ spi_send(spi, 132, 0xFC);
+ spi_send(spi, 134, 0x00);
+ spi_send(spi, 136, 0x00);
+ spi_send(spi, 138, 0x00);
+ spi_send(spi, 139, 0x00);
+ spi_send(spi, 140, 0x00);
+ spi_send(spi, 141, 0xFC);
+ spi_send(spi, 143, 0x00);
+ spi_send(spi, 145, 0x00);
+ spi_send(spi, 147, 0x00);
+ spi_send(spi, 148, 0x00);
+ spi_send(spi, 149, 0x00);
+ spi_send(spi, 150, 0xFC);
+ spi_send(spi, 152, 0x00);
+ spi_send(spi, 154, 0x00);
+ spi_send(spi, 156, 0x00);
+ spi_send(spi, 157, 0x00);
+ udelay(20);
+ spi_send(spi, 2, 0x00);
+
+ return 0;
+}
+
+static int nec_8048_spi_probe(struct spi_device *spi)
+{
+ spi->mode = SPI_MODE_0;
+ spi->bits_per_word = 32;
+ spi_setup(spi);
+
+ init_nec_8048_wvga_lcd(spi);
+
+ return omap_dss_register_driver(&nec_8048_driver);
+}
+
+static int nec_8048_spi_remove(struct spi_device *spi)
+{
+ omap_dss_unregister_driver(&nec_8048_driver);
+
+ return 0;
+}
+
+static int nec_8048_spi_suspend(struct spi_device *spi, pm_message_t mesg)
+{
+ spi_send(spi, 2, 0x01);
+ mdelay(40);
+
+ return 0;
+}
+
+static int nec_8048_spi_resume(struct spi_device *spi)
+{
+ /* reinitialize the panel */
+ spi_setup(spi);
+ spi_send(spi, 2, 0x00);
+ init_nec_8048_wvga_lcd(spi);
+
+ return 0;
+}
+
+static struct spi_driver nec_8048_spi_driver = {
+ .probe = nec_8048_spi_probe,
+ .remove = __devexit_p(nec_8048_spi_remove),
+ .suspend = nec_8048_spi_suspend,
+ .resume = nec_8048_spi_resume,
+ .driver = {
+ .name = "nec_8048_spi",
+ .bus = &spi_bus_type,
+ .owner = THIS_MODULE,
+ },
+};
+
+static int __init nec_8048_lcd_init(void)
+{
+ return spi_register_driver(&nec_8048_spi_driver);
+}
+
+static void __exit nec_8048_lcd_exit(void)
+{
+ return spi_unregister_driver(&nec_8048_spi_driver);
+}
+
+module_init(nec_8048_lcd_init);
+module_exit(nec_8048_lcd_exit);
+MODULE_AUTHOR("Erik Gilling <konkers@android.com>");
+MODULE_DESCRIPTION("Nec Driver");
+MODULE_LICENSE("GPL");
--
1.5.6.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH 1/1] OMAP: DSS2: Add NEC NL8048HL11-01B display panel
2010-10-14 11:25 [PATCH 1/1] OMAP: DSS2: Add NEC NL8048HL11-01B display panel Samreen
@ 2010-10-20 12:27 ` Hiremath, Vaibhav
2010-10-21 5:13 ` Nilofer, Samreen
0 siblings, 1 reply; 3+ messages in thread
From: Hiremath, Vaibhav @ 2010-10-20 12:27 UTC (permalink / raw)
To: Nilofer, Samreen, linux-omap
Cc: Erik Gilling, Subbu Venkatesh, Mittal, Mukund, Rajkumar N
> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Nilofer, Samreen
> Sent: Thursday, October 14, 2010 4:55 PM
> To: linux-omap@vger.kernel.org
> Cc: Erik Gilling; Subbu Venkatesh; Mittal, Mukund; Rajkumar N; Nilofer,
> Samreen
> Subject: [PATCH 1/1] OMAP: DSS2: Add NEC NL8048HL11-01B display panel
>
> From: Erik Gilling <konkers@android.com>
>
> NEC WVGA LCD NL8048HL11-01B panel support has been added.
> This panel is being used in zoom2/zoom3/3630 sdp boards.
>
> Signed-off-by: Mukund Mittal <mmittal@ti.com>
> Signed-off-by: Rajkumar N <rajkumar.nagarajan@ti.com>
> Signed-off-by: Samreen <samreen@ti.com>
> CC: Subbu Venkatesh <subramani.venkatesh@windriver.com>
> CC: Erik Gilling <konkers@android.com>
> ---
> This panel driver has orginated from panel-zoom2 from the L25.x
> releases.Refer Commit:
>
> http://git.omapzoom.org/?p=kernel/omap.git;a=commit;h=75fc121865125d9e3ca3
> b36f1f19f86b394e1f6b
>
[Hiremath, Vaibhav] Does this cleanly apply on linux-omap/master branch or tomi's dss2 repo?
You should not be generating patches from any local/custom repositories.
> drivers/video/omap2/displays/Kconfig | 7 +
> drivers/video/omap2/displays/Makefile | 1 +
> .../omap2/displays/panel-nec-nl8048hl11-01b.c | 381
> ++++++++++++++++++++
> 3 files changed, 389 insertions(+), 0 deletions(-)
> create mode 100644 drivers/video/omap2/displays/panel-nec-nl8048hl11-
> 01b.c
>
> diff --git a/drivers/video/omap2/displays/Kconfig
> b/drivers/video/omap2/displays/Kconfig
> index 12327bb..f8152cf 100644
> --- a/drivers/video/omap2/displays/Kconfig
> +++ b/drivers/video/omap2/displays/Kconfig
> @@ -20,6 +20,13 @@ config PANEL_SHARP_LQ043T1DG01
> help
> LCD Panel used in TI's OMAP3517 EVM boards
>
> +config PANEL_NEC_NL8048HL11_01B
> + tristate "NEC NL8048HL11-01B Panel"
> + depends on OMAP2_DSS
> + help
> + This NEC NL8048HL11-01B panel is TFT LCD
> + used in the Zoom2/3/3630 sdp boards.
> +
> config PANEL_TAAL
> tristate "Taal DSI Panel"
> depends on OMAP2_DSS_DSI
> diff --git a/drivers/video/omap2/displays/Makefile
> b/drivers/video/omap2/displays/Makefile
> index aa38609..8ece91c 100644
> --- a/drivers/video/omap2/displays/Makefile
> +++ b/drivers/video/omap2/displays/Makefile
> @@ -1,6 +1,7 @@
> obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
> obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
> obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
> +obj-$(CONFIG_PANEL_NEC_NL8048HL11_01B) += panel-nec-nl8048hl11-01b.o
>
> obj-$(CONFIG_PANEL_TAAL) += panel-taal.o
> obj-$(CONFIG_PANEL_TOPPOLY_TDO35S) += panel-toppoly-tdo35s.o
> diff --git a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
> b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
> new file mode 100644
> index 0000000..cdc0d8f
> --- /dev/null
> +++ b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
> @@ -0,0 +1,381 @@
> +/*
> + * Support for NEC-nl8048hl11-01b panel driver
> + *
> + * Copyright (C) 2010 Texas Instruments Inc.
> + * Author: Erik Gilling <konkers@android.com>
> + * This program is free software; you can redistribute it and/or modify
> it
> + * under the terms of the GNU General Public License version 2 as
> published by
> + * the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but
> WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
> for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License
> along with
> + * this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/delay.h>
> +#include <linux/spi/spi.h>
> +#include <plat/display.h>
> +#include <linux/backlight.h>
> +#include <linux/fb.h>
> +
[Hiremath, Vaibhav] It would be nice if you gather all linux/xxx.h file together, keep one line gap and add all plat/xxx.h file here.
> +#define LCD_XRES 800
> +#define LCD_YRES 480
> +/*
> + * NEC PIX Clock Ratings
> + * MIN:21.8MHz TYP:23.8MHz MAX:25.7MHz
> + */
> +#define LCD_PIXEL_CLOCK 23800
> +
> +struct nec_8048_data {
> + struct backlight_device *bl;
> +};
> +
> +/*
> + * NEC NL8048HL11-01B Manual
> + * defines HFB, HSW, HBP, VFP, VSW, VBP as shown below
> + */
> +
> +static struct omap_video_timings nec_8048_panel_timings = {
> + /* 800 x 480 @ 60 Hz Reduced blanking VESA CVT 0.31M3-R */
> + .x_res = LCD_XRES,
> + .y_res = LCD_YRES,
> + .pixel_clock = LCD_PIXEL_CLOCK,
> + .hfp = 6,
> + .hsw = 1,
> + .hbp = 4,
> + .vfp = 3,
> + .vsw = 1,
> + .vbp = 4,
> +};
> +
> +static int nec_8048_bl_update_status(struct backlight_device *bl)
> +{
> + struct omap_dss_device *dssdev = dev_get_drvdata(&bl->dev);
> + int level;
> +
> + if (!dssdev->set_backlight)
> + return -EINVAL;
> +
> + if (bl->props.fb_blank == FB_BLANK_UNBLANK &&
> + bl->props.power == FB_BLANK_UNBLANK)
> + level = bl->props.brightness;
> + else
> + level = 0;
> +
> + return dssdev->set_backlight(dssdev, level);
> +}
> +
> +static int nec_8048_bl_get_brightness(struct backlight_device *bl)
> +{
> + if (bl->props.fb_blank == FB_BLANK_UNBLANK &&
> + bl->props.power == FB_BLANK_UNBLANK)
> + return bl->props.brightness;
> +
> + return 0;
> +}
> +
> +static const struct backlight_ops nec_8048_bl_ops = {
> + .get_brightness = nec_8048_bl_get_brightness,
> + .update_status = nec_8048_bl_update_status,
> +};
> +
> +static int nec_8048_panel_probe(struct omap_dss_device *dssdev)
> +{
> + struct backlight_device *bl;
> + struct nec_8048_data *necd;
> + struct backlight_properties props;
> + int r;
> +
> + dssdev->panel.config = OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
> + OMAP_DSS_LCD_IHS | OMAP_DSS_LCD_RF |
> + OMAP_DSS_LCD_ONOFF;
> + dssdev->panel.timings = nec_8048_panel_timings;
> +
> + necd = kzalloc(sizeof(*necd), GFP_KERNEL);
> + if (!necd)
> + return -ENOMEM;
> +
> + dev_set_drvdata(&dssdev->dev, necd);
> +
> + memset(&props, 0, sizeof(struct backlight_properties));
> + props.max_brightness = 255;
> +
> + bl = backlight_device_register("nec-8048", &dssdev->dev, dssdev,
> + &nec_8048_bl_ops, &props);
> + if (IS_ERR(bl)) {
> + r = PTR_ERR(bl);
> + kfree(necd);
> + return r;
> + }
> + necd->bl = bl;
> +
> + bl->props.fb_blank = FB_BLANK_UNBLANK;
> + bl->props.power = FB_BLANK_UNBLANK;
> + bl->props.max_brightness = dssdev->max_backlight_level;
> + bl->props.brightness = 0;
> +
> + r = nec_8048_bl_update_status(bl);
> + if (r < 0)
> + dev_err(&dssdev->dev, "failed to set lcd brightness\n");
> +
> + return 0;
> +}
> +
> +static void nec_8048_panel_remove(struct omap_dss_device *dssdev)
> +{
> + struct nec_8048_data *necd = dev_get_drvdata(&dssdev->dev);
> + struct backlight_device *bl = necd->bl;
> +
> + bl->props.power = FB_BLANK_POWERDOWN;
> + nec_8048_bl_update_status(bl);
> + backlight_device_unregister(bl);
> +
> + kfree(necd);
> +}
> +
> +static int nec_8048_panel_enable(struct omap_dss_device *dssdev)
> +{
> + int r = 0;
> + struct nec_8048_data *necd = dev_get_drvdata(&dssdev->dev);
> + struct backlight_device *bl = necd->bl;
> +
> + if (dssdev->platform_enable) {
> + r = dssdev->platform_enable(dssdev);
> + if (r)
> + return r;
> + }
> +
> + bl->props.brightness = dssdev->max_backlight_level;
[Hiremath, Vaibhav] Don't you think you should be using bl->props.brightness here, you are overriding user configuration?
> + r = nec_8048_bl_update_status(bl);
> + if (r < 0)
> + dev_err(&dssdev->dev, "failed to set lcd brightness\n");
> +
> + omapdss_dpi_display_enable(dssdev);
> +
[Hiremath, Vaibhav] Check return value here.
> + return 0;
> +}
> +
> +static void nec_8048_panel_disable(struct omap_dss_device *dssdev)
> +{
> + struct nec_8048_data *necd = dev_get_drvdata(&dssdev->dev);
> + struct backlight_device *bl = necd->bl;
> +
> + omapdss_dpi_display_disable(dssdev);
> +
> + bl->props.brightness = 0;
> + nec_8048_bl_update_status(bl);
> +
> + if (dssdev->platform_disable)
> + dssdev->platform_disable(dssdev);
> +}
> +
> +static int nec_8048_panel_suspend(struct omap_dss_device *dssdev)
> +{
> + nec_8048_panel_disable(dssdev);
> + return 0;
> +}
> +
> +static int nec_8048_panel_resume(struct omap_dss_device *dssdev)
> +{
> + return nec_8048_panel_enable(dssdev);
> +}
> +
> +static int nec_8048_recommended_bpp(struct omap_dss_device *dssdev)
> +{
> + return 16;
> +}
> +
> +static struct omap_dss_driver nec_8048_driver = {
> + .probe = nec_8048_panel_probe,
> + .remove = nec_8048_panel_remove,
> + .enable = nec_8048_panel_enable,
> + .disable = nec_8048_panel_disable,
> + .suspend = nec_8048_panel_suspend,
> + .resume = nec_8048_panel_resume,
> + .get_recommended_bpp = nec_8048_recommended_bpp,
> +
> + .driver = {
> + .name = "NEC_8048_panel",
> + .owner = THIS_MODULE,
> + },
> +};
> +
> +static int spi_send(struct spi_device *spi, unsigned char reg_addr,
> + unsigned char reg_data)
> +{
> + int ret = 0;
> + unsigned int cmd = 0, data = 0;
> +
> + cmd = 0x0000 | reg_addr; /* register address write */
> + data = 0x0100 | reg_data ; /* register data write */
> + data = (cmd << 16) | data;
> +
> + ret = spi_write(spi, (unsigned char *)&data, 4);
> + if (ret) {
> + pr_err("error in spi_write %x\n", data);
> + return ret;
> + }
> +
> + return 0;
[Hiremath, Vaibhav] You can have some thing,
ret = spi_write(spi, (unsigned char *)&data, 4);
if (ret)
pr_err("error in spi_write %x\n", data);
return ret;
Thanks,
Vaibhav
> +}
> +
> +
> +static int init_nec_8048_wvga_lcd(struct spi_device *spi)
> +{
> + /* Initialization Sequence */
> + /* spi_send(spi, REG, VAL) */
> + spi_send(spi, 3, 0x01);
> + spi_send(spi, 0, 0x00);
> + spi_send(spi, 1, 0x01); /* R1 = 0x01 (normal), 0x03 (reversed) */
> + spi_send(spi, 4, 0x00);
> + spi_send(spi, 5, 0x14);
> + spi_send(spi, 6, 0x24);
> + spi_send(spi, 16, 0xD7);
> + spi_send(spi, 17, 0x00);
> + spi_send(spi, 18, 0x00);
> + spi_send(spi, 19, 0x55);
> + spi_send(spi, 20, 0x01);
> + spi_send(spi, 21, 0x70);
> + spi_send(spi, 22, 0x1E);
> + spi_send(spi, 23, 0x25);
> + spi_send(spi, 24, 0x25);
> + spi_send(spi, 25, 0x02);
> + spi_send(spi, 26, 0x02);
> + spi_send(spi, 27, 0xA0);
> + spi_send(spi, 32, 0x2F);
> + spi_send(spi, 33, 0x0F);
> + spi_send(spi, 34, 0x0F);
> + spi_send(spi, 35, 0x0F);
> + spi_send(spi, 36, 0x0F);
> + spi_send(spi, 37, 0x0F);
> + spi_send(spi, 38, 0x0F);
> + spi_send(spi, 39, 0x00);
> + spi_send(spi, 40, 0x02);
> + spi_send(spi, 41, 0x02);
> + spi_send(spi, 42, 0x02);
> + spi_send(spi, 43, 0x0F);
> + spi_send(spi, 44, 0x0F);
> + spi_send(spi, 45, 0x0F);
> + spi_send(spi, 46, 0x0F);
> + spi_send(spi, 47, 0x0F);
> + spi_send(spi, 48, 0x0F);
> + spi_send(spi, 49, 0x0F);
> + spi_send(spi, 50, 0x00);
> + spi_send(spi, 51, 0x02);
> + spi_send(spi, 52, 0x02);
> + spi_send(spi, 53, 0x02);
> + spi_send(spi, 80, 0x0C);
> + spi_send(spi, 83, 0x42);
> + spi_send(spi, 84, 0x42);
> + spi_send(spi, 85, 0x41);
> + spi_send(spi, 86, 0x14);
> + spi_send(spi, 89, 0x88);
> + spi_send(spi, 90, 0x01);
> + spi_send(spi, 91, 0x00);
> + spi_send(spi, 92, 0x02);
> + spi_send(spi, 93, 0x0C);
> + spi_send(spi, 94, 0x1C);
> + spi_send(spi, 95, 0x27);
> + spi_send(spi, 98, 0x49);
> + spi_send(spi, 99, 0x27);
> + spi_send(spi, 102, 0x76);
> + spi_send(spi, 103, 0x27);
> + spi_send(spi, 112, 0x01);
> + spi_send(spi, 113, 0x0E);
> + spi_send(spi, 114, 0x02);
> + spi_send(spi, 115, 0x0C);
> + spi_send(spi, 118, 0x0C);
> + spi_send(spi, 121, 0x30); /* R121 = 0x30 (normal), 0x10 (reversed)
> */
> + spi_send(spi, 130, 0x00);
> + spi_send(spi, 131, 0x00);
> + spi_send(spi, 132, 0xFC);
> + spi_send(spi, 134, 0x00);
> + spi_send(spi, 136, 0x00);
> + spi_send(spi, 138, 0x00);
> + spi_send(spi, 139, 0x00);
> + spi_send(spi, 140, 0x00);
> + spi_send(spi, 141, 0xFC);
> + spi_send(spi, 143, 0x00);
> + spi_send(spi, 145, 0x00);
> + spi_send(spi, 147, 0x00);
> + spi_send(spi, 148, 0x00);
> + spi_send(spi, 149, 0x00);
> + spi_send(spi, 150, 0xFC);
> + spi_send(spi, 152, 0x00);
> + spi_send(spi, 154, 0x00);
> + spi_send(spi, 156, 0x00);
> + spi_send(spi, 157, 0x00);
> + udelay(20);
> + spi_send(spi, 2, 0x00);
> +
> + return 0;
> +}
> +
> +static int nec_8048_spi_probe(struct spi_device *spi)
> +{
> + spi->mode = SPI_MODE_0;
> + spi->bits_per_word = 32;
> + spi_setup(spi);
> +
> + init_nec_8048_wvga_lcd(spi);
> +
> + return omap_dss_register_driver(&nec_8048_driver);
> +}
> +
> +static int nec_8048_spi_remove(struct spi_device *spi)
> +{
> + omap_dss_unregister_driver(&nec_8048_driver);
> +
> + return 0;
> +}
> +
> +static int nec_8048_spi_suspend(struct spi_device *spi, pm_message_t
> mesg)
> +{
> + spi_send(spi, 2, 0x01);
> + mdelay(40);
> +
> + return 0;
> +}
> +
> +static int nec_8048_spi_resume(struct spi_device *spi)
> +{
> + /* reinitialize the panel */
> + spi_setup(spi);
> + spi_send(spi, 2, 0x00);
> + init_nec_8048_wvga_lcd(spi);
> +
> + return 0;
> +}
> +
> +static struct spi_driver nec_8048_spi_driver = {
> + .probe = nec_8048_spi_probe,
> + .remove = __devexit_p(nec_8048_spi_remove),
> + .suspend = nec_8048_spi_suspend,
> + .resume = nec_8048_spi_resume,
> + .driver = {
> + .name = "nec_8048_spi",
> + .bus = &spi_bus_type,
> + .owner = THIS_MODULE,
> + },
> +};
> +
> +static int __init nec_8048_lcd_init(void)
> +{
> + return spi_register_driver(&nec_8048_spi_driver);
> +}
> +
> +static void __exit nec_8048_lcd_exit(void)
> +{
> + return spi_unregister_driver(&nec_8048_spi_driver);
> +}
> +
> +module_init(nec_8048_lcd_init);
> +module_exit(nec_8048_lcd_exit);
> +MODULE_AUTHOR("Erik Gilling <konkers@android.com>");
> +MODULE_DESCRIPTION("Nec Driver");
> +MODULE_LICENSE("GPL");
> --
> 1.5.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 1/1] OMAP: DSS2: Add NEC NL8048HL11-01B display panel
2010-10-20 12:27 ` Hiremath, Vaibhav
@ 2010-10-21 5:13 ` Nilofer, Samreen
0 siblings, 0 replies; 3+ messages in thread
From: Nilofer, Samreen @ 2010-10-21 5:13 UTC (permalink / raw)
To: Hiremath, Vaibhav, linux-omap
Cc: Erik Gilling, Subbu Venkatesh, Mittal, Mukund, Rajkumar N
> -----Original Message-----
> From: Hiremath, Vaibhav
> Sent: Wednesday, October 20, 2010 5:57 PM
> To: Nilofer, Samreen; linux-omap@vger.kernel.org
> Cc: Erik Gilling; Subbu Venkatesh; Mittal, Mukund; Rajkumar N
> Subject: RE: [PATCH 1/1] OMAP: DSS2: Add NEC NL8048HL11-01B
> display panel
>
> > -----Original Message-----
> > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> > owner@vger.kernel.org] On Behalf Of Nilofer, Samreen
> > Sent: Thursday, October 14, 2010 4:55 PM
> > To: linux-omap@vger.kernel.org
> > Cc: Erik Gilling; Subbu Venkatesh; Mittal, Mukund; Rajkumar N;
> > Nilofer, Samreen
> > Subject: [PATCH 1/1] OMAP: DSS2: Add NEC NL8048HL11-01B
> display panel
> >
> > From: Erik Gilling <konkers@android.com>
> >
> > NEC WVGA LCD NL8048HL11-01B panel support has been added.
> > This panel is being used in zoom2/zoom3/3630 sdp boards.
> >
> > Signed-off-by: Mukund Mittal <mmittal@ti.com>
> > Signed-off-by: Rajkumar N <rajkumar.nagarajan@ti.com>
> > Signed-off-by: Samreen <samreen@ti.com>
> > CC: Subbu Venkatesh <subramani.venkatesh@windriver.com>
> > CC: Erik Gilling <konkers@android.com>
> > ---
> > This panel driver has orginated from panel-zoom2 from the L25.x
> > releases.Refer Commit:
> >
> >
> http://git.omapzoom.org/?p=kernel/omap.git;a=commit;h=75fc121865125d9e
> > 3ca3
> > b36f1f19f86b394e1f6b
> >
> [Hiremath, Vaibhav] Does this cleanly apply on
> linux-omap/master branch or tomi's dss2 repo?
> You should not be generating patches from any local/custom
> repositories.
[Samreen] These patch cleanly applies on Tomi' dss2 tree.
I have tested and validated this patch on tomi's tree.
>
> > drivers/video/omap2/displays/Kconfig | 7 +
> > drivers/video/omap2/displays/Makefile | 1 +
> > .../omap2/displays/panel-nec-nl8048hl11-01b.c | 381
> > ++++++++++++++++++++
> > 3 files changed, 389 insertions(+), 0 deletions(-) create mode
> > 100644 drivers/video/omap2/displays/panel-nec-nl8048hl11-
> > 01b.c
> >
> > diff --git a/drivers/video/omap2/displays/Kconfig
> > b/drivers/video/omap2/displays/Kconfig
> > index 12327bb..f8152cf 100644
> > --- a/drivers/video/omap2/displays/Kconfig
> > +++ b/drivers/video/omap2/displays/Kconfig
> > @@ -20,6 +20,13 @@ config PANEL_SHARP_LQ043T1DG01
> > help
> > LCD Panel used in TI's OMAP3517 EVM boards
> >
> > +config PANEL_NEC_NL8048HL11_01B
> > + tristate "NEC NL8048HL11-01B Panel"
> > + depends on OMAP2_DSS
> > + help
> > + This NEC NL8048HL11-01B panel is TFT LCD
> > + used in the Zoom2/3/3630 sdp boards.
> > +
> > config PANEL_TAAL
> > tristate "Taal DSI Panel"
> > depends on OMAP2_DSS_DSI
> > diff --git a/drivers/video/omap2/displays/Makefile
> > b/drivers/video/omap2/displays/Makefile
> > index aa38609..8ece91c 100644
> > --- a/drivers/video/omap2/displays/Makefile
> > +++ b/drivers/video/omap2/displays/Makefile
> > @@ -1,6 +1,7 @@
> > obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o
> > obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o
> > obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o
> > +obj-$(CONFIG_PANEL_NEC_NL8048HL11_01B) +=
> panel-nec-nl8048hl11-01b.o
> >
> > obj-$(CONFIG_PANEL_TAAL) += panel-taal.o
> > obj-$(CONFIG_PANEL_TOPPOLY_TDO35S) += panel-toppoly-tdo35s.o diff
> > --git a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
> > b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
> > new file mode 100644
> > index 0000000..cdc0d8f
> > --- /dev/null
> > +++ b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
> > @@ -0,0 +1,381 @@
> > +/*
> > + * Support for NEC-nl8048hl11-01b panel driver
> > + *
> > + * Copyright (C) 2010 Texas Instruments Inc.
> > + * Author: Erik Gilling <konkers@android.com>
> > + * This program is free software; you can redistribute it and/or
> > +modify
> > it
> > + * under the terms of the GNU General Public License version 2 as
> > published by
> > + * the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + but
> > WITHOUT
> > + * ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY
> > + or
> > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public
> > + License
> > for
> > + * more details.
> > + *
> > + * You should have received a copy of the GNU General
> Public License
> > along with
> > + * this program. If not, see <http://www.gnu.org/licenses/>.
> > + */
> > +
> > +#include <linux/module.h>
> > +#include <linux/delay.h>
> > +#include <linux/spi/spi.h>
> > +#include <plat/display.h>
> > +#include <linux/backlight.h>
> > +#include <linux/fb.h>
> > +
> [Hiremath, Vaibhav] It would be nice if you gather all
> linux/xxx.h file together, keep one line gap and add all
> plat/xxx.h file here.
[Samreen]
Will fix this.
>
> > +#define LCD_XRES 800
> > +#define LCD_YRES 480
> > +/*
> > + * NEC PIX Clock Ratings
> > + * MIN:21.8MHz TYP:23.8MHz MAX:25.7MHz */
> > +#define LCD_PIXEL_CLOCK 23800
> > +
> > +struct nec_8048_data {
> > + struct backlight_device *bl;
> > +};
> > +
> > +/*
> > + * NEC NL8048HL11-01B Manual
> > + * defines HFB, HSW, HBP, VFP, VSW, VBP as shown below */
> > +
> > +static struct omap_video_timings nec_8048_panel_timings = {
> > + /* 800 x 480 @ 60 Hz Reduced blanking VESA CVT 0.31M3-R */
> > + .x_res = LCD_XRES,
> > + .y_res = LCD_YRES,
> > + .pixel_clock = LCD_PIXEL_CLOCK,
> > + .hfp = 6,
> > + .hsw = 1,
> > + .hbp = 4,
> > + .vfp = 3,
> > + .vsw = 1,
> > + .vbp = 4,
> > +};
> > +
> > +static int nec_8048_bl_update_status(struct backlight_device *bl) {
> > + struct omap_dss_device *dssdev = dev_get_drvdata(&bl->dev);
> > + int level;
> > +
> > + if (!dssdev->set_backlight)
> > + return -EINVAL;
> > +
> > + if (bl->props.fb_blank == FB_BLANK_UNBLANK &&
> > + bl->props.power == FB_BLANK_UNBLANK)
> > + level = bl->props.brightness;
> > + else
> > + level = 0;
> > +
> > + return dssdev->set_backlight(dssdev, level); }
> > +
> > +static int nec_8048_bl_get_brightness(struct
> backlight_device *bl) {
> > + if (bl->props.fb_blank == FB_BLANK_UNBLANK &&
> > + bl->props.power == FB_BLANK_UNBLANK)
> > + return bl->props.brightness;
> > +
> > + return 0;
> > +}
> > +
> > +static const struct backlight_ops nec_8048_bl_ops = {
> > + .get_brightness = nec_8048_bl_get_brightness,
> > + .update_status = nec_8048_bl_update_status,
> > +};
> > +
> > +static int nec_8048_panel_probe(struct omap_dss_device *dssdev) {
> > + struct backlight_device *bl;
> > + struct nec_8048_data *necd;
> > + struct backlight_properties props;
> > + int r;
> > +
> > + dssdev->panel.config = OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
> > + OMAP_DSS_LCD_IHS | OMAP_DSS_LCD_RF |
> > + OMAP_DSS_LCD_ONOFF;
> > + dssdev->panel.timings = nec_8048_panel_timings;
> > +
> > + necd = kzalloc(sizeof(*necd), GFP_KERNEL);
> > + if (!necd)
> > + return -ENOMEM;
> > +
> > + dev_set_drvdata(&dssdev->dev, necd);
> > +
> > + memset(&props, 0, sizeof(struct backlight_properties));
> > + props.max_brightness = 255;
> > +
> > + bl = backlight_device_register("nec-8048", &dssdev->dev, dssdev,
> > + &nec_8048_bl_ops, &props);
> > + if (IS_ERR(bl)) {
> > + r = PTR_ERR(bl);
> > + kfree(necd);
> > + return r;
> > + }
> > + necd->bl = bl;
> > +
> > + bl->props.fb_blank = FB_BLANK_UNBLANK;
> > + bl->props.power = FB_BLANK_UNBLANK;
> > + bl->props.max_brightness = dssdev->max_backlight_level;
> > + bl->props.brightness = 0;
> > +
> > + r = nec_8048_bl_update_status(bl);
> > + if (r < 0)
> > + dev_err(&dssdev->dev, "failed to set lcd brightness\n");
> > +
> > + return 0;
> > +}
> > +
> > +static void nec_8048_panel_remove(struct omap_dss_device *dssdev) {
> > + struct nec_8048_data *necd = dev_get_drvdata(&dssdev->dev);
> > + struct backlight_device *bl = necd->bl;
> > +
> > + bl->props.power = FB_BLANK_POWERDOWN;
> > + nec_8048_bl_update_status(bl);
> > + backlight_device_unregister(bl);
> > +
> > + kfree(necd);
> > +}
> > +
> > +static int nec_8048_panel_enable(struct omap_dss_device *dssdev) {
> > + int r = 0;
> > + struct nec_8048_data *necd = dev_get_drvdata(&dssdev->dev);
> > + struct backlight_device *bl = necd->bl;
> > +
> > + if (dssdev->platform_enable) {
> > + r = dssdev->platform_enable(dssdev);
> > + if (r)
> > + return r;
> > + }
> > +
> > + bl->props.brightness = dssdev->max_backlight_level;
> [Hiremath, Vaibhav] Don't you think you should be using
> bl->props.brightness here, you are overriding user configuration?
>
[Samreen]
Will remove the assignment statement.
> > + r = nec_8048_bl_update_status(bl);
> > + if (r < 0)
> > + dev_err(&dssdev->dev, "failed to set lcd brightness\n");
> > +
> > + omapdss_dpi_display_enable(dssdev);
> > +
> [Hiremath, Vaibhav] Check return value here.
[Samreen]
Will add the error check.
> > + return 0;
> > +}
> > +
> > +static void nec_8048_panel_disable(struct omap_dss_device
> *dssdev) {
> > + struct nec_8048_data *necd = dev_get_drvdata(&dssdev->dev);
> > + struct backlight_device *bl = necd->bl;
> > +
> > + omapdss_dpi_display_disable(dssdev);
> > +
> > + bl->props.brightness = 0;
> > + nec_8048_bl_update_status(bl);
> > +
> > + if (dssdev->platform_disable)
> > + dssdev->platform_disable(dssdev);
> > +}
> > +
> > +static int nec_8048_panel_suspend(struct omap_dss_device *dssdev) {
> > + nec_8048_panel_disable(dssdev);
> > + return 0;
> > +}
> > +
> > +static int nec_8048_panel_resume(struct omap_dss_device *dssdev) {
> > + return nec_8048_panel_enable(dssdev); }
> > +
> > +static int nec_8048_recommended_bpp(struct omap_dss_device
> *dssdev) {
> > + return 16;
> > +}
> > +
> > +static struct omap_dss_driver nec_8048_driver = {
> > + .probe = nec_8048_panel_probe,
> > + .remove = nec_8048_panel_remove,
> > + .enable = nec_8048_panel_enable,
> > + .disable = nec_8048_panel_disable,
> > + .suspend = nec_8048_panel_suspend,
> > + .resume = nec_8048_panel_resume,
> > + .get_recommended_bpp = nec_8048_recommended_bpp,
> > +
> > + .driver = {
> > + .name = "NEC_8048_panel",
> > + .owner = THIS_MODULE,
> > + },
> > +};
> > +
> > +static int spi_send(struct spi_device *spi, unsigned char reg_addr,
> > + unsigned char reg_data)
> > +{
> > + int ret = 0;
> > + unsigned int cmd = 0, data = 0;
> > +
> > + cmd = 0x0000 | reg_addr; /* register address write */
> > + data = 0x0100 | reg_data ; /* register data write */
> > + data = (cmd << 16) | data;
> > +
> > + ret = spi_write(spi, (unsigned char *)&data, 4);
> > + if (ret) {
> > + pr_err("error in spi_write %x\n", data);
> > + return ret;
> > + }
> > +
> > + return 0;
> [Hiremath, Vaibhav] You can have some thing,
>
> ret = spi_write(spi, (unsigned char *)&data, 4);
> if (ret)
> pr_err("error in spi_write %x\n", data);
>
> return ret;
>
> Thanks,
> Vaibhav
[Samreen]
Will modify this accordingly.
Will incorporate all the above comments and post out the next version very soon.
Thanks,
Warm Regards,
Samreen
>
> > +}
> > +
> > +
> > +static int init_nec_8048_wvga_lcd(struct spi_device *spi) {
> > + /* Initialization Sequence */
> > + /* spi_send(spi, REG, VAL) */
> > + spi_send(spi, 3, 0x01);
> > + spi_send(spi, 0, 0x00);
> > + spi_send(spi, 1, 0x01); /* R1 = 0x01 (normal), 0x03
> (reversed) */
> > + spi_send(spi, 4, 0x00);
> > + spi_send(spi, 5, 0x14);
> > + spi_send(spi, 6, 0x24);
> > + spi_send(spi, 16, 0xD7);
> > + spi_send(spi, 17, 0x00);
> > + spi_send(spi, 18, 0x00);
> > + spi_send(spi, 19, 0x55);
> > + spi_send(spi, 20, 0x01);
> > + spi_send(spi, 21, 0x70);
> > + spi_send(spi, 22, 0x1E);
> > + spi_send(spi, 23, 0x25);
> > + spi_send(spi, 24, 0x25);
> > + spi_send(spi, 25, 0x02);
> > + spi_send(spi, 26, 0x02);
> > + spi_send(spi, 27, 0xA0);
> > + spi_send(spi, 32, 0x2F);
> > + spi_send(spi, 33, 0x0F);
> > + spi_send(spi, 34, 0x0F);
> > + spi_send(spi, 35, 0x0F);
> > + spi_send(spi, 36, 0x0F);
> > + spi_send(spi, 37, 0x0F);
> > + spi_send(spi, 38, 0x0F);
> > + spi_send(spi, 39, 0x00);
> > + spi_send(spi, 40, 0x02);
> > + spi_send(spi, 41, 0x02);
> > + spi_send(spi, 42, 0x02);
> > + spi_send(spi, 43, 0x0F);
> > + spi_send(spi, 44, 0x0F);
> > + spi_send(spi, 45, 0x0F);
> > + spi_send(spi, 46, 0x0F);
> > + spi_send(spi, 47, 0x0F);
> > + spi_send(spi, 48, 0x0F);
> > + spi_send(spi, 49, 0x0F);
> > + spi_send(spi, 50, 0x00);
> > + spi_send(spi, 51, 0x02);
> > + spi_send(spi, 52, 0x02);
> > + spi_send(spi, 53, 0x02);
> > + spi_send(spi, 80, 0x0C);
> > + spi_send(spi, 83, 0x42);
> > + spi_send(spi, 84, 0x42);
> > + spi_send(spi, 85, 0x41);
> > + spi_send(spi, 86, 0x14);
> > + spi_send(spi, 89, 0x88);
> > + spi_send(spi, 90, 0x01);
> > + spi_send(spi, 91, 0x00);
> > + spi_send(spi, 92, 0x02);
> > + spi_send(spi, 93, 0x0C);
> > + spi_send(spi, 94, 0x1C);
> > + spi_send(spi, 95, 0x27);
> > + spi_send(spi, 98, 0x49);
> > + spi_send(spi, 99, 0x27);
> > + spi_send(spi, 102, 0x76);
> > + spi_send(spi, 103, 0x27);
> > + spi_send(spi, 112, 0x01);
> > + spi_send(spi, 113, 0x0E);
> > + spi_send(spi, 114, 0x02);
> > + spi_send(spi, 115, 0x0C);
> > + spi_send(spi, 118, 0x0C);
> > + spi_send(spi, 121, 0x30); /* R121 = 0x30 (normal), 0x10
> (reversed)
> > */
> > + spi_send(spi, 130, 0x00);
> > + spi_send(spi, 131, 0x00);
> > + spi_send(spi, 132, 0xFC);
> > + spi_send(spi, 134, 0x00);
> > + spi_send(spi, 136, 0x00);
> > + spi_send(spi, 138, 0x00);
> > + spi_send(spi, 139, 0x00);
> > + spi_send(spi, 140, 0x00);
> > + spi_send(spi, 141, 0xFC);
> > + spi_send(spi, 143, 0x00);
> > + spi_send(spi, 145, 0x00);
> > + spi_send(spi, 147, 0x00);
> > + spi_send(spi, 148, 0x00);
> > + spi_send(spi, 149, 0x00);
> > + spi_send(spi, 150, 0xFC);
> > + spi_send(spi, 152, 0x00);
> > + spi_send(spi, 154, 0x00);
> > + spi_send(spi, 156, 0x00);
> > + spi_send(spi, 157, 0x00);
> > + udelay(20);
> > + spi_send(spi, 2, 0x00);
> > +
> > + return 0;
> > +}
> > +
> > +static int nec_8048_spi_probe(struct spi_device *spi) {
> > + spi->mode = SPI_MODE_0;
> > + spi->bits_per_word = 32;
> > + spi_setup(spi);
> > +
> > + init_nec_8048_wvga_lcd(spi);
> > +
> > + return omap_dss_register_driver(&nec_8048_driver);
> > +}
> > +
> > +static int nec_8048_spi_remove(struct spi_device *spi) {
> > + omap_dss_unregister_driver(&nec_8048_driver);
> > +
> > + return 0;
> > +}
> > +
> > +static int nec_8048_spi_suspend(struct spi_device *spi,
> pm_message_t
> > mesg)
> > +{
> > + spi_send(spi, 2, 0x01);
> > + mdelay(40);
> > +
> > + return 0;
> > +}
> > +
> > +static int nec_8048_spi_resume(struct spi_device *spi) {
> > + /* reinitialize the panel */
> > + spi_setup(spi);
> > + spi_send(spi, 2, 0x00);
> > + init_nec_8048_wvga_lcd(spi);
> > +
> > + return 0;
> > +}
> > +
> > +static struct spi_driver nec_8048_spi_driver = {
> > + .probe = nec_8048_spi_probe,
> > + .remove = __devexit_p(nec_8048_spi_remove),
> > + .suspend = nec_8048_spi_suspend,
> > + .resume = nec_8048_spi_resume,
> > + .driver = {
> > + .name = "nec_8048_spi",
> > + .bus = &spi_bus_type,
> > + .owner = THIS_MODULE,
> > + },
> > +};
> > +
> > +static int __init nec_8048_lcd_init(void) {
> > + return spi_register_driver(&nec_8048_spi_driver);
> > +}
> > +
> > +static void __exit nec_8048_lcd_exit(void) {
> > + return spi_unregister_driver(&nec_8048_spi_driver);
> > +}
> > +
> > +module_init(nec_8048_lcd_init);
> > +module_exit(nec_8048_lcd_exit);
> > +MODULE_AUTHOR("Erik Gilling <konkers@android.com>");
> > +MODULE_DESCRIPTION("Nec Driver"); MODULE_LICENSE("GPL");
> > --
> > 1.5.6.3
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> linux-omap"
> > in the body of a message to majordomo@vger.kernel.org More
> majordomo
> > info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-21 5:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-14 11:25 [PATCH 1/1] OMAP: DSS2: Add NEC NL8048HL11-01B display panel Samreen
2010-10-20 12:27 ` Hiremath, Vaibhav
2010-10-21 5:13 ` Nilofer, Samreen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.