[PATCH] gdb-cross-sdk: don't reconfigure after making changes in gdb/Makefile

[PATCH] gdb-cross-sdk: don't reconfigure after making changes in gdb/Makefile

[Eric Bénard]

else we don't statically link libncurses, libtinfo and libz which leads
to :
/usr/local/angstrom/arm/bin/arm-angstrom-linux-gnueabi-gdb:
error while loading shared libraries: libtinfo.so.5:
cannot open shared object file: No such file or directory

when trying to use the toolchain.

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 recipes/gdb/gdb-cross-sdk.inc |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/recipes/gdb/gdb-cross-sdk.inc b/recipes/gdb/gdb-cross-sdk.inc
index 6a708ca..d32111f 100644
--- a/recipes/gdb/gdb-cross-sdk.inc
+++ b/recipes/gdb/gdb-cross-sdk.inc
@@ -16,5 +16,4 @@ do_configure_append () {
 	for SIM in ${B}/sim/*/Makefile; do
 		[ -f $SIM ] && sed -e 's,-lz, ${STAGING_LIBDIR_NATIVE}/libz.a ,g' -i $SIM
 	done
-	oe_runconf
 }
-- 
1.6.3.3

Re: [PATCH] gdb-cross-sdk: don't reconfigure after making changes in gdb/Makefile

[Khem Raj]

On Mon, Nov 1, 2010 at 2:29 PM, Eric Bénard <eric@eukrea.com> wrote:
> else we don't statically link libncurses, libtinfo and libz which leads
> to :
> /usr/local/angstrom/arm/bin/arm-angstrom-linux-gnueabi-gdb:
> error while loading shared libraries: libtinfo.so.5:
> cannot open shared object file: No such file or directory
>
> when trying to use the toolchain.

could you run oe_runconf and then do the Makefile editing ? that way
it will work as expected.
we sort of need oe_runconf

>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
>  recipes/gdb/gdb-cross-sdk.inc |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/recipes/gdb/gdb-cross-sdk.inc b/recipes/gdb/gdb-cross-sdk.inc
> index 6a708ca..d32111f 100644
> --- a/recipes/gdb/gdb-cross-sdk.inc
> +++ b/recipes/gdb/gdb-cross-sdk.inc
> @@ -16,5 +16,4 @@ do_configure_append () {
>        for SIM in ${B}/sim/*/Makefile; do
>                [ -f $SIM ] && sed -e 's,-lz, ${STAGING_LIBDIR_NATIVE}/libz.a ,g' -i $SIM
>        done
> -       oe_runconf
>  }
> --
> 1.6.3.3
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] gdb-cross-sdk: don't reconfigure after making changes in gdb/Makefile

[Eric Bénard]

Le 02/11/2010 05:41, Khem Raj a écrit :
> On Mon, Nov 1, 2010 at 2:29 PM, Eric Bénard<eric@eukrea.com>  wrote:
>> else we don't statically link libncurses, libtinfo and libz which leads
>> to :
>> /usr/local/angstrom/arm/bin/arm-angstrom-linux-gnueabi-gdb:
>> error while loading shared libraries: libtinfo.so.5:
>> cannot open shared object file: No such file or directory
>>
>> when trying to use the toolchain.
>
> could you run oe_runconf and then do the Makefile editing ? that way
> it will work as expected.
> we sort of need oe_runconf
>
the makefile we hack with sed is not created after oe_runconf, it's generated 
by oe_runmake configure-host
So what should work is :
oe_runconf
oe_runmake
then sed

Eric

>>
>> Signed-off-by: Eric Bénard<eric@eukrea.com>
>> ---
>>   recipes/gdb/gdb-cross-sdk.inc |    1 -
>>   1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/recipes/gdb/gdb-cross-sdk.inc b/recipes/gdb/gdb-cross-sdk.inc
>> index 6a708ca..d32111f 100644
>> --- a/recipes/gdb/gdb-cross-sdk.inc
>> +++ b/recipes/gdb/gdb-cross-sdk.inc
>> @@ -16,5 +16,4 @@ do_configure_append () {
>>         for SIM in ${B}/sim/*/Makefile; do
>>                 [ -f $SIM ]&&  sed -e 's,-lz, ${STAGING_LIBDIR_NATIVE}/libz.a ,g' -i $SIM
>>         done
>> -       oe_runconf
>>   }
>> --
>> 1.6.3.3
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

[PATCH] gdb-cross-sdk: reconfigure before running oe_runmake configure-host

[Eric Bénard]

so we have : configure then make configure-host which generates the
Makefile that we modify using sed to statically link the libs

Without this patch, we don't statically link libncurses, libtinfo
and libz which leads to :
/usr/local/angstrom/arm/bin/arm-angstrom-linux-gnueabi-gdb:
error while loading shared libraries: libtinfo.so.5:
cannot open shared object file: No such file or directory

when trying to use the toolchain.

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 recipes/gdb/gdb-cross-sdk.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/recipes/gdb/gdb-cross-sdk.inc b/recipes/gdb/gdb-cross-sdk.inc
index 6a708ca..e1d4895 100644
--- a/recipes/gdb/gdb-cross-sdk.inc
+++ b/recipes/gdb/gdb-cross-sdk.inc
@@ -8,6 +8,7 @@ EXTRA_OEMAKE = "'SUBDIRS=intl mmalloc libiberty opcodes bfd sim gdb etc utils' L
 # add a depenency on the -sdk versions of them.
 do_configure_append () {
 	cd ${B}
+	oe_runconf
 	oe_runmake configure-host
 	sed -e 's,-lncurses,${STAGING_LIBDIR_NATIVE}/libncurses.a ${STAGING_LIBDIR_NATIVE}/libtinfo.a ,g' -i ${B}/gdb/Makefile
 	sed -e 's,-lz, ${STAGING_LIBDIR_NATIVE}/libz.a ,g' -i ${B}/gdb/Makefile
@@ -16,5 +17,4 @@ do_configure_append () {
 	for SIM in ${B}/sim/*/Makefile; do
 		[ -f $SIM ] && sed -e 's,-lz, ${STAGING_LIBDIR_NATIVE}/libz.a ,g' -i $SIM
 	done
-	oe_runconf
 }
-- 
1.6.3.3

Re: [PATCH] gdb-cross-sdk: don't reconfigure after making changes in gdb/Makefile

[Tom Rini]

Eric Bénard wrote:
> Le 02/11/2010 05:41, Khem Raj a écrit :
>> On Mon, Nov 1, 2010 at 2:29 PM, Eric Bénard<eric@eukrea.com>  wrote:
>>> else we don't statically link libncurses, libtinfo and libz which leads
>>> to :
>>> /usr/local/angstrom/arm/bin/arm-angstrom-linux-gnueabi-gdb:
>>> error while loading shared libraries: libtinfo.so.5:
>>> cannot open shared object file: No such file or directory
>>>
>>> when trying to use the toolchain.
>>
>> could you run oe_runconf and then do the Makefile editing ? that way
>> it will work as expected.
>> we sort of need oe_runconf
>>
> the makefile we hack with sed is not created after oe_runconf, it's 
> generated by oe_runmake configure-host
> So what should work is :
> oe_runconf
> oe_runmake
> then sed

Can we look at NOT doing the dance we're doing here and instead try the 
normal autotools stuff?  The "we need to not do ..." stuff looks to be 
an ancient artifact.

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH] gdb-cross-sdk: don't reconfigure after making changes in gdb/Makefile

[Eric Bénard]

Le 02/11/2010 15:57, Tom Rini a écrit :
> Can we look at NOT doing the dance we're doing here and instead try the normal
> autotools stuff? The "we need to not do ..." stuff looks to be an ancient
> artifact.
>
following the recent changes in this file we have a regression : some libs are 
no more statically linked in gdb and this patch fix this regression.
Can we apply it and then we can think on a better way to rewrite these 
recipes. After a few tries, switching to autotools doesn't work out of the box 
because gdb is waiting for autoconf 2.64 when we have 2.65.

Eric

Re: [PATCH] gdb-cross-sdk: reconfigure before running oe_runmake configure-host

[Khem Raj]

On Tue, Nov 2, 2010 at 7:56 AM, Eric Bénard <eric@eukrea.com> wrote:
> so we have : configure then make configure-host which generates the
> Makefile that we modify using sed to statically link the libs
>
> Without this patch, we don't statically link libncurses, libtinfo
> and libz which leads to :
> /usr/local/angstrom/arm/bin/arm-angstrom-linux-gnueabi-gdb:
> error while loading shared libraries: libtinfo.so.5:
> cannot open shared object file: No such file or directory
>
> when trying to use the toolchain.
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>

Acked-by: Khem Raj <raj.khem@gmail.com>

> ---
>  recipes/gdb/gdb-cross-sdk.inc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/recipes/gdb/gdb-cross-sdk.inc b/recipes/gdb/gdb-cross-sdk.inc
> index 6a708ca..e1d4895 100644
> --- a/recipes/gdb/gdb-cross-sdk.inc
> +++ b/recipes/gdb/gdb-cross-sdk.inc
> @@ -8,6 +8,7 @@ EXTRA_OEMAKE = "'SUBDIRS=intl mmalloc libiberty opcodes bfd sim gdb etc utils' L
>  # add a depenency on the -sdk versions of them.
>  do_configure_append () {
>        cd ${B}
> +       oe_runconf
>        oe_runmake configure-host
>        sed -e 's,-lncurses,${STAGING_LIBDIR_NATIVE}/libncurses.a ${STAGING_LIBDIR_NATIVE}/libtinfo.a ,g' -i ${B}/gdb/Makefile
>        sed -e 's,-lz, ${STAGING_LIBDIR_NATIVE}/libz.a ,g' -i ${B}/gdb/Makefile
> @@ -16,5 +17,4 @@ do_configure_append () {
>        for SIM in ${B}/sim/*/Makefile; do
>                [ -f $SIM ] && sed -e 's,-lz, ${STAGING_LIBDIR_NATIVE}/libz.a ,g' -i $SIM
>        done
> -       oe_runconf
>  }
> --
> 1.6.3.3
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] gdb-cross-sdk: don't reconfigure after making changes in gdb/Makefile

[Tom Rini]

Eric Bénard wrote:
> Le 02/11/2010 15:57, Tom Rini a écrit :
>> Can we look at NOT doing the dance we're doing here and instead try 
>> the normal
>> autotools stuff? The "we need to not do ..." stuff looks to be an ancient
>> artifact.
>>
> following the recent changes in this file we have a regression : some 
> libs are no more statically linked in gdb and this patch fix this 
> regression.
> Can we apply it and then we can think on a better way to rewrite these 
> recipes. After a few tries, switching to autotools doesn't work out of 
> the box because gdb is waiting for autoconf 2.64 when we have 2.65.

OK, yes, since you've found it to be non-trivial, it can be done a 
little bit later.  Thanks!

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH] gdb-cross-sdk: reconfigure before running oe_runmake configure-host

[Tom Rini]

Khem Raj wrote:
> On Tue, Nov 2, 2010 at 7:56 AM, Eric Bénard <eric@eukrea.com> wrote:
>> so we have : configure then make configure-host which generates the
>> Makefile that we modify using sed to statically link the libs
>>
>> Without this patch, we don't statically link libncurses, libtinfo
>> and libz which leads to :
>> /usr/local/angstrom/arm/bin/arm-angstrom-linux-gnueabi-gdb:
>> error while loading shared libraries: libtinfo.so.5:
>> cannot open shared object file: No such file or directory
>>
>> when trying to use the toolchain.
>>
>> Signed-off-by: Eric Bénard <eric@eukrea.com>
> 
> Acked-by: Khem Raj <raj.khem@gmail.com>

Acked-by: Tom Rini <tom_rini@mentor.com>

> 
>> ---
>>  recipes/gdb/gdb-cross-sdk.inc |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/recipes/gdb/gdb-cross-sdk.inc b/recipes/gdb/gdb-cross-sdk.inc
>> index 6a708ca..e1d4895 100644
>> --- a/recipes/gdb/gdb-cross-sdk.inc
>> +++ b/recipes/gdb/gdb-cross-sdk.inc
>> @@ -8,6 +8,7 @@ EXTRA_OEMAKE = "'SUBDIRS=intl mmalloc libiberty opcodes bfd sim gdb etc utils' L
>>  # add a depenency on the -sdk versions of them.
>>  do_configure_append () {
>>        cd ${B}
>> +       oe_runconf
>>        oe_runmake configure-host
>>        sed -e 's,-lncurses,${STAGING_LIBDIR_NATIVE}/libncurses.a ${STAGING_LIBDIR_NATIVE}/libtinfo.a ,g' -i ${B}/gdb/Makefile
>>        sed -e 's,-lz, ${STAGING_LIBDIR_NATIVE}/libz.a ,g' -i ${B}/gdb/Makefile
>> @@ -16,5 +17,4 @@ do_configure_append () {
>>        for SIM in ${B}/sim/*/Makefile; do
>>                [ -f $SIM ] && sed -e 's,-lz, ${STAGING_LIBDIR_NATIVE}/libz.a ,g' -i $SIM
>>        done
>> -       oe_runconf
>>  }
>> --
>> 1.6.3.3
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel


-- 
Tom Rini
Mentor Graphics Corporation