From: Stepan Moskovchenko <stepanm@codeaurora.org> To: dwalker@codeaurora.org Cc: davidb@codeaurora.org, bryanh@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stepan Moskovchenko <stepanm@codeaurora.org> Subject: [PATCH 08/14] msm: iommu: Don't flush page tables if no devices attached Date: Fri, 12 Nov 2010 19:29:54 -0800 [thread overview] Message-ID: <1289619000-13167-9-git-send-email-stepanm@codeaurora.org> (raw) In-Reply-To: <1289619000-13167-1-git-send-email-stepanm@codeaurora.org> Don't flush the page tables on an IOMMU domain if there are no IOMMU devices attached to the domain. The act of attaching to the domain will cause an implicit flush of those areas if the page tables are configured to not be L2 cacheable. Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org> --- arch/arm/mach-msm/iommu.c | 15 +++++++++------ 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-msm/iommu.c b/arch/arm/mach-msm/iommu.c index 134add7..74f2157 100644 --- a/arch/arm/mach-msm/iommu.c +++ b/arch/arm/mach-msm/iommu.c @@ -50,13 +50,16 @@ static void __flush_iotlb(struct iommu_domain *domain) unsigned long *fl_table = priv->pgtable; int i; - dmac_flush_range(fl_table, fl_table + SZ_16K); + if (!list_empty(&priv->list_attached)) { + dmac_flush_range(fl_table, fl_table + SZ_16K); - for (i = 0; i < NUM_FL_PTE; i++) - if ((fl_table[i] & 0x03) == FL_TYPE_TABLE) { - void *sl_table = __va(fl_table[i] & FL_BASE_MASK); - dmac_flush_range(sl_table, sl_table + SZ_4K); - } + for (i = 0; i < NUM_FL_PTE; i++) + if ((fl_table[i] & 0x03) == FL_TYPE_TABLE) { + void *sl_table = __va(fl_table[i] & + FL_BASE_MASK); + dmac_flush_range(sl_table, sl_table + SZ_4K); + } + } #endif list_for_each_entry(ctx_drvdata, &priv->list_attached, attached_elm) { -- 1.7.0.2 Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: stepanm@codeaurora.org (Stepan Moskovchenko) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 08/14] msm: iommu: Don't flush page tables if no devices attached Date: Fri, 12 Nov 2010 19:29:54 -0800 [thread overview] Message-ID: <1289619000-13167-9-git-send-email-stepanm@codeaurora.org> (raw) In-Reply-To: <1289619000-13167-1-git-send-email-stepanm@codeaurora.org> Don't flush the page tables on an IOMMU domain if there are no IOMMU devices attached to the domain. The act of attaching to the domain will cause an implicit flush of those areas if the page tables are configured to not be L2 cacheable. Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org> --- arch/arm/mach-msm/iommu.c | 15 +++++++++------ 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-msm/iommu.c b/arch/arm/mach-msm/iommu.c index 134add7..74f2157 100644 --- a/arch/arm/mach-msm/iommu.c +++ b/arch/arm/mach-msm/iommu.c @@ -50,13 +50,16 @@ static void __flush_iotlb(struct iommu_domain *domain) unsigned long *fl_table = priv->pgtable; int i; - dmac_flush_range(fl_table, fl_table + SZ_16K); + if (!list_empty(&priv->list_attached)) { + dmac_flush_range(fl_table, fl_table + SZ_16K); - for (i = 0; i < NUM_FL_PTE; i++) - if ((fl_table[i] & 0x03) == FL_TYPE_TABLE) { - void *sl_table = __va(fl_table[i] & FL_BASE_MASK); - dmac_flush_range(sl_table, sl_table + SZ_4K); - } + for (i = 0; i < NUM_FL_PTE; i++) + if ((fl_table[i] & 0x03) == FL_TYPE_TABLE) { + void *sl_table = __va(fl_table[i] & + FL_BASE_MASK); + dmac_flush_range(sl_table, sl_table + SZ_4K); + } + } #endif list_for_each_entry(ctx_drvdata, &priv->list_attached, attached_elm) { -- 1.7.0.2 Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-11-13 3:30 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-11-13 3:29 [PATCH 00/14] Improvements to the MSM IOMMU driver Stepan Moskovchenko 2010-11-13 3:29 ` Stepan Moskovchenko 2010-11-13 3:29 ` [PATCH 01/14] msm: iommu: Increase maximum MID size to 5 bits Stepan Moskovchenko 2010-11-13 3:29 ` Stepan Moskovchenko 2010-11-13 3:29 ` [PATCH 02/14] msm: iomap: Addresses and IRQs for 2nd GFX core IOMMU Stepan Moskovchenko 2010-11-13 3:29 ` Stepan Moskovchenko 2010-11-13 3:29 ` [PATCH 03/14] msm: iommu: Use more consistent naming in platform data Stepan Moskovchenko 2010-11-13 3:29 ` Stepan Moskovchenko 2010-11-13 3:29 ` [PATCH 04/14] msm: iommu: Revise GFX3D IOMMU contexts and M2V mappings Stepan Moskovchenko 2010-11-13 3:29 ` Stepan Moskovchenko 2010-11-13 3:29 ` [PATCH 05/14] msm: iommu: Revise GFX2D0 " Stepan Moskovchenko 2010-11-13 3:29 ` Stepan Moskovchenko 2010-11-13 3:29 ` [PATCH 06/14] msm: iommu: Support for the 2nd GFX core's IOMMU Stepan Moskovchenko 2010-11-13 3:29 ` Stepan Moskovchenko 2010-11-13 3:29 ` [PATCH 07/14] msm: iommu: Mark functions with the right section names Stepan Moskovchenko 2010-11-13 3:29 ` Stepan Moskovchenko 2010-11-13 3:29 ` Stepan Moskovchenko [this message] 2010-11-13 3:29 ` [PATCH 08/14] msm: iommu: Don't flush page tables if no devices attached Stepan Moskovchenko 2010-11-13 3:29 ` [PATCH 09/14] msm: iommu: Kconfig option for cacheable page tables Stepan Moskovchenko 2010-11-13 3:29 ` Stepan Moskovchenko 2010-11-14 20:17 ` Daniel Walker 2010-11-14 20:17 ` Daniel Walker 2010-11-15 2:56 ` Stepan Moskovchenko 2010-11-15 2:56 ` Stepan Moskovchenko 2010-11-15 2:56 ` Stepan Moskovchenko 2010-11-15 18:20 ` Daniel Walker 2010-11-15 18:20 ` Daniel Walker 2010-11-15 18:20 ` Daniel Walker 2010-11-16 1:47 ` Stepan Moskovchenko 2010-11-16 1:47 ` Stepan Moskovchenko 2010-11-16 1:47 ` Stepan Moskovchenko 2010-11-16 1:46 ` [PATCH 09/14 v2] msm: iommu: Kconfig item " Stepan Moskovchenko 2010-11-16 1:46 ` Stepan Moskovchenko 2010-11-13 3:29 ` [PATCH 10/14] msm: iommu: Check if device is already attached Stepan Moskovchenko 2010-11-13 3:29 ` Stepan Moskovchenko 2010-11-13 3:29 ` [PATCH 11/14] msm: iommu: Kconfig dependency for the IOMMU API Stepan Moskovchenko 2010-11-13 3:29 ` Stepan Moskovchenko 2010-11-13 3:29 ` [PATCH 12/14] msm: iommu: Definitions for extended memory attributes Stepan Moskovchenko 2010-11-13 3:29 ` Stepan Moskovchenko 2010-11-16 2:19 ` [PATCH 12/14 v2] " Stepan Moskovchenko 2010-11-16 2:19 ` Stepan Moskovchenko 2010-11-13 3:29 ` [PATCH 13/14] msm: iommu: Support cache-coherent memory access Stepan Moskovchenko 2010-11-13 3:29 ` Stepan Moskovchenko 2010-11-16 2:20 ` [PATCH 13/14 v2] " Stepan Moskovchenko 2010-11-16 2:20 ` Stepan Moskovchenko 2010-11-13 3:30 ` [PATCH 14/14] msm: iommu: Miscellaneous code cleanup Stepan Moskovchenko 2010-11-13 3:30 ` Stepan Moskovchenko 2010-11-16 0:25 ` Daniel Walker 2010-11-16 0:25 ` Daniel Walker 2010-11-16 1:16 ` Stepan Moskovchenko 2010-11-16 1:16 ` Stepan Moskovchenko 2010-11-16 20:45 ` Daniel Walker 2010-11-16 20:45 ` Daniel Walker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1289619000-13167-9-git-send-email-stepanm@codeaurora.org \ --to=stepanm@codeaurora.org \ --cc=bryanh@codeaurora.org \ --cc=davidb@codeaurora.org \ --cc=dwalker@codeaurora.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.