All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vasiliy Kulikov <segoon@openwall.com>
To: kernel-janitors@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Feng Tang <feng.tang@intel.com>,
	Alan Cox <alan@linux.intel.com>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code
Date: Thu, 18 Nov 2010 21:16:45 +0300	[thread overview]
Message-ID: <1290104207-31279-1-git-send-email-segoon@openwall.com> (raw)

platform_device_register() may fail, if so propagate the return
code from mrst_device_create().

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
---
 I cannot compile this driver in next-20101117, so it is not tested at all.

 arch/x86/platform/mrst/vrtc.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/x86/platform/mrst/vrtc.c b/arch/x86/platform/mrst/vrtc.c
index 4d3f770..32cd7ed 100644
--- a/arch/x86/platform/mrst/vrtc.c
+++ b/arch/x86/platform/mrst/vrtc.c
@@ -159,8 +159,7 @@ static int __init mrst_device_create(void)
 	vrtc_resources[1].start = sfi_mrtc_array[0].irq;
 	vrtc_resources[1].end = sfi_mrtc_array[0].irq;
 
-	platform_device_register(&vrtc_device);
-	return 0;
+	return platform_device_register(&vrtc_device);
 }
 
 module_init(mrst_device_create);
-- 
1.7.0.4


WARNING: multiple messages have this Message-ID (diff)
From: Vasiliy Kulikov <segoon@openwall.com>
To: kernel-janitors@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Feng Tang <feng.tang@intel.com>,
	Alan Cox <alan@linux.intel.com>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code
Date: Thu, 18 Nov 2010 18:16:45 +0000	[thread overview]
Message-ID: <1290104207-31279-1-git-send-email-segoon@openwall.com> (raw)

platform_device_register() may fail, if so propagate the return
code from mrst_device_create().

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
---
 I cannot compile this driver in next-20101117, so it is not tested at all.

 arch/x86/platform/mrst/vrtc.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/x86/platform/mrst/vrtc.c b/arch/x86/platform/mrst/vrtc.c
index 4d3f770..32cd7ed 100644
--- a/arch/x86/platform/mrst/vrtc.c
+++ b/arch/x86/platform/mrst/vrtc.c
@@ -159,8 +159,7 @@ static int __init mrst_device_create(void)
 	vrtc_resources[1].start = sfi_mrtc_array[0].irq;
 	vrtc_resources[1].end = sfi_mrtc_array[0].irq;
 
-	platform_device_register(&vrtc_device);
-	return 0;
+	return platform_device_register(&vrtc_device);
 }
 
 module_init(mrst_device_create);
-- 
1.7.0.4


             reply	other threads:[~2010-11-18 18:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18 18:16 Vasiliy Kulikov [this message]
2010-11-18 18:16 ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Vasiliy Kulikov
2010-11-18 18:18 ` Alan Cox
2010-11-18 18:18   ` [PATCH 1/4] x86: platform: mrst: check Alan Cox
2010-11-18 18:44   ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Vasiliy Kulikov
2010-11-18 18:44     ` [PATCH 1/4] x86: platform: mrst: check Vasiliy Kulikov
2010-11-18 20:18     ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Alan Cox
2010-11-18 20:18       ` [PATCH 1/4] x86: platform: mrst: check Alan Cox
2010-11-18 21:27       ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Thomas Gleixner
2010-11-18 21:27         ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() Thomas Gleixner
2010-11-18 20:19 ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Alan Cox
2010-11-18 20:19   ` [PATCH 1/4] x86: platform: mrst: check Alan Cox
2010-11-18 21:49 ` [tip:x86/platform] x86, mrst: Check platform_device_register() return code tip-bot for Vasiliy Kulikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290104207-31279-1-git-send-email-segoon@openwall.com \
    --to=segoon@openwall.com \
    --cc=alan@linux.intel.com \
    --cc=arjan@linux.intel.com \
    --cc=feng.tang@intel.com \
    --cc=hpa@zytor.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.