From: Thomas Gleixner <tglx@linutronix.de> To: Alan Cox <alan@linux.intel.com> Cc: Vasiliy Kulikov <segoon@openwall.com>, kernel-janitors@vger.kernel.org, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org, Feng Tang <feng.tang@intel.com>, Arjan van de Ven <arjan@linux.intel.com>, Jacob Pan <jacob.jun.pan@linux.intel.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Date: Thu, 18 Nov 2010 22:27:10 +0100 (CET) [thread overview] Message-ID: <alpine.LFD.2.00.1011182224590.2900@localhost6.localdomain6> (raw) In-Reply-To: <20101118201808.06731611@linux.intel.com> On Thu, 18 Nov 2010, Alan Cox wrote: > On Thu, 18 Nov 2010 21:44:21 +0300 > Vasiliy Kulikov <segoon@openwall.com> wrote: > > > On Thu, Nov 18, 2010 at 18:18 +0000, Alan Cox wrote: > > > > I cannot compile this driver in next-20101117, so it is not > > > > tested at all. > > > > > > Compile or test - if it bombs out compiling for you please send me > > > (off list the .config that fails so I can fix that > > > > > > Otherwise NAK the patch because it needs to do the cleanup but > > > thanks for finding the bug - you've done the hard 99% > > > > make -C /home/vasya/linux arch/x86/platform/mrst/vrtc.o > > make: Entering directory `/home/vasya/dev/linux-next' > > CHK include/linux/version.h > > CHK include/generated/utsrelease.h > > CALL scripts/checksyscalls.sh > > CC arch/x86/platform/mrst/vrtc.o > > arch/x86/platform/mrst/vrtc.c: In function 'mrst_rtc_init': > > arch/x86/platform/mrst/vrtc.c:113: error: 'FIX_LNW_VRTC' undeclared > > (first use in this function) arch/x86/platform/mrst/vrtc.c:113: > > error: (Each undeclared identifier is reported only once > > arch/x86/platform/mrst/vrtc.c:113: error: for each function it > > appears in.) make[1]: *** [arch/x86/platform/mrst/vrtc.o] Error 1 > > > > Both with allyesconfig and allmodconfig, x86_64. > > I can't duplicate this. > > It's defined if CONFIG_X86_MRST is defined, and the file in question is > only compiled if CONFIG_X86_MRST is defined Of course you can't duplicate this: > > make -C /home/vasya/linux arch/x86/platform/mrst/vrtc.o Vasiliy forced a manual compile of that file with a 64bit config which has CONFIG_X86_MRST=n. That's PEBKAC not a build failure :) Thanks, tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de> To: Alan Cox <alan@linux.intel.com> Cc: Vasiliy Kulikov <segoon@openwall.com>, kernel-janitors@vger.kernel.org, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org, Feng Tang <feng.tang@intel.com>, Arjan van de Ven <arjan@linux.intel.com>, Jacob Pan <jacob.jun.pan@linux.intel.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] x86: platform: mrst: check platform_device_register() Date: Thu, 18 Nov 2010 21:27:10 +0000 [thread overview] Message-ID: <alpine.LFD.2.00.1011182224590.2900@localhost6.localdomain6> (raw) In-Reply-To: <20101118201808.06731611@linux.intel.com> On Thu, 18 Nov 2010, Alan Cox wrote: > On Thu, 18 Nov 2010 21:44:21 +0300 > Vasiliy Kulikov <segoon@openwall.com> wrote: > > > On Thu, Nov 18, 2010 at 18:18 +0000, Alan Cox wrote: > > > > I cannot compile this driver in next-20101117, so it is not > > > > tested at all. > > > > > > Compile or test - if it bombs out compiling for you please send me > > > (off list the .config that fails so I can fix that > > > > > > Otherwise NAK the patch because it needs to do the cleanup but > > > thanks for finding the bug - you've done the hard 99% > > > > make -C /home/vasya/linux arch/x86/platform/mrst/vrtc.o > > make: Entering directory `/home/vasya/dev/linux-next' > > CHK include/linux/version.h > > CHK include/generated/utsrelease.h > > CALL scripts/checksyscalls.sh > > CC arch/x86/platform/mrst/vrtc.o > > arch/x86/platform/mrst/vrtc.c: In function 'mrst_rtc_init': > > arch/x86/platform/mrst/vrtc.c:113: error: 'FIX_LNW_VRTC' undeclared > > (first use in this function) arch/x86/platform/mrst/vrtc.c:113: > > error: (Each undeclared identifier is reported only once > > arch/x86/platform/mrst/vrtc.c:113: error: for each function it > > appears in.) make[1]: *** [arch/x86/platform/mrst/vrtc.o] Error 1 > > > > Both with allyesconfig and allmodconfig, x86_64. > > I can't duplicate this. > > It's defined if CONFIG_X86_MRST is defined, and the file in question is > only compiled if CONFIG_X86_MRST is defined Of course you can't duplicate this: > > make -C /home/vasya/linux arch/x86/platform/mrst/vrtc.o Vasiliy forced a manual compile of that file with a 64bit config which has CONFIG_X86_MRST=n. That's PEBKAC not a build failure :) Thanks, tglx
next prev parent reply other threads:[~2010-11-18 21:27 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-11-18 18:16 [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Vasiliy Kulikov 2010-11-18 18:16 ` Vasiliy Kulikov 2010-11-18 18:18 ` Alan Cox 2010-11-18 18:18 ` [PATCH 1/4] x86: platform: mrst: check Alan Cox 2010-11-18 18:44 ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Vasiliy Kulikov 2010-11-18 18:44 ` [PATCH 1/4] x86: platform: mrst: check Vasiliy Kulikov 2010-11-18 20:18 ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Alan Cox 2010-11-18 20:18 ` [PATCH 1/4] x86: platform: mrst: check Alan Cox 2010-11-18 21:27 ` Thomas Gleixner [this message] 2010-11-18 21:27 ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() Thomas Gleixner 2010-11-18 20:19 ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Alan Cox 2010-11-18 20:19 ` [PATCH 1/4] x86: platform: mrst: check Alan Cox 2010-11-18 21:49 ` [tip:x86/platform] x86, mrst: Check platform_device_register() return code tip-bot for Vasiliy Kulikov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.LFD.2.00.1011182224590.2900@localhost6.localdomain6 \ --to=tglx@linutronix.de \ --cc=alan@linux.intel.com \ --cc=arjan@linux.intel.com \ --cc=feng.tang@intel.com \ --cc=hpa@zytor.com \ --cc=jacob.jun.pan@linux.intel.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=segoon@openwall.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.