From: Joe Perches <joe@perches.com>
To: Daniel Walker <dwalker@codeaurora.org>
Cc: Dima Zavin <dmitriyz@google.com>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, davidb@codeaurora.org
Subject: Re: [PATCH 0/7] Nexus One Support
Date: Thu, 20 Jan 2011 18:25:30 -0800 [thread overview]
Message-ID: <1295576730.4096.24.camel@Joe-Laptop> (raw)
In-Reply-To: <1295575123.9236.54.camel@m0nster>
On Thu, 2011-01-20 at 17:58 -0800, Daniel Walker wrote:
> On Thu, 2011-01-20 at 17:41 -0800, Joe Perches wrote:
> > On Thu, 2011-01-20 at 16:55 -0800, Daniel Walker wrote:
> > > On Thu, 2011-01-20 at 16:42 -0800, Dima Zavin wrote:
> > > > You are not the author of any of these patches. Where are the author
> > > > attributions for the team that actually wrote this code?
> > > In the commit text.. The author field is used to denote who authored the
> > > commit, which in this case is me.
> > You have that wrong.
> > Author and Committer are different git fields.
> > http://www.kernel.org/pub/software/scm/git/docs/user-manual.html
> >
> > * an author: The name of the person responsible for this change,
> > together with its date.
> > * a committer: The name of the person who actually created the
> > commit, with the date it was done. This may be different from
> > the author, for example, if the author was someone who wrote a
> > patch and emailed it to the person who used it to create the
> > commit.
> I'm not even sure how to make these different, but in this case it
> doesn't matter because the "committer" as you defined it above is more
> than one person ..
Not really, no.
The authors may be different, but the first git
committer of the patch is different.
The committer is the person that does a git commit
either directly with git commit or git am.
If a git tree is pulled by someone else, the initial
committer name remains on the commit.
You should keep the original patch author names and
add your own "Signed-off-by:" and not claim authorship
of the patches themselves.
cheers, Joe
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/7] Nexus One Support
Date: Thu, 20 Jan 2011 18:25:30 -0800 [thread overview]
Message-ID: <1295576730.4096.24.camel@Joe-Laptop> (raw)
In-Reply-To: <1295575123.9236.54.camel@m0nster>
On Thu, 2011-01-20 at 17:58 -0800, Daniel Walker wrote:
> On Thu, 2011-01-20 at 17:41 -0800, Joe Perches wrote:
> > On Thu, 2011-01-20 at 16:55 -0800, Daniel Walker wrote:
> > > On Thu, 2011-01-20 at 16:42 -0800, Dima Zavin wrote:
> > > > You are not the author of any of these patches. Where are the author
> > > > attributions for the team that actually wrote this code?
> > > In the commit text.. The author field is used to denote who authored the
> > > commit, which in this case is me.
> > You have that wrong.
> > Author and Committer are different git fields.
> > http://www.kernel.org/pub/software/scm/git/docs/user-manual.html
> >
> > * an author: The name of the person responsible for this change,
> > together with its date.
> > * a committer: The name of the person who actually created the
> > commit, with the date it was done. This may be different from
> > the author, for example, if the author was someone who wrote a
> > patch and emailed it to the person who used it to create the
> > commit.
> I'm not even sure how to make these different, but in this case it
> doesn't matter because the "committer" as you defined it above is more
> than one person ..
Not really, no.
The authors may be different, but the first git
committer of the patch is different.
The committer is the person that does a git commit
either directly with git commit or git am.
If a git tree is pulled by someone else, the initial
committer name remains on the commit.
You should keep the original patch author names and
add your own "Signed-off-by:" and not claim authorship
of the patches themselves.
cheers, Joe
next prev parent reply other threads:[~2011-01-21 2:25 UTC|newest]
Thread overview: 157+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 20:32 [PATCH 0/7] Nexus One Support Daniel Walker
2011-01-20 20:32 ` Daniel Walker
2011-01-20 20:32 ` [PATCH 1/7] msm: qsd8x50: add uart platform data Daniel Walker
2011-01-20 20:32 ` Daniel Walker
2011-01-20 20:32 ` [PATCH 2/7] [ARM] msm: qsd8k memory base is at 0x20000000 Daniel Walker
2011-01-20 20:32 ` Daniel Walker
2011-01-20 20:32 ` [PATCH 3/7] msm: qsd8x50: add acpuclock code Daniel Walker
2011-01-20 20:32 ` Daniel Walker
2011-01-20 20:32 ` [PATCH 4/7] msm: mahimahi: add mahimahi board file Daniel Walker
2011-01-20 20:32 ` Daniel Walker
2011-01-20 20:32 ` [PATCH 5/7] msm: mahimahi: add in mmc support code Daniel Walker
2011-01-20 20:32 ` Daniel Walker
2011-01-20 20:32 ` [PATCH 6/7] msm: mahimahi: add gpio pin muxing code Daniel Walker
2011-01-20 20:32 ` Daniel Walker
2011-01-20 20:32 ` [PATCH 7/7] msm: mahimahi: initialize mmc at start up Daniel Walker
2011-01-20 20:32 ` Daniel Walker
2011-01-21 0:42 ` [PATCH 0/7] Nexus One Support Dima Zavin
2011-01-21 0:42 ` Dima Zavin
2011-01-21 0:42 ` Dima Zavin
2011-01-21 0:55 ` Daniel Walker
2011-01-21 0:55 ` Daniel Walker
2011-01-21 1:41 ` Joe Perches
2011-01-21 1:41 ` Joe Perches
2011-01-21 1:58 ` Daniel Walker
2011-01-21 1:58 ` Daniel Walker
2011-01-21 2:13 ` Dima Zavin
2011-01-21 2:13 ` Dima Zavin
2011-01-21 15:47 ` Daniel Walker
2011-01-21 15:47 ` Daniel Walker
2011-01-21 2:25 ` Joe Perches [this message]
2011-01-21 2:25 ` Joe Perches
2011-01-21 3:41 ` Theodore Tso
2011-01-21 3:41 ` Theodore Tso
2011-01-21 15:46 ` Daniel Walker
2011-01-21 15:46 ` Daniel Walker
2011-01-21 17:48 ` Jesse Barnes
2011-01-21 17:48 ` Jesse Barnes
2011-01-21 17:56 ` Daniel Walker
2011-01-21 17:56 ` Daniel Walker
2011-01-21 17:59 ` Christoph Hellwig
2011-01-21 17:59 ` Christoph Hellwig
2011-01-21 17:56 ` Jesse Barnes
2011-01-21 17:56 ` Jesse Barnes
2011-01-21 17:56 ` Jesse Barnes
2011-01-21 18:00 ` Daniel Walker
2011-01-21 18:00 ` Daniel Walker
2011-01-21 18:04 ` Jesse Barnes
2011-01-21 18:04 ` Jesse Barnes
2011-01-21 18:18 ` Daniel Walker
2011-01-21 18:18 ` Daniel Walker
2011-01-21 18:27 ` Jesse Barnes
2011-01-21 18:27 ` Jesse Barnes
2011-01-21 18:35 ` Daniel Walker
2011-01-21 18:35 ` Daniel Walker
2011-01-21 20:44 ` Dima Zavin
2011-01-21 20:44 ` Dima Zavin
2011-01-21 20:49 ` Daniel Walker
2011-01-21 20:49 ` Daniel Walker
2011-01-21 20:49 ` Daniel Walker
2011-01-21 21:01 ` Jesse Barnes
2011-01-21 21:01 ` Jesse Barnes
2011-01-21 21:01 ` Jesse Barnes
2011-01-21 21:26 ` Daniel Walker
2011-01-21 21:26 ` Daniel Walker
2011-01-21 21:42 ` Dima Zavin
2011-01-21 21:42 ` Dima Zavin
2011-01-21 21:42 ` Dima Zavin
2011-01-22 13:58 ` David Woodhouse
2011-01-22 13:58 ` David Woodhouse
2011-01-21 21:02 ` Joe Perches
2011-01-21 21:02 ` Joe Perches
2011-01-21 21:02 ` Joe Perches
2011-01-21 21:24 ` Daniel Walker
2011-01-21 21:24 ` Daniel Walker
2011-01-21 21:24 ` Daniel Walker
2011-01-22 11:18 ` Pekka Enberg
2011-01-22 11:18 ` Pekka Enberg
2011-01-22 11:18 ` Pekka Enberg
2011-01-22 12:20 ` Russell King - ARM Linux
2011-01-22 12:20 ` Russell King - ARM Linux
2011-01-22 18:06 ` Dima Zavin
2011-01-22 18:06 ` Dima Zavin
2011-01-22 18:06 ` Dima Zavin
2011-01-22 18:49 ` Russell King - ARM Linux
2011-01-22 18:49 ` Russell King - ARM Linux
2011-01-22 18:49 ` Russell King - ARM Linux
2011-01-22 20:50 ` Christoph Hellwig
2011-01-22 20:50 ` Christoph Hellwig
2011-01-22 19:22 ` Brian Swetland
2011-01-22 19:22 ` Brian Swetland
2011-01-22 19:49 ` Nicolas Pitre
2011-01-22 19:49 ` Nicolas Pitre
2011-01-22 19:59 ` Brian Swetland
2011-01-22 19:59 ` Brian Swetland
2011-01-22 19:59 ` Brian Swetland
2011-01-22 20:53 ` Christoph Hellwig
2011-01-22 20:53 ` Christoph Hellwig
2011-01-22 21:04 ` Russell King - ARM Linux
2011-01-22 21:04 ` Russell King - ARM Linux
2011-01-22 21:57 ` Alan Cox
2011-01-22 21:57 ` Alan Cox
2011-01-23 2:38 ` David Woodhouse
2011-01-23 2:38 ` David Woodhouse
2011-01-22 20:41 ` Christoph Hellwig
2011-01-22 20:41 ` Christoph Hellwig
2011-01-21 21:05 ` Pekka Enberg
2011-01-21 21:05 ` Pekka Enberg
2011-01-21 21:05 ` Pekka Enberg
2011-01-21 21:17 ` Joe Perches
2011-01-21 21:17 ` Joe Perches
2011-01-21 23:49 ` Ted Ts'o
2011-01-21 23:49 ` Ted Ts'o
2011-01-22 0:03 ` Daniel Walker
2011-01-22 0:03 ` Daniel Walker
2011-01-22 1:58 ` Steven Rostedt
2011-01-22 1:58 ` Steven Rostedt
2011-01-22 2:13 ` Daniel Walker
2011-01-22 2:13 ` Daniel Walker
2011-01-22 2:32 ` Steven Rostedt
2011-01-22 2:32 ` Steven Rostedt
2011-01-22 2:31 ` Ted Ts'o
2011-01-22 2:31 ` Ted Ts'o
2011-01-22 8:19 ` Pekka Enberg
2011-01-22 8:19 ` Pekka Enberg
2011-01-22 10:35 ` Dima Zavin
2011-01-22 10:35 ` Dima Zavin
2011-01-22 10:35 ` Dima Zavin
2011-01-22 10:45 ` Anca Emanuel
2011-01-22 10:45 ` Anca Emanuel
2011-01-22 10:45 ` Anca Emanuel
2011-01-22 11:03 ` Pekka Enberg
2011-01-22 11:03 ` Pekka Enberg
2011-01-22 11:15 ` Pekka Enberg
2011-01-22 11:15 ` Pekka Enberg
2011-01-22 17:28 ` Thomas Gleixner
2011-01-22 17:28 ` Thomas Gleixner
2011-01-22 18:07 ` Denis 'GNUtoo' Carikli
2011-01-22 18:07 ` Denis 'GNUtoo' Carikli
2011-01-22 18:07 ` Denis 'GNUtoo' Carikli
2011-01-22 18:15 ` Dima Zavin
2011-01-22 18:15 ` Dima Zavin
2011-01-22 18:15 ` Dima Zavin
2011-01-22 20:55 ` Christoph Hellwig
2011-01-22 20:55 ` Christoph Hellwig
2011-01-22 21:56 ` Pekka Enberg
2011-01-22 21:56 ` Pekka Enberg
2011-01-22 21:56 ` Pekka Enberg
2011-01-22 21:58 ` Christoph Hellwig
2011-01-22 21:58 ` Christoph Hellwig
2011-01-22 22:13 ` Pekka Enberg
2011-01-22 22:13 ` Pekka Enberg
2011-01-22 22:13 ` Pekka Enberg
2011-02-04 13:36 ` Pavel Machek
2011-02-04 13:36 ` Pavel Machek
2011-02-07 17:36 ` Daniel Walker
2011-02-07 17:36 ` Daniel Walker
2011-02-07 17:36 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295576730.4096.24.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davidb@codeaurora.org \
--cc=dmitriyz@google.com \
--cc=dwalker@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.