From: Pekka Enberg <penberg@kernel.org> To: Ted Ts'o <tytso@mit.edu> Cc: Daniel Walker <dwalker@codeaurora.org>, Dima Zavin <dmitriyz@google.com>, Jesse Barnes <jbarnes@virtuousgeek.org>, Joe Perches <joe@perches.com>, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, davidb@codeaurora.org Subject: Re: [PATCH 0/7] Nexus One Support Date: Sat, 22 Jan 2011 10:19:58 +0200 [thread overview] Message-ID: <1295684398.19231.47.camel@jaguar> (raw) In-Reply-To: <20110121234930.GK3043@thunk.org> Hi Ted, On Fri, Jan 21, 2011 at 10:49 PM, Daniel Walker <dwalker@codeaurora.org> wrote: > > > I'll add this list into the commit text .. On Fri, Jan 21, 2011 at 11:05:54PM +0200, Pekka Enberg wrote: > > So why is everyone bitching at Daniel when he's doing something the > > Android folks should have done themselves a long time ago? On Fri, 2011-01-21 at 18:49 -0500, Ted Ts'o wrote: > Two wrongs don't make a right. And it's not like not submitting > changes is wrong, although granted it's not ideal. (I'd say removing > attribution from a git commit is even worse. If you're doing the > equivalent of a cherry pick, you should preserve the Author field. > Even if you're doing some cleanup work, as the maintainer I generally > preserve the Author line, and will simply add the fact that I did some > cleanup to the commit body. The question is who did more work; the > person who originally submitted the code, or the person who did the > cleanup.) Sure, it would have been nicer for everyone involved if Daniel would have kept the original patches and added new patches to clean it up on top of that to preserve the history. However, I don't understand the harsh comments when this looks like a honest mistake! And I especially don't understand the almost hostile attitude of the Android developers who have been sitting on these patches for over a year now AFAICT. Pekka
WARNING: multiple messages have this Message-ID (diff)
From: penberg@kernel.org (Pekka Enberg) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/7] Nexus One Support Date: Sat, 22 Jan 2011 10:19:58 +0200 [thread overview] Message-ID: <1295684398.19231.47.camel@jaguar> (raw) In-Reply-To: <20110121234930.GK3043@thunk.org> Hi Ted, On Fri, Jan 21, 2011 at 10:49 PM, Daniel Walker <dwalker@codeaurora.org> wrote: > > > I'll add this list into the commit text .. On Fri, Jan 21, 2011 at 11:05:54PM +0200, Pekka Enberg wrote: > > So why is everyone bitching at Daniel when he's doing something the > > Android folks should have done themselves a long time ago? On Fri, 2011-01-21 at 18:49 -0500, Ted Ts'o wrote: > Two wrongs don't make a right. And it's not like not submitting > changes is wrong, although granted it's not ideal. (I'd say removing > attribution from a git commit is even worse. If you're doing the > equivalent of a cherry pick, you should preserve the Author field. > Even if you're doing some cleanup work, as the maintainer I generally > preserve the Author line, and will simply add the fact that I did some > cleanup to the commit body. The question is who did more work; the > person who originally submitted the code, or the person who did the > cleanup.) Sure, it would have been nicer for everyone involved if Daniel would have kept the original patches and added new patches to clean it up on top of that to preserve the history. However, I don't understand the harsh comments when this looks like a honest mistake! And I especially don't understand the almost hostile attitude of the Android developers who have been sitting on these patches for over a year now AFAICT. Pekka
next prev parent reply other threads:[~2011-01-22 8:20 UTC|newest] Thread overview: 157+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-01-20 20:32 [PATCH 0/7] Nexus One Support Daniel Walker 2011-01-20 20:32 ` Daniel Walker 2011-01-20 20:32 ` [PATCH 1/7] msm: qsd8x50: add uart platform data Daniel Walker 2011-01-20 20:32 ` Daniel Walker 2011-01-20 20:32 ` [PATCH 2/7] [ARM] msm: qsd8k memory base is at 0x20000000 Daniel Walker 2011-01-20 20:32 ` Daniel Walker 2011-01-20 20:32 ` [PATCH 3/7] msm: qsd8x50: add acpuclock code Daniel Walker 2011-01-20 20:32 ` Daniel Walker 2011-01-20 20:32 ` [PATCH 4/7] msm: mahimahi: add mahimahi board file Daniel Walker 2011-01-20 20:32 ` Daniel Walker 2011-01-20 20:32 ` [PATCH 5/7] msm: mahimahi: add in mmc support code Daniel Walker 2011-01-20 20:32 ` Daniel Walker 2011-01-20 20:32 ` [PATCH 6/7] msm: mahimahi: add gpio pin muxing code Daniel Walker 2011-01-20 20:32 ` Daniel Walker 2011-01-20 20:32 ` [PATCH 7/7] msm: mahimahi: initialize mmc at start up Daniel Walker 2011-01-20 20:32 ` Daniel Walker 2011-01-21 0:42 ` [PATCH 0/7] Nexus One Support Dima Zavin 2011-01-21 0:42 ` Dima Zavin 2011-01-21 0:42 ` Dima Zavin 2011-01-21 0:55 ` Daniel Walker 2011-01-21 0:55 ` Daniel Walker 2011-01-21 1:41 ` Joe Perches 2011-01-21 1:41 ` Joe Perches 2011-01-21 1:58 ` Daniel Walker 2011-01-21 1:58 ` Daniel Walker 2011-01-21 2:13 ` Dima Zavin 2011-01-21 2:13 ` Dima Zavin 2011-01-21 15:47 ` Daniel Walker 2011-01-21 15:47 ` Daniel Walker 2011-01-21 2:25 ` Joe Perches 2011-01-21 2:25 ` Joe Perches 2011-01-21 3:41 ` Theodore Tso 2011-01-21 3:41 ` Theodore Tso 2011-01-21 15:46 ` Daniel Walker 2011-01-21 15:46 ` Daniel Walker 2011-01-21 17:48 ` Jesse Barnes 2011-01-21 17:48 ` Jesse Barnes 2011-01-21 17:56 ` Daniel Walker 2011-01-21 17:56 ` Daniel Walker 2011-01-21 17:59 ` Christoph Hellwig 2011-01-21 17:59 ` Christoph Hellwig 2011-01-21 17:56 ` Jesse Barnes 2011-01-21 17:56 ` Jesse Barnes 2011-01-21 17:56 ` Jesse Barnes 2011-01-21 18:00 ` Daniel Walker 2011-01-21 18:00 ` Daniel Walker 2011-01-21 18:04 ` Jesse Barnes 2011-01-21 18:04 ` Jesse Barnes 2011-01-21 18:18 ` Daniel Walker 2011-01-21 18:18 ` Daniel Walker 2011-01-21 18:27 ` Jesse Barnes 2011-01-21 18:27 ` Jesse Barnes 2011-01-21 18:35 ` Daniel Walker 2011-01-21 18:35 ` Daniel Walker 2011-01-21 20:44 ` Dima Zavin 2011-01-21 20:44 ` Dima Zavin 2011-01-21 20:49 ` Daniel Walker 2011-01-21 20:49 ` Daniel Walker 2011-01-21 20:49 ` Daniel Walker 2011-01-21 21:01 ` Jesse Barnes 2011-01-21 21:01 ` Jesse Barnes 2011-01-21 21:01 ` Jesse Barnes 2011-01-21 21:26 ` Daniel Walker 2011-01-21 21:26 ` Daniel Walker 2011-01-21 21:42 ` Dima Zavin 2011-01-21 21:42 ` Dima Zavin 2011-01-21 21:42 ` Dima Zavin 2011-01-22 13:58 ` David Woodhouse 2011-01-22 13:58 ` David Woodhouse 2011-01-21 21:02 ` Joe Perches 2011-01-21 21:02 ` Joe Perches 2011-01-21 21:02 ` Joe Perches 2011-01-21 21:24 ` Daniel Walker 2011-01-21 21:24 ` Daniel Walker 2011-01-21 21:24 ` Daniel Walker 2011-01-22 11:18 ` Pekka Enberg 2011-01-22 11:18 ` Pekka Enberg 2011-01-22 11:18 ` Pekka Enberg 2011-01-22 12:20 ` Russell King - ARM Linux 2011-01-22 12:20 ` Russell King - ARM Linux 2011-01-22 18:06 ` Dima Zavin 2011-01-22 18:06 ` Dima Zavin 2011-01-22 18:06 ` Dima Zavin 2011-01-22 18:49 ` Russell King - ARM Linux 2011-01-22 18:49 ` Russell King - ARM Linux 2011-01-22 18:49 ` Russell King - ARM Linux 2011-01-22 20:50 ` Christoph Hellwig 2011-01-22 20:50 ` Christoph Hellwig 2011-01-22 19:22 ` Brian Swetland 2011-01-22 19:22 ` Brian Swetland 2011-01-22 19:49 ` Nicolas Pitre 2011-01-22 19:49 ` Nicolas Pitre 2011-01-22 19:59 ` Brian Swetland 2011-01-22 19:59 ` Brian Swetland 2011-01-22 19:59 ` Brian Swetland 2011-01-22 20:53 ` Christoph Hellwig 2011-01-22 20:53 ` Christoph Hellwig 2011-01-22 21:04 ` Russell King - ARM Linux 2011-01-22 21:04 ` Russell King - ARM Linux 2011-01-22 21:57 ` Alan Cox 2011-01-22 21:57 ` Alan Cox 2011-01-23 2:38 ` David Woodhouse 2011-01-23 2:38 ` David Woodhouse 2011-01-22 20:41 ` Christoph Hellwig 2011-01-22 20:41 ` Christoph Hellwig 2011-01-21 21:05 ` Pekka Enberg 2011-01-21 21:05 ` Pekka Enberg 2011-01-21 21:05 ` Pekka Enberg 2011-01-21 21:17 ` Joe Perches 2011-01-21 21:17 ` Joe Perches 2011-01-21 23:49 ` Ted Ts'o 2011-01-21 23:49 ` Ted Ts'o 2011-01-22 0:03 ` Daniel Walker 2011-01-22 0:03 ` Daniel Walker 2011-01-22 1:58 ` Steven Rostedt 2011-01-22 1:58 ` Steven Rostedt 2011-01-22 2:13 ` Daniel Walker 2011-01-22 2:13 ` Daniel Walker 2011-01-22 2:32 ` Steven Rostedt 2011-01-22 2:32 ` Steven Rostedt 2011-01-22 2:31 ` Ted Ts'o 2011-01-22 2:31 ` Ted Ts'o 2011-01-22 8:19 ` Pekka Enberg [this message] 2011-01-22 8:19 ` Pekka Enberg 2011-01-22 10:35 ` Dima Zavin 2011-01-22 10:35 ` Dima Zavin 2011-01-22 10:35 ` Dima Zavin 2011-01-22 10:45 ` Anca Emanuel 2011-01-22 10:45 ` Anca Emanuel 2011-01-22 10:45 ` Anca Emanuel 2011-01-22 11:03 ` Pekka Enberg 2011-01-22 11:03 ` Pekka Enberg 2011-01-22 11:15 ` Pekka Enberg 2011-01-22 11:15 ` Pekka Enberg 2011-01-22 17:28 ` Thomas Gleixner 2011-01-22 17:28 ` Thomas Gleixner 2011-01-22 18:07 ` Denis 'GNUtoo' Carikli 2011-01-22 18:07 ` Denis 'GNUtoo' Carikli 2011-01-22 18:07 ` Denis 'GNUtoo' Carikli 2011-01-22 18:15 ` Dima Zavin 2011-01-22 18:15 ` Dima Zavin 2011-01-22 18:15 ` Dima Zavin 2011-01-22 20:55 ` Christoph Hellwig 2011-01-22 20:55 ` Christoph Hellwig 2011-01-22 21:56 ` Pekka Enberg 2011-01-22 21:56 ` Pekka Enberg 2011-01-22 21:56 ` Pekka Enberg 2011-01-22 21:58 ` Christoph Hellwig 2011-01-22 21:58 ` Christoph Hellwig 2011-01-22 22:13 ` Pekka Enberg 2011-01-22 22:13 ` Pekka Enberg 2011-01-22 22:13 ` Pekka Enberg 2011-02-04 13:36 ` Pavel Machek 2011-02-04 13:36 ` Pavel Machek 2011-02-07 17:36 ` Daniel Walker 2011-02-07 17:36 ` Daniel Walker 2011-02-07 17:36 ` Daniel Walker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1295684398.19231.47.camel@jaguar \ --to=penberg@kernel.org \ --cc=davidb@codeaurora.org \ --cc=dmitriyz@google.com \ --cc=dwalker@codeaurora.org \ --cc=jbarnes@virtuousgeek.org \ --cc=joe@perches.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tytso@mit.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.