* [PATCH] video: da8xx-fb: fix fb_probe error path
@ 2011-01-20 3:50 ` Axel Lin
0 siblings, 0 replies; 10+ messages in thread
From: Axel Lin @ 2011-01-20 3:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Paul Mundt, linux-fbdev, Sudhakar Rajashekhara
Current implementation puts CONFIG_CPU_FREQ at wrong place, CONFIG_CPU_FREQ
is for lcd_da8xx_cpufreq_deregister not for unregister_framebuffer.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/video/da8xx-fb.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index c265aed..520047a 100644
--- a/drivers/video/da8xx-fb.c
+++ b/drivers/video/da8xx-fb.c
@@ -1092,9 +1092,10 @@ static int __init fb_probe(struct platform_device *device)
irq_freq:
#ifdef CONFIG_CPU_FREQ
+ lcd_da8xx_cpufreq_deregister(par);
+#endif
err_cpu_freq:
unregister_framebuffer(da8xx_fb_info);
-#endif
err_dealloc_cmap:
fb_dealloc_cmap(&da8xx_fb_info->cmap);
--
1.7.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] video: da8xx-fb: fix fb_probe error path
@ 2011-01-20 3:50 ` Axel Lin
0 siblings, 0 replies; 10+ messages in thread
From: Axel Lin @ 2011-01-20 3:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Paul Mundt, linux-fbdev, Sudhakar Rajashekhara
Current implementation puts CONFIG_CPU_FREQ at wrong place, CONFIG_CPU_FREQ
is for lcd_da8xx_cpufreq_deregister not for unregister_framebuffer.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/video/da8xx-fb.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index c265aed..520047a 100644
--- a/drivers/video/da8xx-fb.c
+++ b/drivers/video/da8xx-fb.c
@@ -1092,9 +1092,10 @@ static int __init fb_probe(struct platform_device *device)
irq_freq:
#ifdef CONFIG_CPU_FREQ
+ lcd_da8xx_cpufreq_deregister(par);
+#endif
err_cpu_freq:
unregister_framebuffer(da8xx_fb_info);
-#endif
err_dealloc_cmap:
fb_dealloc_cmap(&da8xx_fb_info->cmap);
--
1.7.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] video: pxa168fb: remove a redundant pxa168fb_check_var call
@ 2011-01-21 11:18 ` Axel Lin
0 siblings, 0 replies; 10+ messages in thread
From: Axel Lin @ 2011-01-21 11:18 UTC (permalink / raw)
To: linux-kernel
Cc: Lennert Buytenhek, Green Wan, Eric Miao, Marek Vasut,
Haojian Zhuang, linux-fbdev, Paul Mundt, Lennert Buytenhek,
Green Wan, Eric Miao, Marek Vasut, Haojian Zhuang, linux-fbdev,
Paul Mundt
Current implementation calls pxa168fb_check_var twice in pxa168fb_probe.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/video/pxa168fb.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c
index cea6403..35f61dd 100644
--- a/drivers/video/pxa168fb.c
+++ b/drivers/video/pxa168fb.c
@@ -701,16 +701,12 @@ static int __devinit pxa168fb_probe(struct platform_device *pdev)
*/
pxa168fb_init_mode(info, mi);
- ret = pxa168fb_check_var(&info->var, info);
- if (ret)
- goto failed_free_fbmem;
-
/*
* Fill in sane defaults.
*/
ret = pxa168fb_check_var(&info->var, info);
if (ret)
- goto failed;
+ goto failed_free_fbmem;
/*
* enable controller clock
--
1.7.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] video: pxa168fb: remove a redundant pxa168fb_check_var call
@ 2011-01-21 11:18 ` Axel Lin
0 siblings, 0 replies; 10+ messages in thread
From: Axel Lin @ 2011-01-21 11:18 UTC (permalink / raw)
To: linux-kernel
Cc: Lennert Buytenhek, Green Wan, Eric Miao, Marek Vasut,
Haojian Zhuang, linux-fbdev, Paul Mundt
Current implementation calls pxa168fb_check_var twice in pxa168fb_probe.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/video/pxa168fb.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c
index cea6403..35f61dd 100644
--- a/drivers/video/pxa168fb.c
+++ b/drivers/video/pxa168fb.c
@@ -701,16 +701,12 @@ static int __devinit pxa168fb_probe(struct platform_device *pdev)
*/
pxa168fb_init_mode(info, mi);
- ret = pxa168fb_check_var(&info->var, info);
- if (ret)
- goto failed_free_fbmem;
-
/*
* Fill in sane defaults.
*/
ret = pxa168fb_check_var(&info->var, info);
if (ret)
- goto failed;
+ goto failed_free_fbmem;
/*
* enable controller clock
--
1.7.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] video: pxa168fb: remove a redundant pxa168fb_check_var call
2011-01-21 11:18 ` Axel Lin
@ 2011-01-21 18:07 ` Marek Vasut
-1 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2011-01-21 18:07 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Eric Miao, Haojian Zhuang, linux-arm-kernel
On Friday 21 January 2011 12:18:06 Axel Lin wrote:
> Current implementation calls pxa168fb_check_var twice in pxa168fb_probe.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/video/pxa168fb.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c
> index cea6403..35f61dd 100644
> --- a/drivers/video/pxa168fb.c
> +++ b/drivers/video/pxa168fb.c
> @@ -701,16 +701,12 @@ static int __devinit pxa168fb_probe(struct
> platform_device *pdev) */
> pxa168fb_init_mode(info, mi);
>
> - ret = pxa168fb_check_var(&info->var, info);
> - if (ret)
> - goto failed_free_fbmem;
> -
> /*
> * Fill in sane defaults.
> */
> ret = pxa168fb_check_var(&info->var, info);
> if (ret)
> - goto failed;
> + goto failed_free_fbmem;
>
> /*
> * enable controller clock
Please, don't use the get_maintainers script. This CCs too many people, really.
As for pxa168, only CC linux-arm-kernel, Eric, Haojian and that's about it
(fixed). Thanks
I can't comment on the code, though Haojian, is there any particular reason why
the call's twice in there? Maybe some HW quirk or something?
Cheers
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] video: pxa168fb: remove a redundant pxa168fb_check_var call
@ 2011-01-21 18:07 ` Marek Vasut
0 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2011-01-21 18:07 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 21 January 2011 12:18:06 Axel Lin wrote:
> Current implementation calls pxa168fb_check_var twice in pxa168fb_probe.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/video/pxa168fb.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c
> index cea6403..35f61dd 100644
> --- a/drivers/video/pxa168fb.c
> +++ b/drivers/video/pxa168fb.c
> @@ -701,16 +701,12 @@ static int __devinit pxa168fb_probe(struct
> platform_device *pdev) */
> pxa168fb_init_mode(info, mi);
>
> - ret = pxa168fb_check_var(&info->var, info);
> - if (ret)
> - goto failed_free_fbmem;
> -
> /*
> * Fill in sane defaults.
> */
> ret = pxa168fb_check_var(&info->var, info);
> if (ret)
> - goto failed;
> + goto failed_free_fbmem;
>
> /*
> * enable controller clock
Please, don't use the get_maintainers script. This CCs too many people, really.
As for pxa168, only CC linux-arm-kernel, Eric, Haojian and that's about it
(fixed). Thanks
I can't comment on the code, though Haojian, is there any particular reason why
the call's twice in there? Maybe some HW quirk or something?
Cheers
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] video: pxa168fb: remove a redundant pxa168fb_check_var call
2011-01-21 18:07 ` Marek Vasut
@ 2011-01-21 18:33 ` Mark Brown
-1 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2011-01-21 18:33 UTC (permalink / raw)
To: Marek Vasut
Cc: Axel Lin, Eric Miao, linux-kernel, linux-arm-kernel, Haojian Zhuang
On Fri, Jan 21, 2011 at 07:07:07PM +0100, Marek Vasut wrote:
> Please, don't use the get_maintainers script. This CCs too many people, really.
*Using* get_maintainers.pl is fine, but it is important to apply taste
to the results since as you say it does generate false positives.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] video: pxa168fb: remove a redundant pxa168fb_check_var call
@ 2011-01-21 18:33 ` Mark Brown
0 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2011-01-21 18:33 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 21, 2011 at 07:07:07PM +0100, Marek Vasut wrote:
> Please, don't use the get_maintainers script. This CCs too many people, really.
*Using* get_maintainers.pl is fine, but it is important to apply taste
to the results since as you say it does generate false positives.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] video: da8xx-fb: fix fb_probe error path
2011-01-20 3:50 ` Axel Lin
@ 2011-01-25 6:11 ` Paul Mundt
-1 siblings, 0 replies; 10+ messages in thread
From: Paul Mundt @ 2011-01-25 6:11 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, linux-fbdev, Sudhakar Rajashekhara,
Lennert Buytenhek, Green Wan, Eric Miao, Marek Vasut,
Haojian Zhuang
On Thu, Jan 20, 2011 at 11:50:51AM +0800, Axel Lin wrote:
> Current implementation puts CONFIG_CPU_FREQ at wrong place, CONFIG_CPU_FREQ
> is for lcd_da8xx_cpufreq_deregister not for unregister_framebuffer.
On Fri, Jan 21, 2011 at 07:18:06PM +0800, Axel Lin wrote:
> Current implementation calls pxa168fb_check_var twice in pxa168fb_probe.
Both applied, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] video: da8xx-fb: fix fb_probe error path
@ 2011-01-25 6:11 ` Paul Mundt
0 siblings, 0 replies; 10+ messages in thread
From: Paul Mundt @ 2011-01-25 6:11 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, linux-fbdev, Sudhakar Rajashekhara,
Lennert Buytenhek, Green Wan, Eric Miao, Marek Vasut,
Haojian Zhuang
On Thu, Jan 20, 2011 at 11:50:51AM +0800, Axel Lin wrote:
> Current implementation puts CONFIG_CPU_FREQ at wrong place, CONFIG_CPU_FREQ
> is for lcd_da8xx_cpufreq_deregister not for unregister_framebuffer.
On Fri, Jan 21, 2011 at 07:18:06PM +0800, Axel Lin wrote:
> Current implementation calls pxa168fb_check_var twice in pxa168fb_probe.
Both applied, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-01-25 6:11 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-21 11:18 [PATCH] video: pxa168fb: remove a redundant pxa168fb_check_var call Axel Lin
2011-01-21 11:18 ` Axel Lin
2011-01-20 3:50 ` [PATCH] video: da8xx-fb: fix fb_probe error path Axel Lin
2011-01-20 3:50 ` Axel Lin
2011-01-25 6:11 ` Paul Mundt
2011-01-25 6:11 ` Paul Mundt
2011-01-21 18:07 ` [PATCH] video: pxa168fb: remove a redundant pxa168fb_check_var call Marek Vasut
2011-01-21 18:07 ` Marek Vasut
2011-01-21 18:33 ` Mark Brown
2011-01-21 18:33 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.