All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: linux-media@vger.kernel.org
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	Dan Williams <dan.j.williams@intel.com>,
	linux-arm-kernel@lists.infradead.org, Detlev Zundel <dzu@denx.de>,
	Markus Niebel <Markus.Niebel@tqs.de>,
	Anatolij Gustschin <agust@denx.de>
Subject: [PATCH 1/2] v4l: soc-camera: start stream after queueing the buffers
Date: Wed, 26 Jan 2011 09:49:48 +0100	[thread overview]
Message-ID: <1296031789-1721-2-git-send-email-agust@denx.de> (raw)
In-Reply-To: <1296031789-1721-1-git-send-email-agust@denx.de>

Some camera systems have strong requirement for capturing
an exact number of frames after starting the stream and do
not tolerate losing captured frames. By starting the stream
after the videobuf has queued the buffers, we ensure that
no frame will be lost.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 drivers/media/video/soc_camera.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/soc_camera.c b/drivers/media/video/soc_camera.c
index a66811b..7299de0 100644
--- a/drivers/media/video/soc_camera.c
+++ b/drivers/media/video/soc_camera.c
@@ -646,11 +646,11 @@ static int soc_camera_streamon(struct file *file, void *priv,
 	if (icd->streamer != file)
 		return -EBUSY;
 
-	v4l2_subdev_call(sd, video, s_stream, 1);
-
 	/* This calls buf_queue from host driver's videobuf_queue_ops */
 	ret = videobuf_streamon(&icd->vb_vidq);
 
+	v4l2_subdev_call(sd, video, s_stream, 1);
+
 	return ret;
 }
 
-- 
1.7.1


WARNING: multiple messages have this Message-ID (diff)
From: agust@denx.de (Anatolij Gustschin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] v4l: soc-camera: start stream after queueing the buffers
Date: Wed, 26 Jan 2011 09:49:48 +0100	[thread overview]
Message-ID: <1296031789-1721-2-git-send-email-agust@denx.de> (raw)
In-Reply-To: <1296031789-1721-1-git-send-email-agust@denx.de>

Some camera systems have strong requirement for capturing
an exact number of frames after starting the stream and do
not tolerate losing captured frames. By starting the stream
after the videobuf has queued the buffers, we ensure that
no frame will be lost.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 drivers/media/video/soc_camera.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/soc_camera.c b/drivers/media/video/soc_camera.c
index a66811b..7299de0 100644
--- a/drivers/media/video/soc_camera.c
+++ b/drivers/media/video/soc_camera.c
@@ -646,11 +646,11 @@ static int soc_camera_streamon(struct file *file, void *priv,
 	if (icd->streamer != file)
 		return -EBUSY;
 
-	v4l2_subdev_call(sd, video, s_stream, 1);
-
 	/* This calls buf_queue from host driver's videobuf_queue_ops */
 	ret = videobuf_streamon(&icd->vb_vidq);
 
+	v4l2_subdev_call(sd, video, s_stream, 1);
+
 	return ret;
 }
 
-- 
1.7.1

  reply	other threads:[~2011-01-26  8:49 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26  8:49 [PATCH 0/2] Fix issues with frame reception from CSI on i.MX31 Anatolij Gustschin
2011-01-26  8:49 ` Anatolij Gustschin
2011-01-26  8:49 ` Anatolij Gustschin [this message]
2011-01-26  8:49   ` [PATCH 1/2] v4l: soc-camera: start stream after queueing the buffers Anatolij Gustschin
2011-01-29 19:16   ` Guennadi Liakhovetski
2011-01-29 19:16     ` Guennadi Liakhovetski
2011-01-29 19:24     ` Anatolij Gustschin
2011-01-29 19:24       ` Anatolij Gustschin
2011-01-31 12:19   ` [PATCH 1/2 v2] " Anatolij Gustschin
2011-01-31 12:19     ` Anatolij Gustschin
2011-01-26  8:49 ` [PATCH 2/2] dma: ipu_idmac: do not lose valid received data in the irq handler Anatolij Gustschin
2011-01-26  8:49   ` Anatolij Gustschin
2011-01-27  8:22   ` Anatolij Gustschin
2011-01-27  8:22     ` Anatolij Gustschin
2011-01-31  5:56     ` Dan Williams
2011-01-31  5:56       ` Dan Williams
2011-01-31 12:22   ` [PATCH 2/2 v2] " Anatolij Gustschin
2011-01-31 12:22     ` Anatolij Gustschin
2011-02-03 10:09     ` Guennadi Liakhovetski
2011-02-03 10:09       ` Guennadi Liakhovetski
2011-02-04  9:19       ` Markus Niebel
2011-02-04  9:19         ` Markus Niebel
2011-02-04  9:37         ` Guennadi Liakhovetski
2011-02-04  9:37           ` Guennadi Liakhovetski
2011-02-04 11:37           ` Markus Niebel
2011-02-04 11:37             ` Markus Niebel
2011-02-04  9:35       ` Anatolij Gustschin
2011-02-04  9:35         ` Anatolij Gustschin
2011-02-05 13:35       ` Anatolij Gustschin
2011-02-05 13:35         ` Anatolij Gustschin
2011-02-05 16:36         ` Guennadi Liakhovetski
2011-02-05 16:36           ` Guennadi Liakhovetski
2011-02-05 20:04           ` Anatolij Gustschin
2011-02-05 20:04             ` Anatolij Gustschin
2011-02-07 11:09             ` Guennadi Liakhovetski
2011-02-07 11:09               ` Guennadi Liakhovetski
2011-02-07 11:21               ` Anatolij Gustschin
2011-02-07 11:21                 ` Anatolij Gustschin
2011-02-07 11:35                 ` Guennadi Liakhovetski
2011-02-07 11:35                   ` Guennadi Liakhovetski
2011-02-07 13:01                   ` Detlev Zundel
2011-02-07 13:01                     ` Detlev Zundel
2011-02-07 13:35                     ` Guennadi Liakhovetski
2011-02-07 13:35                       ` Guennadi Liakhovetski
2011-02-07 14:43                       ` Detlev Zundel
2011-02-07 14:43                         ` Detlev Zundel
2011-02-07 13:45                   ` Anatolij Gustschin
2011-02-07 13:45                     ` Anatolij Gustschin
2011-02-07 14:00                     ` Guennadi Liakhovetski
2011-02-07 14:00                       ` Guennadi Liakhovetski
2011-02-07 16:49                     ` Guennadi Liakhovetski
2011-02-07 16:49                       ` Guennadi Liakhovetski
2011-02-14  9:57                       ` Dan Williams
2011-02-14  9:57                         ` Dan Williams
2011-01-28  7:46 ` [PATCH 0/2] Fix issues with frame reception from CSI on i.MX31 Anatolij Gustschin
2011-01-28  7:46   ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296031789-1721-2-git-send-email-agust@denx.de \
    --to=agust@denx.de \
    --cc=Markus.Niebel@tqs.de \
    --cc=dan.j.williams@intel.com \
    --cc=dzu@denx.de \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.