From: Detlev Zundel <dzu@denx.de> To: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Cc: Anatolij Gustschin <agust@denx.de>, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dan Williams <dan.j.williams@intel.com>, Markus Niebel <Markus.Niebel@tqs.de> Subject: Re: [PATCH 2/2 v2] dma: ipu_idmac: do not lose valid received data in the irq handler Date: Mon, 07 Feb 2011 15:43:47 +0100 [thread overview] Message-ID: <m2zkq77vmk.fsf@ohwell.denx.de> (raw) In-Reply-To: <Pine.LNX.4.64.1102071428470.29036@axis700.grange> (Guennadi Liakhovetski's message of "Mon, 7 Feb 2011 14:35:04 +0100 (CET)") Hi Guennadi, > Hi Detlev > > On Mon, 7 Feb 2011, Detlev Zundel wrote: > >> Hi Guennadi, >> >> >> How small are the frames in you test? What is the highest fps value in >> >> your test? >> > >> > QVGA, don't know fps exactly, pretty high, between 20 and 60fps, I think. >> > Just try different frams sizes, go down to 64x48 or something. >> >> Is this a "real" usage scenario? It feels that this is not what most >> users will do and it certainly is not relevant for our application. > > QVGA at 25 / 50 / 60 fps is _certainly_ very much a real-life scenario. Yes, sure. It was the 64x48 pixel you suggested which I believe to be of doubtful value here. >> Is it possible that if you are interested in such a scenario that you do >> the testing? We have spent quite a lot of time to fix the driver for >> real (well full frame) capturing already and I am relucatant to spend >> more time for corner cases. Maybe we should document this as "known >> limitations" of the setup? What do you think? I'll much rather have a >> driver working for real world scenarios than for marginal test cases. > > I am interested in avoiding regressions. In principle, this is a DMA > driver, which I am not maintaining. Dan asked for my ack, so, I tested it > and found an issue, which I would prefer to have resolved before > committing. Of course, I don't have a decisive voice in this matter, so, > the patch can also be merged without my ack. Otherwise - of course you > don't have to continue testing, I will try to look at the issue as the > time permits, and Dan will have to decide, whether he is prepared to > commit this patch in its present form, or he would prefer this issue to be > clarified. I'm fully in line with not wanting any regressions. But is it a regression if two independent testers report that the patch _improves_ the current situation? As was shown by Anatolijs log, the current driver certainly has a bug with respect to the handling of individual frames. This buggy behaviour only never showed up because nobody used the driver on such a granularity. We certainly appreciate if you can look into your scenario. Thanks Detlev -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu@denx.de
WARNING: multiple messages have this Message-ID (diff)
From: dzu@denx.de (Detlev Zundel) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2 v2] dma: ipu_idmac: do not lose valid received data in the irq handler Date: Mon, 07 Feb 2011 15:43:47 +0100 [thread overview] Message-ID: <m2zkq77vmk.fsf@ohwell.denx.de> (raw) In-Reply-To: <Pine.LNX.4.64.1102071428470.29036@axis700.grange> (Guennadi Liakhovetski's message of "Mon, 7 Feb 2011 14:35:04 +0100 (CET)") Hi Guennadi, > Hi Detlev > > On Mon, 7 Feb 2011, Detlev Zundel wrote: > >> Hi Guennadi, >> >> >> How small are the frames in you test? What is the highest fps value in >> >> your test? >> > >> > QVGA, don't know fps exactly, pretty high, between 20 and 60fps, I think. >> > Just try different frams sizes, go down to 64x48 or something. >> >> Is this a "real" usage scenario? It feels that this is not what most >> users will do and it certainly is not relevant for our application. > > QVGA at 25 / 50 / 60 fps is _certainly_ very much a real-life scenario. Yes, sure. It was the 64x48 pixel you suggested which I believe to be of doubtful value here. >> Is it possible that if you are interested in such a scenario that you do >> the testing? We have spent quite a lot of time to fix the driver for >> real (well full frame) capturing already and I am relucatant to spend >> more time for corner cases. Maybe we should document this as "known >> limitations" of the setup? What do you think? I'll much rather have a >> driver working for real world scenarios than for marginal test cases. > > I am interested in avoiding regressions. In principle, this is a DMA > driver, which I am not maintaining. Dan asked for my ack, so, I tested it > and found an issue, which I would prefer to have resolved before > committing. Of course, I don't have a decisive voice in this matter, so, > the patch can also be merged without my ack. Otherwise - of course you > don't have to continue testing, I will try to look at the issue as the > time permits, and Dan will have to decide, whether he is prepared to > commit this patch in its present form, or he would prefer this issue to be > clarified. I'm fully in line with not wanting any regressions. But is it a regression if two independent testers report that the patch _improves_ the current situation? As was shown by Anatolijs log, the current driver certainly has a bug with respect to the handling of individual frames. This buggy behaviour only never showed up because nobody used the driver on such a granularity. We certainly appreciate if you can look into your scenario. Thanks Detlev -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2011-02-07 14:43 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-01-26 8:49 [PATCH 0/2] Fix issues with frame reception from CSI on i.MX31 Anatolij Gustschin 2011-01-26 8:49 ` Anatolij Gustschin 2011-01-26 8:49 ` [PATCH 1/2] v4l: soc-camera: start stream after queueing the buffers Anatolij Gustschin 2011-01-26 8:49 ` Anatolij Gustschin 2011-01-29 19:16 ` Guennadi Liakhovetski 2011-01-29 19:16 ` Guennadi Liakhovetski 2011-01-29 19:24 ` Anatolij Gustschin 2011-01-29 19:24 ` Anatolij Gustschin 2011-01-31 12:19 ` [PATCH 1/2 v2] " Anatolij Gustschin 2011-01-31 12:19 ` Anatolij Gustschin 2011-01-26 8:49 ` [PATCH 2/2] dma: ipu_idmac: do not lose valid received data in the irq handler Anatolij Gustschin 2011-01-26 8:49 ` Anatolij Gustschin 2011-01-27 8:22 ` Anatolij Gustschin 2011-01-27 8:22 ` Anatolij Gustschin 2011-01-31 5:56 ` Dan Williams 2011-01-31 5:56 ` Dan Williams 2011-01-31 12:22 ` [PATCH 2/2 v2] " Anatolij Gustschin 2011-01-31 12:22 ` Anatolij Gustschin 2011-02-03 10:09 ` Guennadi Liakhovetski 2011-02-03 10:09 ` Guennadi Liakhovetski 2011-02-04 9:19 ` Markus Niebel 2011-02-04 9:19 ` Markus Niebel 2011-02-04 9:37 ` Guennadi Liakhovetski 2011-02-04 9:37 ` Guennadi Liakhovetski 2011-02-04 11:37 ` Markus Niebel 2011-02-04 11:37 ` Markus Niebel 2011-02-04 9:35 ` Anatolij Gustschin 2011-02-04 9:35 ` Anatolij Gustschin 2011-02-05 13:35 ` Anatolij Gustschin 2011-02-05 13:35 ` Anatolij Gustschin 2011-02-05 16:36 ` Guennadi Liakhovetski 2011-02-05 16:36 ` Guennadi Liakhovetski 2011-02-05 20:04 ` Anatolij Gustschin 2011-02-05 20:04 ` Anatolij Gustschin 2011-02-07 11:09 ` Guennadi Liakhovetski 2011-02-07 11:09 ` Guennadi Liakhovetski 2011-02-07 11:21 ` Anatolij Gustschin 2011-02-07 11:21 ` Anatolij Gustschin 2011-02-07 11:35 ` Guennadi Liakhovetski 2011-02-07 11:35 ` Guennadi Liakhovetski 2011-02-07 13:01 ` Detlev Zundel 2011-02-07 13:01 ` Detlev Zundel 2011-02-07 13:35 ` Guennadi Liakhovetski 2011-02-07 13:35 ` Guennadi Liakhovetski 2011-02-07 14:43 ` Detlev Zundel [this message] 2011-02-07 14:43 ` Detlev Zundel 2011-02-07 13:45 ` Anatolij Gustschin 2011-02-07 13:45 ` Anatolij Gustschin 2011-02-07 14:00 ` Guennadi Liakhovetski 2011-02-07 14:00 ` Guennadi Liakhovetski 2011-02-07 16:49 ` Guennadi Liakhovetski 2011-02-07 16:49 ` Guennadi Liakhovetski 2011-02-14 9:57 ` Dan Williams 2011-02-14 9:57 ` Dan Williams 2011-01-28 7:46 ` [PATCH 0/2] Fix issues with frame reception from CSI on i.MX31 Anatolij Gustschin 2011-01-28 7:46 ` Anatolij Gustschin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=m2zkq77vmk.fsf@ohwell.denx.de \ --to=dzu@denx.de \ --cc=Markus.Niebel@tqs.de \ --cc=agust@denx.de \ --cc=dan.j.williams@intel.com \ --cc=g.liakhovetski@gmx.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-media@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.