* [net-2.6 3/7] ixgbe: fix for 82599 erratum on Header Splitting.
[not found] <1296195143-2870-1-git-send-email-jeffrey.t.kirsher@intel.com>
@ 2011-01-28 6:12 ` Jeff Kirsher
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Kirsher @ 2011-01-28 6:12 UTC (permalink / raw)
To: , davem; +Cc: Don Skidmore, bphilips, netdev, stable, Jeff Kirsher
From: Don Skidmore <donald.c.skidmore@intel.com>
We have found a hardware erratum on 82599 hardware that can lead to
unpredictable behavior when Header Splitting mode is enabled. So
we are no longer enabling this feature on affected hardware.
Please see the 82599 Specification Update for more information.
CC: stable@kernel.org
Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
Tested-by: Stephen Ko <stephen.s.ko@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_main.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 44a1cf0..1495b74 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -3176,9 +3176,16 @@ static void ixgbe_set_rx_buffer_len(struct ixgbe_adapter *adapter)
u32 mhadd, hlreg0;
/* Decide whether to use packet split mode or not */
+ /* On by default */
+ adapter->flags |= IXGBE_FLAG_RX_PS_ENABLED;
+
/* Do not use packet split if we're in SR-IOV Mode */
- if (!adapter->num_vfs)
- adapter->flags |= IXGBE_FLAG_RX_PS_ENABLED;
+ if (adapter->num_vfs)
+ adapter->flags &= ~IXGBE_FLAG_RX_PS_ENABLED;
+
+ /* Disable packet split due to 82599 erratum #45 */
+ if (hw->mac.type == ixgbe_mac_82599EB)
+ adapter->flags &= ~IXGBE_FLAG_RX_PS_ENABLED;
/* Set the RX buffer length according to the mode */
if (adapter->flags & IXGBE_FLAG_RX_PS_ENABLED) {
--
1.7.3.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [net-2.6 3/7] ixgbe: fix for 82599 erratum on Header Splitting.
2011-01-28 6:33 ` David Miller
@ 2011-01-28 6:58 ` Jeff Kirsher
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Kirsher @ 2011-01-28 6:58 UTC (permalink / raw)
To: David Miller; +Cc: Skidmore, Donald C, bphilips, gospo, stable, netdev
[-- Attachment #1.1: Type: text/plain, Size: 753 bytes --]
On Thu, 2011-01-27 at 22:33 -0800, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Thu, 27 Jan 2011 22:18:51 -0800
>
> > diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
> > index 44a1cf0..1495b74 100644
> > --- a/drivers/net/ixgbe/ixgbe_main.c
> > +++ b/drivers/net/ixgbe/ixgbe_main.c
> > @@ -3176,9 +3176,16 @@ static void ixgbe_set_rx_buffer_len(struct ixgbe_adapter *adapter)
> > u32 mhadd, hlreg0;
> >
> > /* Decide whether to use packet split mode or not */
> > + /* On by default */
> > + adapter->flags |= IXGBE_FLAG_RX_PS_ENABLED;
> > +
>
> Please fix this indentation, it's a TAB then a SPACE character.
Grrr, sorry I did not catch it. Fixing it up now.
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 140 bytes --]
_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [net-2.6 3/7] ixgbe: fix for 82599 erratum on Header Splitting.
2011-01-28 6:18 ` Jeff Kirsher
@ 2011-01-28 6:33 ` David Miller
2011-01-28 6:58 ` Jeff Kirsher
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2011-01-28 6:33 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: donald.c.skidmore, netdev, gospo, bphilips, stable
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 27 Jan 2011 22:18:51 -0800
> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
> index 44a1cf0..1495b74 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -3176,9 +3176,16 @@ static void ixgbe_set_rx_buffer_len(struct ixgbe_adapter *adapter)
> u32 mhadd, hlreg0;
>
> /* Decide whether to use packet split mode or not */
> + /* On by default */
> + adapter->flags |= IXGBE_FLAG_RX_PS_ENABLED;
> +
Please fix this indentation, it's a TAB then a SPACE character.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [net-2.6 3/7] ixgbe: fix for 82599 erratum on Header Splitting.
2011-01-28 6:18 [net-2.6 0/7][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-01-28 6:18 ` [net-2.6 3/7] ixgbe: fix for 82599 erratum on Header Splitting Jeff Kirsher
@ 2011-01-28 6:18 ` Jeff Kirsher
2011-01-28 6:33 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Jeff Kirsher @ 2011-01-28 6:18 UTC (permalink / raw)
To: davem; +Cc: Don Skidmore, netdev, gospo, bphilips, stable, Jeff Kirsher
From: Don Skidmore <donald.c.skidmore@intel.com>
We have found a hardware erratum on 82599 hardware that can lead to
unpredictable behavior when Header Splitting mode is enabled. So
we are no longer enabling this feature on affected hardware.
Please see the 82599 Specification Update for more information.
CC: stable@kernel.org
Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
Tested-by: Stephen Ko <stephen.s.ko@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_main.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 44a1cf0..1495b74 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -3176,9 +3176,16 @@ static void ixgbe_set_rx_buffer_len(struct ixgbe_adapter *adapter)
u32 mhadd, hlreg0;
/* Decide whether to use packet split mode or not */
+ /* On by default */
+ adapter->flags |= IXGBE_FLAG_RX_PS_ENABLED;
+
/* Do not use packet split if we're in SR-IOV Mode */
- if (!adapter->num_vfs)
- adapter->flags |= IXGBE_FLAG_RX_PS_ENABLED;
+ if (adapter->num_vfs)
+ adapter->flags &= ~IXGBE_FLAG_RX_PS_ENABLED;
+
+ /* Disable packet split due to 82599 erratum #45 */
+ if (hw->mac.type == ixgbe_mac_82599EB)
+ adapter->flags &= ~IXGBE_FLAG_RX_PS_ENABLED;
/* Set the RX buffer length according to the mode */
if (adapter->flags & IXGBE_FLAG_RX_PS_ENABLED) {
--
1.7.3.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [net-2.6 3/7] ixgbe: fix for 82599 erratum on Header Splitting.
2011-01-28 6:18 [net-2.6 0/7][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
@ 2011-01-28 6:18 ` Jeff Kirsher
2011-01-28 6:18 ` Jeff Kirsher
1 sibling, 0 replies; 5+ messages in thread
From: Jeff Kirsher @ 2011-01-28 6:18 UTC (permalink / raw)
To: , davem; +Cc: Don Skidmore, bphilips, netdev, Jeff Kirsher, gospo, stable
From: Don Skidmore <donald.c.skidmore@intel.com>
We have found a hardware erratum on 82599 hardware that can lead to
unpredictable behavior when Header Splitting mode is enabled. So
we are no longer enabling this feature on affected hardware.
Please see the 82599 Specification Update for more information.
CC: stable@kernel.org
Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
Tested-by: Stephen Ko <stephen.s.ko@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_main.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 44a1cf0..1495b74 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -3176,9 +3176,16 @@ static void ixgbe_set_rx_buffer_len(struct ixgbe_adapter *adapter)
u32 mhadd, hlreg0;
/* Decide whether to use packet split mode or not */
+ /* On by default */
+ adapter->flags |= IXGBE_FLAG_RX_PS_ENABLED;
+
/* Do not use packet split if we're in SR-IOV Mode */
- if (!adapter->num_vfs)
- adapter->flags |= IXGBE_FLAG_RX_PS_ENABLED;
+ if (adapter->num_vfs)
+ adapter->flags &= ~IXGBE_FLAG_RX_PS_ENABLED;
+
+ /* Disable packet split due to 82599 erratum #45 */
+ if (hw->mac.type == ixgbe_mac_82599EB)
+ adapter->flags &= ~IXGBE_FLAG_RX_PS_ENABLED;
/* Set the RX buffer length according to the mode */
if (adapter->flags & IXGBE_FLAG_RX_PS_ENABLED) {
--
1.7.3.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-01-28 6:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1296195143-2870-1-git-send-email-jeffrey.t.kirsher@intel.com>
2011-01-28 6:12 ` [net-2.6 3/7] ixgbe: fix for 82599 erratum on Header Splitting Jeff Kirsher
2011-01-28 6:18 [net-2.6 0/7][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-01-28 6:18 ` [net-2.6 3/7] ixgbe: fix for 82599 erratum on Header Splitting Jeff Kirsher
2011-01-28 6:18 ` Jeff Kirsher
2011-01-28 6:33 ` David Miller
2011-01-28 6:58 ` Jeff Kirsher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.