All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Sverdlin <subaparts@yandex.ru>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Brown <broonie@opensource.wolfsonmicro.com>,
	Mark@alsa-project.org, Lennert Buytenhek <buytenh@wantstofly.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] EDB93xx: Add support for CS4271 CODEC on EDB93xx boards
Date: Wed, 02 Feb 2011 13:48:08 +0300	[thread overview]
Message-ID: <1296643688.1504.23.camel@r60e> (raw)
In-Reply-To: <0D753D10438DA54287A00B027084269764CEF59B2B@AUSP01VMBX24.collaborationhost.net>

Dear Hartley, Dear Mark,

On Tue, 2011-02-01 at 18:02 -0600, H Hartley Sweeten wrote:
> > +static int edb93xx_cs4271_hw_setup(struct spi_device *spi)
> > +{
> > +	int gpio_nreset;
> > +	int err;
> > +
> > +	if (machine_is_edb9301() || machine_is_edb9302()) {
> > +		gpio_nreset = EP93XX_GPIO_LINE_EGPIO1;
> 
> Are you planning on removing gpio_nreset and gpio_disable from struct cs4271_platform_data?
> If not, you should just setup the gpio mapping in edb93xx_register_spi before you actually
> register the spi_board_info.  Then this function and the following two can just do something
> like the following and not worry about the if ... else if ... etc.

Initially I had GPIO code in machine driver, but during the
conversations in alsa-devel list it has been moved to CODEC driver:
http://mailman.alsa-project.org/pipermail/alsa-devel/2010-October/032358.html

I'm really confused now, where should it be? If I will init
cs4271_platform_data with GPIO values, CODEC driver will manage it.
Otherwise CODEC driver should be rewritten without GPIO support and I
can add it to platform code.

Mark Brown, could you please comment on this, as I've moved GPIO things
to CODEC part based on your review.

Best regards,
	Alexander Sverdlin.

WARNING: multiple messages have this Message-ID (diff)
From: subaparts@yandex.ru (Alexander Sverdlin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] EDB93xx: Add support for CS4271 CODEC on EDB93xx boards
Date: Wed, 02 Feb 2011 13:48:08 +0300	[thread overview]
Message-ID: <1296643688.1504.23.camel@r60e> (raw)
In-Reply-To: <0D753D10438DA54287A00B027084269764CEF59B2B@AUSP01VMBX24.collaborationhost.net>

Dear Hartley, Dear Mark,

On Tue, 2011-02-01 at 18:02 -0600, H Hartley Sweeten wrote:
> > +static int edb93xx_cs4271_hw_setup(struct spi_device *spi)
> > +{
> > +	int gpio_nreset;
> > +	int err;
> > +
> > +	if (machine_is_edb9301() || machine_is_edb9302()) {
> > +		gpio_nreset = EP93XX_GPIO_LINE_EGPIO1;
> 
> Are you planning on removing gpio_nreset and gpio_disable from struct cs4271_platform_data?
> If not, you should just setup the gpio mapping in edb93xx_register_spi before you actually
> register the spi_board_info.  Then this function and the following two can just do something
> like the following and not worry about the if ... else if ... etc.

Initially I had GPIO code in machine driver, but during the
conversations in alsa-devel list it has been moved to CODEC driver:
http://mailman.alsa-project.org/pipermail/alsa-devel/2010-October/032358.html

I'm really confused now, where should it be? If I will init
cs4271_platform_data with GPIO values, CODEC driver will manage it.
Otherwise CODEC driver should be rewritten without GPIO support and I
can add it to platform code.

Mark Brown, could you please comment on this, as I've moved GPIO things
to CODEC part based on your review.

Best regards,
	Alexander Sverdlin.

  reply	other threads:[~2011-02-02 10:48 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01 23:40 [PATCH] EDB93xx: Add support for CS4271 CODEC on EDB93xx boards Alexander Sverdlin
2011-02-01 23:40 ` Alexander Sverdlin
2011-02-02  0:02 ` H Hartley Sweeten
2011-02-02  0:02   ` H Hartley Sweeten
2011-02-02 10:48   ` Alexander Sverdlin [this message]
2011-02-02 10:48     ` Alexander Sverdlin
2011-02-02 10:49     ` Mark Brown
2011-02-02 10:49       ` Mark Brown
2011-02-02 11:12       ` Alexander Sverdlin
2011-02-02 11:12         ` Alexander Sverdlin
2011-02-02 12:53         ` Mark Brown
2011-02-02 12:53           ` Mark Brown
2011-02-02 13:26           ` Alexander Sverdlin
2011-02-02 13:26             ` Alexander Sverdlin
2011-02-02 16:53             ` H Hartley Sweeten
2011-02-02 16:53               ` H Hartley Sweeten
2011-02-02 17:00               ` Mark Brown
2011-02-02 17:00                 ` Mark Brown
2011-02-02 17:21                 ` H Hartley Sweeten
2011-02-02 17:21                   ` H Hartley Sweeten
2011-02-02 17:33                 ` Alexander Sverdlin
2011-02-02 17:33                   ` Alexander Sverdlin
2011-02-02 17:48                   ` H Hartley Sweeten
2011-02-02 17:48                     ` H Hartley Sweeten
2011-02-02 18:31                   ` Mark Brown
2011-02-02 18:31                     ` Mark Brown
2011-02-02 18:18             ` H Hartley Sweeten
2011-02-02 18:18               ` H Hartley Sweeten
2011-02-02 16:45     ` H Hartley Sweeten
2011-02-02 16:45       ` H Hartley Sweeten
2011-02-02  7:54 ` Mika Westerberg
2011-02-02  7:54   ` [alsa-devel] " Mika Westerberg
2011-02-02 16:27   ` H Hartley Sweeten
2011-02-02 16:27     ` H Hartley Sweeten
2011-02-02 10:51 ` Mark Brown
2011-02-02 10:51   ` [alsa-devel] " Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2011-01-23  0:51 Alexander Sverdlin
2011-01-24 16:30 ` H Hartley Sweeten
2011-01-25 11:46   ` Mark Brown
2011-01-25 12:08     ` Alexander Sverdlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296643688.1504.23.camel@r60e \
    --to=subaparts@yandex.ru \
    --cc=Mark@alsa-project.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=buytenh@wantstofly.org \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=hartleys@visionengravers.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.