From: Mika Westerberg <mika.westerberg@iki.fi> To: Alexander Sverdlin <subaparts@yandex.ru> Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>, alsa-devel@alsa-project.org, Mark Brown <broonie@opensource.wolfsonmicro.com>, H Hartley Sweeten <hsweeten@visionengravers.com>, Lennert Buytenhek <buytenh@wantstofly.org>, linux-arm-kernel@lists.infradead.org, Liam Girdwood <lrg@slimlogic.co.uk> Subject: Re: [PATCH] EDB93xx: Add support for CS4271 CODEC on EDB93xx boards Date: Wed, 2 Feb 2011 09:54:34 +0200 [thread overview] Message-ID: <20110202075434.GA2445@acer> (raw) In-Reply-To: <1296603653.1504.9.camel@r60e> On Wed, Feb 02, 2011 at 02:40:53AM +0300, Alexander Sverdlin wrote: > From: Alexander Sverdlin <subaparts@yandex.ru> > > Add support for CS4271 SPI-connected CODEC on EDB93xx boards. > Major rework based on code provided by H Hartley Sweeten <hsweeten@visionengravers.com>. > Tested on EDB9302, others (EDB9301, EDB9302A, EDB9307A, EDB0315A) should work. One minor comment, see below. > > Signed-off-by: Alexander Sverdlin <subaparts@yandex.ru> > --- > arch/arm/mach-ep93xx/edb93xx.c | 117 ++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 117 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-ep93xx/edb93xx.c b/arch/arm/mach-ep93xx/edb93xx.c > index 4b04316..f20be96 100644 > --- a/arch/arm/mach-ep93xx/edb93xx.c > +++ b/arch/arm/mach-ep93xx/edb93xx.c > @@ -30,12 +30,22 @@ > #include <linux/gpio.h> > #include <linux/i2c.h> > #include <linux/i2c-gpio.h> > +#include <linux/spi/spi.h> > +#include <linux/delay.h> > +#include <mach/ep93xx_spi.h> > > #include <mach/hardware.h> > > #include <asm/mach-types.h> > #include <asm/mach/arch.h> > > +#include <sound/cs4271.h> > + > +#define edb93xx_has_audio() (machine_is_edb9301() || \ > + machine_is_edb9302() || \ > + machine_is_edb9302a() || \ > + machine_is_edb9307a() || \ > + machine_is_edb9315a()) > > static void __init edb93xx_register_flash(void) > { > @@ -93,6 +103,111 @@ static void __init edb93xx_register_i2c(void) > > > /************************************************************************* > + * EDB93xx SPI peripheral handling > + *************************************************************************/ > +static int edb93xx_cs4271_hw_setup(struct spi_device *spi) > +{ > + int gpio_nreset; > + int err; > + > + if (machine_is_edb9301() || machine_is_edb9302()) { > + gpio_nreset = EP93XX_GPIO_LINE_EGPIO1; > + } else if (machine_is_edb9302a() || machine_is_edb9307a()) { > + ep93xx_devcfg_set_bits(EP93XX_SYSCON_DEVCFG_HONIDE); > + gpio_nreset = EP93XX_GPIO_LINE_DD2; > + } else if (machine_is_edb9315a()) { > + gpio_nreset = EP93XX_GPIO_LINE_EGPIO14; > + } else { > + return -EINVAL; > + } > + > + err = gpio_request(gpio_nreset, spi->modalias); > + if (err) > + return err; > + err = gpio_request(EP93XX_GPIO_LINE_EGPIO6, spi->modalias); > + if (err) Should you call gpio_free() for gpio_nreset here? Regards, MW > + return err; > + > + gpio_direction_output(EP93XX_GPIO_LINE_EGPIO6, 1); > + > + /* Reset codec */ > + gpio_direction_output(gpio_nreset, 0); > + udelay(1); > + gpio_set_value(gpio_nreset, 1); > + /* Give the codec time to wake up */ > + udelay(1); > + > + return 0; > +}
WARNING: multiple messages have this Message-ID (diff)
From: mika.westerberg@iki.fi (Mika Westerberg) To: linux-arm-kernel@lists.infradead.org Subject: [alsa-devel] [PATCH] EDB93xx: Add support for CS4271 CODEC on EDB93xx boards Date: Wed, 2 Feb 2011 09:54:34 +0200 [thread overview] Message-ID: <20110202075434.GA2445@acer> (raw) In-Reply-To: <1296603653.1504.9.camel@r60e> On Wed, Feb 02, 2011 at 02:40:53AM +0300, Alexander Sverdlin wrote: > From: Alexander Sverdlin <subaparts@yandex.ru> > > Add support for CS4271 SPI-connected CODEC on EDB93xx boards. > Major rework based on code provided by H Hartley Sweeten <hsweeten@visionengravers.com>. > Tested on EDB9302, others (EDB9301, EDB9302A, EDB9307A, EDB0315A) should work. One minor comment, see below. > > Signed-off-by: Alexander Sverdlin <subaparts@yandex.ru> > --- > arch/arm/mach-ep93xx/edb93xx.c | 117 ++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 117 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-ep93xx/edb93xx.c b/arch/arm/mach-ep93xx/edb93xx.c > index 4b04316..f20be96 100644 > --- a/arch/arm/mach-ep93xx/edb93xx.c > +++ b/arch/arm/mach-ep93xx/edb93xx.c > @@ -30,12 +30,22 @@ > #include <linux/gpio.h> > #include <linux/i2c.h> > #include <linux/i2c-gpio.h> > +#include <linux/spi/spi.h> > +#include <linux/delay.h> > +#include <mach/ep93xx_spi.h> > > #include <mach/hardware.h> > > #include <asm/mach-types.h> > #include <asm/mach/arch.h> > > +#include <sound/cs4271.h> > + > +#define edb93xx_has_audio() (machine_is_edb9301() || \ > + machine_is_edb9302() || \ > + machine_is_edb9302a() || \ > + machine_is_edb9307a() || \ > + machine_is_edb9315a()) > > static void __init edb93xx_register_flash(void) > { > @@ -93,6 +103,111 @@ static void __init edb93xx_register_i2c(void) > > > /************************************************************************* > + * EDB93xx SPI peripheral handling > + *************************************************************************/ > +static int edb93xx_cs4271_hw_setup(struct spi_device *spi) > +{ > + int gpio_nreset; > + int err; > + > + if (machine_is_edb9301() || machine_is_edb9302()) { > + gpio_nreset = EP93XX_GPIO_LINE_EGPIO1; > + } else if (machine_is_edb9302a() || machine_is_edb9307a()) { > + ep93xx_devcfg_set_bits(EP93XX_SYSCON_DEVCFG_HONIDE); > + gpio_nreset = EP93XX_GPIO_LINE_DD2; > + } else if (machine_is_edb9315a()) { > + gpio_nreset = EP93XX_GPIO_LINE_EGPIO14; > + } else { > + return -EINVAL; > + } > + > + err = gpio_request(gpio_nreset, spi->modalias); > + if (err) > + return err; > + err = gpio_request(EP93XX_GPIO_LINE_EGPIO6, spi->modalias); > + if (err) Should you call gpio_free() for gpio_nreset here? Regards, MW > + return err; > + > + gpio_direction_output(EP93XX_GPIO_LINE_EGPIO6, 1); > + > + /* Reset codec */ > + gpio_direction_output(gpio_nreset, 0); > + udelay(1); > + gpio_set_value(gpio_nreset, 1); > + /* Give the codec time to wake up */ > + udelay(1); > + > + return 0; > +}
next prev parent reply other threads:[~2011-02-02 7:56 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-01 23:40 [PATCH] EDB93xx: Add support for CS4271 CODEC on EDB93xx boards Alexander Sverdlin 2011-02-01 23:40 ` Alexander Sverdlin 2011-02-02 0:02 ` H Hartley Sweeten 2011-02-02 0:02 ` H Hartley Sweeten 2011-02-02 10:48 ` Alexander Sverdlin 2011-02-02 10:48 ` Alexander Sverdlin 2011-02-02 10:49 ` Mark Brown 2011-02-02 10:49 ` Mark Brown 2011-02-02 11:12 ` Alexander Sverdlin 2011-02-02 11:12 ` Alexander Sverdlin 2011-02-02 12:53 ` Mark Brown 2011-02-02 12:53 ` Mark Brown 2011-02-02 13:26 ` Alexander Sverdlin 2011-02-02 13:26 ` Alexander Sverdlin 2011-02-02 16:53 ` H Hartley Sweeten 2011-02-02 16:53 ` H Hartley Sweeten 2011-02-02 17:00 ` Mark Brown 2011-02-02 17:00 ` Mark Brown 2011-02-02 17:21 ` H Hartley Sweeten 2011-02-02 17:21 ` H Hartley Sweeten 2011-02-02 17:33 ` Alexander Sverdlin 2011-02-02 17:33 ` Alexander Sverdlin 2011-02-02 17:48 ` H Hartley Sweeten 2011-02-02 17:48 ` H Hartley Sweeten 2011-02-02 18:31 ` Mark Brown 2011-02-02 18:31 ` Mark Brown 2011-02-02 18:18 ` H Hartley Sweeten 2011-02-02 18:18 ` H Hartley Sweeten 2011-02-02 16:45 ` H Hartley Sweeten 2011-02-02 16:45 ` H Hartley Sweeten 2011-02-02 7:54 ` Mika Westerberg [this message] 2011-02-02 7:54 ` [alsa-devel] " Mika Westerberg 2011-02-02 16:27 ` H Hartley Sweeten 2011-02-02 16:27 ` H Hartley Sweeten 2011-02-02 10:51 ` Mark Brown 2011-02-02 10:51 ` [alsa-devel] " Mark Brown -- strict thread matches above, loose matches on Subject: below -- 2011-01-23 0:51 Alexander Sverdlin 2011-01-24 16:30 ` H Hartley Sweeten 2011-01-25 11:46 ` Mark Brown 2011-01-25 12:08 ` Alexander Sverdlin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110202075434.GA2445@acer \ --to=mika.westerberg@iki.fi \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@opensource.wolfsonmicro.com \ --cc=buytenh@wantstofly.org \ --cc=dp@opensource.wolfsonmicro.com \ --cc=hsweeten@visionengravers.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=lrg@slimlogic.co.uk \ --cc=subaparts@yandex.ru \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.