From: Namhyung Kim <namhyung@gmail.com> To: Minchan Kim <minchan.kim@gmail.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mel@csn.ul.ie>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] mm: handle simple case in free_pcppages_bulk() Date: Thu, 10 Feb 2011 22:18:49 +0900 [thread overview] Message-ID: <1297343929.1449.3.camel@leonhard> (raw) In-Reply-To: <AANLkTikEigbPsNMqqkmixYbCfD7Dz12YMcW2+GZbhUQq@mail.gmail.com> 2011-02-10 (목), 22:10 +0900, Minchan Kim: > Hello Namhyung, > Hi Minchan, > On Thu, Feb 10, 2011 at 8:46 PM, Namhyung Kim <namhyung@gmail.com> wrote: > > Now I'm seeing that there are some cases to free all pages in a > > pcp lists. In that case, just frees all pages in the lists instead > > of being bothered with round-robin lists traversal. > > I though about that but I didn't send the patch. > That's because many cases which calls free_pcppages_bulk(, > pcp->count,..) are slow path so it adds comparison overhead on fast > path while it loses the effectiveness in slow path. > Hmm.. How about adding unlikely() then? Doesn't it help much here? -- Regards, Namhyung Kim
WARNING: multiple messages have this Message-ID (diff)
From: Namhyung Kim <namhyung@gmail.com> To: Minchan Kim <minchan.kim@gmail.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mel@csn.ul.ie>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] mm: handle simple case in free_pcppages_bulk() Date: Thu, 10 Feb 2011 22:18:49 +0900 [thread overview] Message-ID: <1297343929.1449.3.camel@leonhard> (raw) In-Reply-To: <AANLkTikEigbPsNMqqkmixYbCfD7Dz12YMcW2+GZbhUQq@mail.gmail.com> 2011-02-10 (ea(C)), 22:10 +0900, Minchan Kim: > Hello Namhyung, > Hi Minchan, > On Thu, Feb 10, 2011 at 8:46 PM, Namhyung Kim <namhyung@gmail.com> wrote: > > Now I'm seeing that there are some cases to free all pages in a > > pcp lists. In that case, just frees all pages in the lists instead > > of being bothered with round-robin lists traversal. > > I though about that but I didn't send the patch. > That's because many cases which calls free_pcppages_bulk(, > pcp->count,..) are slow path so it adds comparison overhead on fast > path while it loses the effectiveness in slow path. > Hmm.. How about adding unlikely() then? Doesn't it help much here? -- Regards, Namhyung Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-10 13:19 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-10 11:46 [RFC PATCH] mm: handle simple case in free_pcppages_bulk() Namhyung Kim 2011-02-10 11:46 ` Namhyung Kim 2011-02-10 13:10 ` Minchan Kim 2011-02-10 13:10 ` Minchan Kim 2011-02-10 13:18 ` Namhyung Kim [this message] 2011-02-10 13:18 ` Namhyung Kim 2011-02-10 13:38 ` Minchan Kim 2011-02-10 13:38 ` Minchan Kim 2011-02-10 13:53 ` Namhyung Kim 2011-02-10 13:53 ` Namhyung Kim 2011-02-10 14:05 ` Mel Gorman 2011-02-10 14:05 ` Mel Gorman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1297343929.1449.3.camel@leonhard \ --to=namhyung@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mel@csn.ul.ie \ --cc=minchan.kim@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.