All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@gmail.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mel@csn.ul.ie>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] mm: handle simple case in free_pcppages_bulk()
Date: Thu, 10 Feb 2011 22:53:13 +0900	[thread overview]
Message-ID: <1297345993.1449.10.camel@leonhard> (raw)
In-Reply-To: <AANLkTimcLgsdEm6XKESc34Z=nsJkZqz8H1jR-ARZo_Gq@mail.gmail.com>

2011-02-10 (목), 22:38 +0900, Minchan Kim:
> > Hmm.. How about adding unlikely() then? Doesn't it help much here?
> 
> Yes. It would help but I am not sure how much it is.
> AFAIR, when Mel submit the patch, he tried to prove the effectiveness
> with some experiment and profiler.
> I think if you want it really, we might need some number.
> I am not sure it's worth.
> 

OK. Thanks for the comments. :)

And it would be really great if you (or somebody) told me how could I
make the numbers on my desktop.


-- 
Regards,
Namhyung Kim



WARNING: multiple messages have this Message-ID (diff)
From: Namhyung Kim <namhyung@gmail.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mel@csn.ul.ie>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] mm: handle simple case in free_pcppages_bulk()
Date: Thu, 10 Feb 2011 22:53:13 +0900	[thread overview]
Message-ID: <1297345993.1449.10.camel@leonhard> (raw)
In-Reply-To: <AANLkTimcLgsdEm6XKESc34Z=nsJkZqz8H1jR-ARZo_Gq@mail.gmail.com>

2011-02-10 (ea(C)), 22:38 +0900, Minchan Kim:
> > Hmm.. How about adding unlikely() then? Doesn't it help much here?
> 
> Yes. It would help but I am not sure how much it is.
> AFAIR, when Mel submit the patch, he tried to prove the effectiveness
> with some experiment and profiler.
> I think if you want it really, we might need some number.
> I am not sure it's worth.
> 

OK. Thanks for the comments. :)

And it would be really great if you (or somebody) told me how could I
make the numbers on my desktop.


-- 
Regards,
Namhyung Kim


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-02-10 13:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-10 11:46 [RFC PATCH] mm: handle simple case in free_pcppages_bulk() Namhyung Kim
2011-02-10 11:46 ` Namhyung Kim
2011-02-10 13:10 ` Minchan Kim
2011-02-10 13:10   ` Minchan Kim
2011-02-10 13:18   ` Namhyung Kim
2011-02-10 13:18     ` Namhyung Kim
2011-02-10 13:38     ` Minchan Kim
2011-02-10 13:38       ` Minchan Kim
2011-02-10 13:53       ` Namhyung Kim [this message]
2011-02-10 13:53         ` Namhyung Kim
2011-02-10 14:05       ` Mel Gorman
2011-02-10 14:05         ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297345993.1449.10.camel@leonhard \
    --to=namhyung@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=minchan.kim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.