From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Mel Gorman <mel@csn.ul.ie>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michael J Wolf <mjwolf@us.ibm.com>,
Johannes Weiner <hannes@cmpxchg.org>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH 5/5] have smaps show transparent huge pages
Date: Thu, 10 Feb 2011 10:20:32 -0800 [thread overview]
Message-ID: <1297362032.6737.14622.camel@nimitz> (raw)
In-Reply-To: <20110210180924.GB3347@random.random>
On Thu, 2011-02-10 at 19:09 +0100, Andrea Arcangeli wrote:
> Maybe it'd be cleaner if we didn't need to cast the pmd to pte_t but I
> guess this makes things simpler.
Yeah, I'm not a huge fan of doing that, either. But, I'm not sure what
the alternatives are. We could basically copy smaps_pte_entry() to
smaps_pmd_entry(), and then try to make pmd variants of all of the pte
functions and macros we call in there.
I know there's a least a bit of precedent in the hugetlbfs code for
doing things like this, but it's not a _great_ excuse. :)
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Mel Gorman <mel@csn.ul.ie>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michael J Wolf <mjwolf@us.ibm.com>,
Johannes Weiner <hannes@cmpxchg.org>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH 5/5] have smaps show transparent huge pages
Date: Thu, 10 Feb 2011 10:20:32 -0800 [thread overview]
Message-ID: <1297362032.6737.14622.camel@nimitz> (raw)
In-Reply-To: <20110210180924.GB3347@random.random>
On Thu, 2011-02-10 at 19:09 +0100, Andrea Arcangeli wrote:
> Maybe it'd be cleaner if we didn't need to cast the pmd to pte_t but I
> guess this makes things simpler.
Yeah, I'm not a huge fan of doing that, either. But, I'm not sure what
the alternatives are. We could basically copy smaps_pte_entry() to
smaps_pmd_entry(), and then try to make pmd variants of all of the pte
functions and macros we call in there.
I know there's a least a bit of precedent in the hugetlbfs code for
doing things like this, but it's not a _great_ excuse. :)
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-10 18:20 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 19:54 [PATCH 0/5] fix up /proc/$pid/smaps to not split huge pages Dave Hansen
2011-02-09 19:54 ` Dave Hansen
2011-02-09 19:54 ` [PATCH 1/5] pagewalk: only split huge pages when necessary Dave Hansen
2011-02-09 19:54 ` Dave Hansen
2011-02-10 11:11 ` Mel Gorman
2011-02-10 11:11 ` Mel Gorman
2011-02-10 13:19 ` Andrea Arcangeli
2011-02-10 13:19 ` Andrea Arcangeli
2011-02-10 13:34 ` Mel Gorman
2011-02-10 13:34 ` Mel Gorman
2011-02-09 19:54 ` [PATCH 2/5] break out smaps_pte_entry() from smaps_pte_range() Dave Hansen
2011-02-09 19:54 ` Dave Hansen
2011-02-10 11:15 ` Mel Gorman
2011-02-10 11:15 ` Mel Gorman
2011-02-09 19:54 ` [PATCH 3/5] pass pte size argument in to smaps_pte_entry() Dave Hansen
2011-02-09 19:54 ` Dave Hansen
2011-02-10 11:16 ` Mel Gorman
2011-02-10 11:16 ` Mel Gorman
2011-02-09 19:54 ` [PATCH 4/5] teach smaps_pte_range() about THP pmds Dave Hansen
2011-02-09 19:54 ` Dave Hansen
2011-02-10 11:17 ` Mel Gorman
2011-02-10 11:17 ` Mel Gorman
2011-02-10 18:08 ` Andrea Arcangeli
2011-02-10 18:08 ` Andrea Arcangeli
2011-02-10 19:32 ` Dave Hansen
2011-02-10 19:32 ` Dave Hansen
2011-02-09 19:54 ` [PATCH 5/5] have smaps show transparent huge pages Dave Hansen
2011-02-09 19:54 ` Dave Hansen
2011-02-10 11:20 ` Mel Gorman
2011-02-10 11:20 ` Mel Gorman
2011-02-10 15:01 ` Dave Hansen
2011-02-10 15:01 ` Dave Hansen
2011-02-10 15:09 ` Mel Gorman
2011-02-10 15:09 ` Mel Gorman
2011-02-10 18:09 ` Andrea Arcangeli
2011-02-10 18:09 ` Andrea Arcangeli
2011-02-10 18:20 ` Dave Hansen [this message]
2011-02-10 18:20 ` Dave Hansen
2011-02-10 18:39 ` Andrea Arcangeli
2011-02-10 18:39 ` Andrea Arcangeli
2011-02-09 21:24 ` [PATCH 0/5] fix up /proc/$pid/smaps to not split " Andrea Arcangeli
2011-02-09 21:24 ` Andrea Arcangeli
2011-02-20 21:54 ` David Rientjes
2011-02-20 21:54 ` David Rientjes
2011-02-15 16:55 ` Eric B Munson
2011-02-15 17:01 ` Andrea Arcangeli
2011-02-15 17:01 ` Andrea Arcangeli
2011-02-15 17:05 ` Dave Hansen
2011-02-15 17:05 ` Dave Hansen
2011-02-15 18:00 ` Andrea Arcangeli
2011-02-15 18:00 ` Andrea Arcangeli
2011-02-22 1:53 Dave Hansen
2011-02-22 1:53 ` [PATCH 5/5] have smaps show transparent " Dave Hansen
2011-02-22 1:53 ` Dave Hansen
2011-02-23 15:31 ` Eric B Munson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297362032.6737.14622.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mjwolf@us.ibm.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.